Introduce reserved ml privilege for the apm_user role #72266
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
legrego
changed the title
legrego
added
:ml
release_note:skip
|
Pinging @elastic/ml-ui (:ml) |
|
Pinging @elastic/kibana-security (Team:Security) |
|
Pinging @elastic/apm-ui (Team:apm) |
sorenlouv
reviewed
Jul 20, 2020
| @@ -14,11 +14,11 @@ export const METRICS_FEATURE = { | |||
| order: 700, | |||
| icon: 'metricsApp', | |||
| navLinkId: 'metrics', | |||
| app: ['infra', 'kibana'], | |||
| app: ['infra', 'metrics', 'kibana'], | |||
| catalogue: ['infraops'], | |||
There was a problem hiding this comment.
Maybe a silly question: why is this PR updating the infra app and not the apm app?
There was a problem hiding this comment.
APM is already "compliant" with the new requirement that your navLinkId value must be included in your app array. Infra was one of the few that weren't already configured this way:
kibana/x-pack/plugins/apm/server/feature.ts
Lines 16 to 17 in 2642d65
sorenlouv
approved these changes
Jul 20, 2020
|
@elasticmachine merge upstream |
azasypkin
approved these changes
Jul 22, 2020
x-pack/test/functional/apps/infra/feature_controls/infrastructure_spaces.ts
Show resolved
Hide resolved
weltenwort
approved these changes
Jul 27, 2020
|
@elasticmachine merge upstream |
💚 Build SucceededBuild metricspage load bundle size
History
To update your PR or re-run it, just comment with: |
|
Thanks all for your reviews and testing, I appreciate it! |
This was referenced Jul 28, 2020
legrego
added a commit
to legrego/kibana
that referenced
this pull request
Jul 28, 2020
Co-authored-by: Elastic Machine <[email protected]>
legrego
added a commit
to legrego/kibana
that referenced
this pull request
Jul 28, 2020
Co-authored-by: Elastic Machine <[email protected]>
legrego
added a commit
that referenced
this pull request
Jul 28, 2020
…73431) Co-authored-by: Elastic Machine <[email protected]> Co-authored-by: Elastic Machine <[email protected]>
legrego
added a commit
that referenced
this pull request
Jul 28, 2020
…73432) Co-authored-by: Elastic Machine <[email protected]> Co-authored-by: Elastic Machine <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a new Kibana "reserved" privilege to the Machine Learning feature, in order to grant access to a subset of ML functionality within Kibana. This new privilege will be granted to the builtin
apm_userrole via elastic/elasticsearch#59854.Previously, the
apm_userrole was authorized to retrieve ML jobs by virtue of its privileges against the.ml-anomalies*set of indices. This access is no longer sufficient, now that the ML feature is taking advantage of the Kibana privilege model.In order to maintain BWC for existing users of the
apm_userrole, it's necessary to create a reserved privilege which mimics the previous access that this role used to have. Eventually, the Kibana privilege model will be updated to support access to ML jobs in a more holistic manner, but that is a longer term initiative.Corresponding Elasticsearch PR: elastic/elasticsearch#59854
If you were pinged for CODEOWNERS review, and you're not on the Security or ML teams:
This new reserved privilege is the first of its kind which needs to grant access to a feature's underlying functionality, without granting access to the UI application itself. As a result, this PR also takes additional steps to transition away from the
navLinkIdproperty of the feature, in favor of theappproperty (see #66217).In short, this means that every feature which declares a
navLinkIdmust also include that id as one of theirappentries in the feature.To fully test this end-to-end, you must run Elasticsearch from my branch: https://github.com/legrego/elasticsearch/tree/fc/reserved_ml_apm_user
Resolves: #72260