Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove navLinkId property from feature registration #66217

Closed
legrego opened this issue May 12, 2020 · 1 comment · Fixed by #80909
Closed

Remove navLinkId property from feature registration #66217

legrego opened this issue May 12, 2020 · 1 comment · Fixed by #80909
Assignees
Labels
chore :Security/Feature Controls Team:Security Team focused on: Auth, Users, Roles, Spaces, Audit Logging, and more!

Comments

@legrego
Copy link
Member

legrego commented May 12, 2020

The Legacy Platform required the feature registration to have a distinct navLinkId property, which features had to register. This was typically the same as the application id, but was not always the case.
A notable exception were the kibana apps, which had multiple UI features within the same UI app. This generated nav link ids similar to kibana:discover, kibana:visualize and kibana:dashboards. Now that we are splitting these out into their own discrete plugins (see #63443), we can remove this extraneous property from feature registration.

Once this is removed, we should be able to populate the navLinks UI Capability property based on the registered application ids alone.

@legrego legrego added chore Team:Security Team focused on: Auth, Users, Roles, Spaces, Audit Logging, and more! :Security/Feature Controls labels May 12, 2020
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-security (Team:Security)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore :Security/Feature Controls Team:Security Team focused on: Auth, Users, Roles, Spaces, Audit Logging, and more!
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants