-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Removed filtering for Case owned ServiceNow actions from the Management UI and make it usable for Alerts. Added documentation. #71579
Conversation
…nt UI and make it usable for Alerts. Added documentation.
Pinging @elastic/kibana-alerting-services (Team:Alerting Services) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Functionality wise things looks good! A few comments in the asciidocs. It seems a few paragraphs got copied over from the email docs. Once fixed, it would be good to get @gchaps to do a review 🙏 .
…w-case-connector-usage-fix # Please enter a commit message to explain why this merge is necessary, # especially if it merges an updated upstream into a topic branch. # # Lines starting with '#' will be ignored, and an empty message aborts # the commit.
@@ -55,3 +59,4 @@ include::action-types/server-log.asciidoc[] | |||
include::action-types/slack.asciidoc[] | |||
include::action-types/webhook.asciidoc[] | |||
include::action-types/pre-configured-connectors.asciidoc[] | |||
include::action-types/servicenow.asciidoc[] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Move this so it is in between serverlog and slack.
Co-authored-by: gchaps <[email protected]>
Co-authored-by: gchaps <[email protected]>
Co-authored-by: gchaps <[email protected]>
Co-authored-by: gchaps <[email protected]>
Co-authored-by: gchaps <[email protected]>
Co-authored-by: gchaps <[email protected]>
Co-authored-by: gchaps <[email protected]>
Co-authored-by: gchaps <[email protected]>
…com:YulNaumenko/kibana into actions-servicenow-case-connector-usage-fix
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
…w-case-connector-usage-fix # Please enter a commit message to explain why this merge is necessary, # especially if it merges an updated upstream into a topic branch. # # Lines starting with '#' will be ignored, and an empty message aborts # the commit.
…w-case-connector-usage-fix # Please enter a commit message to explain why this merge is necessary, # especially if it merges an updated upstream into a topic branch. # # Lines starting with '#' will be ignored, and an empty message aborts # the commit.
…w-case-connector-usage-fix
…w-case-connector-usage-fix # Please enter a commit message to explain why this merge is necessary, # especially if it merges an updated upstream into a topic branch. # # Lines starting with '#' will be ignored, and an empty message aborts # the commit.
💚 Build SucceededBuild metricsasync chunks size
miscellaneous assets size
History
To update your PR or re-run it, just comment with: |
…nt UI and make it usable for Alerts. Added documentation. (elastic#71579) * Removed filtering for Case owned ServiceNow actions from the Management UI and make it usable for Alerts. Added documentation. * extended docs * Fixed docs * fixed connector page * Changed SN variables components * Fixed issues * fixed order * Update docs/user/alerting/action-types/servicenow.asciidoc Co-authored-by: gchaps <[email protected]> * Update docs/user/alerting/action-types/servicenow.asciidoc Co-authored-by: gchaps <[email protected]> * Update docs/user/alerting/action-types/servicenow.asciidoc Co-authored-by: gchaps <[email protected]> * Update docs/user/alerting/action-types/servicenow.asciidoc Co-authored-by: gchaps <[email protected]> * Update docs/user/alerting/action-types/servicenow.asciidoc Co-authored-by: gchaps <[email protected]> * Update docs/user/alerting/action-types/servicenow.asciidoc Co-authored-by: gchaps <[email protected]> * Update docs/user/alerting/action-types/servicenow.asciidoc Co-authored-by: gchaps <[email protected]> * Update docs/user/alerting/action-types/servicenow.asciidoc Co-authored-by: gchaps <[email protected]> * - * fixed tests Co-authored-by: gchaps <[email protected]>
…nt UI and make it usable for Alerts. Added documentation. (elastic#71579) * Removed filtering for Case owned ServiceNow actions from the Management UI and make it usable for Alerts. Added documentation. * extended docs * Fixed docs * fixed connector page * Changed SN variables components * Fixed issues * fixed order * Update docs/user/alerting/action-types/servicenow.asciidoc Co-authored-by: gchaps <[email protected]> * Update docs/user/alerting/action-types/servicenow.asciidoc Co-authored-by: gchaps <[email protected]> * Update docs/user/alerting/action-types/servicenow.asciidoc Co-authored-by: gchaps <[email protected]> * Update docs/user/alerting/action-types/servicenow.asciidoc Co-authored-by: gchaps <[email protected]> * Update docs/user/alerting/action-types/servicenow.asciidoc Co-authored-by: gchaps <[email protected]> * Update docs/user/alerting/action-types/servicenow.asciidoc Co-authored-by: gchaps <[email protected]> * Update docs/user/alerting/action-types/servicenow.asciidoc Co-authored-by: gchaps <[email protected]> * Update docs/user/alerting/action-types/servicenow.asciidoc Co-authored-by: gchaps <[email protected]> * - * fixed tests Co-authored-by: gchaps <[email protected]>
…nt UI and make it usable for Alerts. Added documentation. (#71579) (#71914) * Removed filtering for Case owned ServiceNow actions from the Management UI and make it usable for Alerts. Added documentation. * extended docs * Fixed docs * fixed connector page * Changed SN variables components * Fixed issues * fixed order * Update docs/user/alerting/action-types/servicenow.asciidoc Co-authored-by: gchaps <[email protected]> * Update docs/user/alerting/action-types/servicenow.asciidoc Co-authored-by: gchaps <[email protected]> * Update docs/user/alerting/action-types/servicenow.asciidoc Co-authored-by: gchaps <[email protected]> * Update docs/user/alerting/action-types/servicenow.asciidoc Co-authored-by: gchaps <[email protected]> * Update docs/user/alerting/action-types/servicenow.asciidoc Co-authored-by: gchaps <[email protected]> * Update docs/user/alerting/action-types/servicenow.asciidoc Co-authored-by: gchaps <[email protected]> * Update docs/user/alerting/action-types/servicenow.asciidoc Co-authored-by: gchaps <[email protected]> * Update docs/user/alerting/action-types/servicenow.asciidoc Co-authored-by: gchaps <[email protected]> * - * fixed tests Co-authored-by: gchaps <[email protected]> Co-authored-by: gchaps <[email protected]>
…nt UI and make it usable for Alerts. Added documentation. (#71579) (#71913) * Removed filtering for Case owned ServiceNow actions from the Management UI and make it usable for Alerts. Added documentation. * extended docs * Fixed docs * fixed connector page * Changed SN variables components * Fixed issues * fixed order * Update docs/user/alerting/action-types/servicenow.asciidoc Co-authored-by: gchaps <[email protected]> * Update docs/user/alerting/action-types/servicenow.asciidoc Co-authored-by: gchaps <[email protected]> * Update docs/user/alerting/action-types/servicenow.asciidoc Co-authored-by: gchaps <[email protected]> * Update docs/user/alerting/action-types/servicenow.asciidoc Co-authored-by: gchaps <[email protected]> * Update docs/user/alerting/action-types/servicenow.asciidoc Co-authored-by: gchaps <[email protected]> * Update docs/user/alerting/action-types/servicenow.asciidoc Co-authored-by: gchaps <[email protected]> * Update docs/user/alerting/action-types/servicenow.asciidoc Co-authored-by: gchaps <[email protected]> * Update docs/user/alerting/action-types/servicenow.asciidoc Co-authored-by: gchaps <[email protected]> * - * fixed tests Co-authored-by: gchaps <[email protected]> Co-authored-by: gchaps <[email protected]>
Resolve #71155