Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed filtering for Case owned ServiceNow actions from the Management UI and make it usable for Alerts. Added documentation. #71579

Conversation

YulNaumenko
Copy link
Contributor

Resolve #71155

…nt UI and make it usable for Alerts. Added documentation.
@YulNaumenko YulNaumenko added Feature:Alerting v8.0.0 release_note:skip Skip the PR/issue when compiling release notes Team:ResponseOps Label for the ResponseOps team (formerly the Cases and Alerting teams) v7.9.0 labels Jul 14, 2020
@YulNaumenko YulNaumenko requested a review from a team as a code owner July 14, 2020 01:03
@YulNaumenko YulNaumenko self-assigned this Jul 14, 2020
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-alerting-services (Team:Alerting Services)

Copy link
Contributor

@mikecote mikecote left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Functionality wise things looks good! A few comments in the asciidocs. It seems a few paragraphs got copied over from the email docs. Once fixed, it would be good to get @gchaps to do a review 🙏 .

docs/user/alerting/action-types.asciidoc Outdated Show resolved Hide resolved
docs/user/alerting/action-types.asciidoc Outdated Show resolved Hide resolved
docs/user/alerting/action-types/servicenow.asciidoc Outdated Show resolved Hide resolved
docs/user/alerting/action-types/servicenow.asciidoc Outdated Show resolved Hide resolved
docs/user/alerting/action-types/servicenow.asciidoc Outdated Show resolved Hide resolved
docs/user/alerting/action-types/servicenow.asciidoc Outdated Show resolved Hide resolved
docs/user/alerting/action-types/servicenow.asciidoc Outdated Show resolved Hide resolved
@YulNaumenko YulNaumenko requested a review from mikecote July 14, 2020 18:01
…w-case-connector-usage-fix

# Please enter a commit message to explain why this merge is necessary,
# especially if it merges an updated upstream into a topic branch.
#
# Lines starting with '#' will be ignored, and an empty message aborts
# the commit.
@@ -55,3 +59,4 @@ include::action-types/server-log.asciidoc[]
include::action-types/slack.asciidoc[]
include::action-types/webhook.asciidoc[]
include::action-types/pre-configured-connectors.asciidoc[]
include::action-types/servicenow.asciidoc[]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Move this so it is in between serverlog and slack.

docs/user/alerting/action-types.asciidoc Show resolved Hide resolved
docs/user/alerting/action-types/servicenow.asciidoc Outdated Show resolved Hide resolved
docs/user/alerting/action-types/servicenow.asciidoc Outdated Show resolved Hide resolved
docs/user/alerting/action-types/servicenow.asciidoc Outdated Show resolved Hide resolved
docs/user/alerting/action-types/servicenow.asciidoc Outdated Show resolved Hide resolved
docs/user/alerting/action-types/servicenow.asciidoc Outdated Show resolved Hide resolved
docs/user/alerting/action-types/servicenow.asciidoc Outdated Show resolved Hide resolved
docs/user/alerting/action-types/servicenow.asciidoc Outdated Show resolved Hide resolved
docs/user/alerting/action-types/servicenow.asciidoc Outdated Show resolved Hide resolved
Copy link
Contributor

@mikecote mikecote left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

…w-case-connector-usage-fix

# Please enter a commit message to explain why this merge is necessary,
# especially if it merges an updated upstream into a topic branch.
#
# Lines starting with '#' will be ignored, and an empty message aborts
# the commit.
…w-case-connector-usage-fix

# Please enter a commit message to explain why this merge is necessary,
# especially if it merges an updated upstream into a topic branch.
#
# Lines starting with '#' will be ignored, and an empty message aborts
# the commit.
…w-case-connector-usage-fix

# Please enter a commit message to explain why this merge is necessary,
# especially if it merges an updated upstream into a topic branch.
#
# Lines starting with '#' will be ignored, and an empty message aborts
# the commit.
@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Build metrics

async chunks size

id value diff baseline
triggers_actions_ui 925.3KB +8.3KB 917.1KB

miscellaneous assets size

id value diff baseline
triggers_actions_ui 103.8KB +36.0B 103.8KB
upgradeAssistant 22.5KB +4.0B 22.5KB
total - +40.0B -

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@YulNaumenko YulNaumenko merged commit 5c5d75f into elastic:master Jul 15, 2020
YulNaumenko added a commit to YulNaumenko/kibana that referenced this pull request Jul 15, 2020
…nt UI and make it usable for Alerts. Added documentation. (elastic#71579)

* Removed filtering for Case owned ServiceNow actions from the Management UI and make it usable for Alerts. Added documentation.

* extended docs

* Fixed docs

* fixed connector page

* Changed SN variables components

* Fixed issues

* fixed order

* Update docs/user/alerting/action-types/servicenow.asciidoc

Co-authored-by: gchaps <[email protected]>

* Update docs/user/alerting/action-types/servicenow.asciidoc

Co-authored-by: gchaps <[email protected]>

* Update docs/user/alerting/action-types/servicenow.asciidoc

Co-authored-by: gchaps <[email protected]>

* Update docs/user/alerting/action-types/servicenow.asciidoc

Co-authored-by: gchaps <[email protected]>

* Update docs/user/alerting/action-types/servicenow.asciidoc

Co-authored-by: gchaps <[email protected]>

* Update docs/user/alerting/action-types/servicenow.asciidoc

Co-authored-by: gchaps <[email protected]>

* Update docs/user/alerting/action-types/servicenow.asciidoc

Co-authored-by: gchaps <[email protected]>

* Update docs/user/alerting/action-types/servicenow.asciidoc

Co-authored-by: gchaps <[email protected]>

* -

* fixed tests

Co-authored-by: gchaps <[email protected]>
YulNaumenko added a commit to YulNaumenko/kibana that referenced this pull request Jul 15, 2020
…nt UI and make it usable for Alerts. Added documentation. (elastic#71579)

* Removed filtering for Case owned ServiceNow actions from the Management UI and make it usable for Alerts. Added documentation.

* extended docs

* Fixed docs

* fixed connector page

* Changed SN variables components

* Fixed issues

* fixed order

* Update docs/user/alerting/action-types/servicenow.asciidoc

Co-authored-by: gchaps <[email protected]>

* Update docs/user/alerting/action-types/servicenow.asciidoc

Co-authored-by: gchaps <[email protected]>

* Update docs/user/alerting/action-types/servicenow.asciidoc

Co-authored-by: gchaps <[email protected]>

* Update docs/user/alerting/action-types/servicenow.asciidoc

Co-authored-by: gchaps <[email protected]>

* Update docs/user/alerting/action-types/servicenow.asciidoc

Co-authored-by: gchaps <[email protected]>

* Update docs/user/alerting/action-types/servicenow.asciidoc

Co-authored-by: gchaps <[email protected]>

* Update docs/user/alerting/action-types/servicenow.asciidoc

Co-authored-by: gchaps <[email protected]>

* Update docs/user/alerting/action-types/servicenow.asciidoc

Co-authored-by: gchaps <[email protected]>

* -

* fixed tests

Co-authored-by: gchaps <[email protected]>
YulNaumenko added a commit that referenced this pull request Jul 15, 2020
…nt UI and make it usable for Alerts. Added documentation. (#71579) (#71914)

* Removed filtering for Case owned ServiceNow actions from the Management UI and make it usable for Alerts. Added documentation.

* extended docs

* Fixed docs

* fixed connector page

* Changed SN variables components

* Fixed issues

* fixed order

* Update docs/user/alerting/action-types/servicenow.asciidoc

Co-authored-by: gchaps <[email protected]>

* Update docs/user/alerting/action-types/servicenow.asciidoc

Co-authored-by: gchaps <[email protected]>

* Update docs/user/alerting/action-types/servicenow.asciidoc

Co-authored-by: gchaps <[email protected]>

* Update docs/user/alerting/action-types/servicenow.asciidoc

Co-authored-by: gchaps <[email protected]>

* Update docs/user/alerting/action-types/servicenow.asciidoc

Co-authored-by: gchaps <[email protected]>

* Update docs/user/alerting/action-types/servicenow.asciidoc

Co-authored-by: gchaps <[email protected]>

* Update docs/user/alerting/action-types/servicenow.asciidoc

Co-authored-by: gchaps <[email protected]>

* Update docs/user/alerting/action-types/servicenow.asciidoc

Co-authored-by: gchaps <[email protected]>

* -

* fixed tests

Co-authored-by: gchaps <[email protected]>

Co-authored-by: gchaps <[email protected]>
YulNaumenko added a commit that referenced this pull request Jul 15, 2020
…nt UI and make it usable for Alerts. Added documentation. (#71579) (#71913)

* Removed filtering for Case owned ServiceNow actions from the Management UI and make it usable for Alerts. Added documentation.

* extended docs

* Fixed docs

* fixed connector page

* Changed SN variables components

* Fixed issues

* fixed order

* Update docs/user/alerting/action-types/servicenow.asciidoc

Co-authored-by: gchaps <[email protected]>

* Update docs/user/alerting/action-types/servicenow.asciidoc

Co-authored-by: gchaps <[email protected]>

* Update docs/user/alerting/action-types/servicenow.asciidoc

Co-authored-by: gchaps <[email protected]>

* Update docs/user/alerting/action-types/servicenow.asciidoc

Co-authored-by: gchaps <[email protected]>

* Update docs/user/alerting/action-types/servicenow.asciidoc

Co-authored-by: gchaps <[email protected]>

* Update docs/user/alerting/action-types/servicenow.asciidoc

Co-authored-by: gchaps <[email protected]>

* Update docs/user/alerting/action-types/servicenow.asciidoc

Co-authored-by: gchaps <[email protected]>

* Update docs/user/alerting/action-types/servicenow.asciidoc

Co-authored-by: gchaps <[email protected]>

* -

* fixed tests

Co-authored-by: gchaps <[email protected]>

Co-authored-by: gchaps <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature:Alerting release_note:skip Skip the PR/issue when compiling release notes Team:ResponseOps Label for the ResponseOps team (formerly the Cases and Alerting teams) v7.9.0 v8.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove filtering Case owned ServiceNow actions from the Management UI and make it usable for Alerts
5 participants