-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Metrics UI] Consolidate Inventory and Metrics Explorer APIs #71575
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@simianhacker does this fix #71539? |
@sgrodzicki It donesn't, that issue is for the frontend. In the new default view feature there is a call to |
2e90fed
to
87df666
Compare
87df666
to
d252f9f
Compare
💔 Build Failed
Failed CI Steps
Test FailuresKibana Pipeline / x-pack-intake-agent / X-Pack Jest Tests.x-pack/plugins/infra/public/pages/metrics/inventory_view/components/waffle.ConditionalToolTip should just workStandard Out
Stack Trace
Build metrics
History
To update your PR or re-run it, just comment with: |
Closing in favor of #74804 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Feature:Metrics UI
Metrics UI feature
release_note:skip
Skip the PR/issue when compiling release notes
Team:Infra Monitoring UI - DEPRECATED
DEPRECATED - Label for the Infra Monitoring UI team. Use Team:obs-ux-infra_services
v7.10.0
v8.0.0
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
The Metrics Explorer API and Snapshot API essential are doing the same things except the Metric Explorer API can't be used by the Alerts system because it utilizes TSVB (which requires a valid request object). The surface area of bringing parity to the Snapshot API is smaller than updating TSVB to NOT use the request object.
Snapshot API Gap:
limit
andafterKey
supportnodeType
auto
and>=1m
intervalsgetBucketSize
(and test) from TSVB, this is only honored ifforceInterval
is usedgetNodes
indexPattern
foruseSource
to thelogsAlias
createTimeRangeWithInterval
getIndexFields
Checklist
Delete any items that are not applicable to this PR.
For maintainers