Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Metrics UI] Inventory View sends two request for the Snapshot API #71539

Closed
simianhacker opened this issue Jul 13, 2020 · 2 comments
Closed

[Metrics UI] Inventory View sends two request for the Snapshot API #71539

simianhacker opened this issue Jul 13, 2020 · 2 comments
Assignees
@Zacqary
Labels
bug Fixes for quality problems that affect the customer experience Feature:Metrics UI Metrics UI feature Team:Infra Monitoring UI - DEPRECATED DEPRECATED - Label for the Infra Monitoring UI team. Use Team:obs-ux-infra_services
Milestone
Metrics UI 7.10

Comments

@simianhacker
Copy link
Member

Kibana version:

master

Elasticsearch version:

master

Original install method (e.g. download page, yum, from source, etc.):

source

Describe the bug:

When you load the snapshot page it sends two identical requests. This is because in the Layout component the useSnapshot() hook is being called without setting the sendRequestImmediatly argument to false

Steps to reproduce:

  1. Open dev console
  2. Goto Metrics UI home page
  3. Observe /api/metrics/snapshot is hit twice

Expected behavior:

It should only make one request.
@simianhacker simianhacker added bug Fixes for quality problems that affect the customer experience Feature:Metrics UI Metrics UI feature Team:Infra Monitoring UI - DEPRECATED DEPRECATED - Label for the Infra Monitoring UI team. Use Team:obs-ux-infra_services labels Jul 13, 2020
@elasticmachine
Copy link
Contributor

Pinging @elastic/logs-metrics-ui (Team:logs-metrics-ui)

@sgrodzicki sgrodzicki mentioned this issue Jul 14, 2020
Closed
17 tasks
@Zacqary Zacqary self-assigned this Aug 10, 2020
@Zacqary
Copy link
Contributor

Zacqary commented Aug 10, 2020

This was fixed by #72518

@Zacqary Zacqary closed this as completed Aug 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Zacqary Zacqary

Labels
bug Fixes for quality problems that affect the customer experience Feature:Metrics UI Metrics UI feature Team:Infra Monitoring UI - DEPRECATED DEPRECATED - Label for the Infra Monitoring UI team. Use Team:obs-ux-infra_services
Projects
None yet
Milestone
Metrics UI 7.10
Development

No branches or pull requests
4 participants
@simianhacker @sgrodzicki @Zacqary @elasticmachine