Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add short sleep before clicking Remove on sample data #71104

Merged
merged 5 commits into from
Jul 15, 2020
Merged

add short sleep before clicking Remove on sample data #71104

Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
7b8bdc2
add short sleep before clicking Remove on sample data
Jul 8, 2020
a6d4cac
only run this sample data dashboard test
Jul 8, 2020
f148579
Merge branch 'master' into sleepOnRemovingSampleData
elasticmachine Jul 8, 2020
271215a
remove .only on test suite
Jul 8, 2020
4584550
Merge branch 'master' into sleepOnRemovingSampleData
elasticmachine Jul 14, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions test/functional/page_objects/home_page.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,6 +54,10 @@ export function HomePageProvider({ getService, getPageObjects }: FtrProviderCont
async removeSampleDataSet(id: string) {
// looks like overkill but we're hitting flaky cases where we click but it doesn't remove
await testSubjects.waitForEnabled(`removeSampleDataSet${id}`);
// https://github.com/elastic/kibana/issues/65949
// Even after waiting for the "Remove" button to be enabled we still have failures
// where it appears the click just didn't work.
await PageObjects.common.sleep(1010);
await testSubjects.click(`removeSampleDataSet${id}`);
await this._waitForSampleDataLoadingAction(id);
}
Expand Down