add short sleep before clicking Remove on sample data

[LeeDr]

Summary

Fixes: #65949

Actually I wouldn't call it a "fix" but more of a work-around. Screenshots from intermittent failures on removing sample data show the "Remove" button as if it had not been clicked but the logs indicate that it found and clicked it.

My theory is that 2 checks have to happen when the sample data page loads, for each set of sample data;

1. check if it's installed or not
2. check if the logged in user has the privileges to add or remove the data

I don't know the order that those checks happen in (and maybe other checks) vs when the "Remove" button is rendered, but there could be a small timing window where the button is visible and enabled but actually won't remove the same data.
This PR attempts to test that case by adding about a 1 second sleep (I use 1010ms to make it easier to find something that might be unique in the logs) between the time we find the button is enabled and when we click it.

Alternatively we could change the removeSampleDataSet to retry clicking the button until we find it changed to disabled. But that feels worse to me, as far as masking a potential code bug, then adding a small delay before a single try.

Checklist

Delete any items that are not applicable to this PR.

• Any text added follows EUI's writing guidelines, uses sentence case text and includes i18n support
• Documentation was added for features that require explanation or tutorials
• Unit or functional tests were updated or added to match the most common scenarios
• This was checked for keyboard-only and screenreader accessibility
• This renders correctly on smaller devices using a responsive layout. (You can test this in your browser
• This was checked for cross-browser compatibility

For maintainers

• This was checked for breaking API changes and was labeled appropriately

[LeeDr]

@elasticmachine merge upstream

[LeeDr]

The last run failed because I put .only on the async_dashboard test suite for the flaky test runner. It passed 100/100 runs there.

[LeeDr]

@elasticmachine merge upstream

[elasticmachine]

Pinging @elastic/kibana-core-ui (Team:Core UI)

[myasonik]

LGTM!

It maybe isn't perfect but this seems like a good enough solution to merge

[kibanamachine]

💚 Build Succeeded

• continuous-integration/kibana-ci/pull-request
• Commit: 4584550

Build metrics

✅ unchanged

History

• 💚 Build #59937 succeeded 271215a
• 💔 Build #59861 failed f148579
• 💔 Build #59839 failed a6d4cac
• 💔 Build #59782 failed 7b8bdc2

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream