Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding test user to maps functional tests - PR 1 #70649

Merged
merged 4 commits into from
Jul 6, 2020
Merged

Adding test user to maps functional tests - PR 1 #70649

merged 4 commits into from
Jul 6, 2020

Conversation

bhavyarm
Copy link
Contributor

@bhavyarm bhavyarm commented Jul 2, 2020

Meta - #60815

@bhavyarm bhavyarm added v8.0.0 release_note:skip Skip the PR/issue when compiling release notes test_xpack_functional labels Jul 2, 2020
@bhavyarm
Copy link
Contributor Author

bhavyarm commented Jul 3, 2020

@elasticmachine merge upstream

1 similar comment
@mistic
Copy link
Member

mistic commented Jul 3, 2020

@elasticmachine merge upstream

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Build metrics

✅ unchanged

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@bhavyarm bhavyarm marked this pull request as ready for review July 6, 2020 12:26
@bhavyarm bhavyarm requested a review from a team as a code owner July 6, 2020 12:26
@rashmivkulkarni rashmivkulkarni mentioned this pull request Jul 6, 2020
Closed
68 tasks
LeeDr
LeeDr approved these changes Jul 6, 2020
View reviewed changes
Copy link

@LeeDr LeeDr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - code review only

LeeDr
LeeDr reviewed Jul 6, 2020
View reviewed changes
x-pack/test/functional/apps/maps/discover.js
'geoshape_data_reader',
'global_discover_read',
'global_visualize_read',
]);
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I noticed the other setRoles added in this PR used the false second parameter so that it doesn't refresh the browser. That could probably also be added here since the next step it to navigate (which always refreshes the browser as well). But I don't think there's any harm leaving this as-is.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@LeeDr yes visualize_create_menu.js wouln't pass without refreshing the browser. Thanks!

thomasneirynck
thomasneirynck approved these changes Jul 6, 2020
View reviewed changes
Copy link
Contributor

@thomasneirynck thomasneirynck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

code review. Thx for addressing this @bhavyarm

rashmivkulkarni
rashmivkulkarni approved these changes Jul 6, 2020
View reviewed changes
Copy link
Contributor

@rashmivkulkarni rashmivkulkarni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code reviewed and LGTM . Good to know about the reasoning behind false parameter in the before function for refreshing the browser.

@rashmivkulkarni
Copy link
Contributor

Also, this test needs to be tested on Cloud 8.0 and 7.9.

@bhavyarm
Copy link
Contributor Author

bhavyarm commented Jul 6, 2020

8.0.0 cloud test run - https://internal-ci.elastic.co/view/Stack%20Tests/job/elastic+estf-cloud-kibana-flaky-test-runner/44/ - pass!

@bhavyarm bhavyarm merged commit 94a18fd into elastic:master Jul 6, 2020
@bhavyarm bhavyarm mentioned this pull request Jul 6, 2020
Merged
bhavyarm added a commit to bhavyarm/kibana that referenced this pull request Jul 6, 2020
@bhavyarm
Adding test user to maps functional tests - PR 1 (elastic#70649)
54e284a 
adding test user to pr 1 of maps functional tests.
gmmorris added a commit to gmmorris/kibana that referenced this pull request Jul 7, 2020
@gmmorris
Merge branch 'master' into alerting/consumer-based-rbac
ae3c7a7 
* master: (53 commits)
  [Composable template] Details panel + delete functionality (elastic#70814)
  [Uptime] Ping list body scroll (elastic#70781)
  moving indexPattern.delete() to indexPatterns.delete(indexPattern) (elastic#70430)
  Adapt expected response of advanced settings feature control for cloud tests (elastic#70793)
  skip flaky suite (elastic#70885)
  skip flaky suite (elastic#67814)
  skip flaky suite (elastic#70906)
  Revert "reenable regression and classification functional tests (elastic#70661)" (elastic#70908)
  Added UI validation when creating a Webhook connector with invalid URL (elastic#70025)
  [Security Solution] Change default index pattern (elastic#70797)
  ServiceNow push to Incident generic implementation (supporting both Case specific and generic Alerts) (elastic#68464)
  add button link to ingest (elastic#70142)
  reenable regression and classification functional tests (elastic#70661)
  [Component templates] Form wizard (elastic#69732)
  [Ingest Manager] Copy changes (elastic#70828)
  Adding test user to maps functional tests - PR 1 (elastic#70649)
  [Ingest Manager] Support limiting integrations on an agent config (elastic#70542)
  skip flaky suite (elastic#70880)
  [Metrics UI] Fix a bug in Metric Threshold query filter construction (elastic#70672)
  upgrade caniuse-lite database (elastic#70833)
  ...
gmmorris added a commit to gmmorris/kibana that referenced this pull request Jul 7, 2020
@gmmorris
Merge branch 'master' into actions/feature
61626a0 
* master: (46 commits)
  [Composable template] Details panel + delete functionality (elastic#70814)
  [Uptime] Ping list body scroll (elastic#70781)
  moving indexPattern.delete() to indexPatterns.delete(indexPattern) (elastic#70430)
  Adapt expected response of advanced settings feature control for cloud tests (elastic#70793)
  skip flaky suite (elastic#70885)
  skip flaky suite (elastic#67814)
  skip flaky suite (elastic#70906)
  Revert "reenable regression and classification functional tests (elastic#70661)" (elastic#70908)
  Added UI validation when creating a Webhook connector with invalid URL (elastic#70025)
  [Security Solution] Change default index pattern (elastic#70797)
  ServiceNow push to Incident generic implementation (supporting both Case specific and generic Alerts) (elastic#68464)
  add button link to ingest (elastic#70142)
  reenable regression and classification functional tests (elastic#70661)
  [Component templates] Form wizard (elastic#69732)
  [Ingest Manager] Copy changes (elastic#70828)
  Adding test user to maps functional tests - PR 1 (elastic#70649)
  [Ingest Manager] Support limiting integrations on an agent config (elastic#70542)
  skip flaky suite (elastic#70880)
  [Metrics UI] Fix a bug in Metric Threshold query filter construction (elastic#70672)
  upgrade caniuse-lite database (elastic#70833)
  ...
gmmorris added a commit to gmmorris/kibana that referenced this pull request Jul 7, 2020
@gmmorris
Merge branch 'actions/feature' into actions/feature-and-rbac
a73fff5 
* actions/feature: (46 commits)
  [Composable template] Details panel + delete functionality (elastic#70814)
  [Uptime] Ping list body scroll (elastic#70781)
  moving indexPattern.delete() to indexPatterns.delete(indexPattern) (elastic#70430)
  Adapt expected response of advanced settings feature control for cloud tests (elastic#70793)
  skip flaky suite (elastic#70885)
  skip flaky suite (elastic#67814)
  skip flaky suite (elastic#70906)
  Revert "reenable regression and classification functional tests (elastic#70661)" (elastic#70908)
  Added UI validation when creating a Webhook connector with invalid URL (elastic#70025)
  [Security Solution] Change default index pattern (elastic#70797)
  ServiceNow push to Incident generic implementation (supporting both Case specific and generic Alerts) (elastic#68464)
  add button link to ingest (elastic#70142)
  reenable regression and classification functional tests (elastic#70661)
  [Component templates] Form wizard (elastic#69732)
  [Ingest Manager] Copy changes (elastic#70828)
  Adding test user to maps functional tests - PR 1 (elastic#70649)
  [Ingest Manager] Support limiting integrations on an agent config (elastic#70542)
  skip flaky suite (elastic#70880)
  [Metrics UI] Fix a bug in Metric Threshold query filter construction (elastic#70672)
  upgrade caniuse-lite database (elastic#70833)
  ...
bhavyarm added a commit that referenced this pull request Jul 7, 2020
@bhavyarm
Adding test user to maps functional tests - PR 1 (#70649) (#70887)
9d96334 
adding test user maps functional tests - PR1
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LeeDr LeeDr LeeDr approved these changes

@rashmivkulkarni rashmivkulkarni rashmivkulkarni approved these changes

@thomasneirynck thomasneirynck thomasneirynck approved these changes

Assignees
No one assigned
Labels
release_note:skip Skip the PR/issue when compiling release notes test_xpack_functional v8.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@bhavyarm @mistic @kibanamachine @rashmivkulkarni @thomasneirynck @LeeDr @elasticmachine