add button link to ingest #70142

parkiino · 2020-06-27T00:34:55Z

Summary

Adds a button to the security solution (no data) splash page
Button is shown only if Ingest is enabled
Clicking the button navigates user to ingest page filtered by security
Adds endpoint metadata index to the indices checked for data
Updates Network, Alerts / Detection and Hosts empty page to use the new Overview Empty page component

In a future PR, need to

add events and alerts index to security solution default indices: https://github.com/elastic/endpoint-app-team/issues/527
maybe adjust UI wording and button placement

https://github.com/elastic/endpoint-app-team/issues/453

BEFORE

AFTER

Checklist

Delete any items that are not applicable to this PR.

Any text added follows EUI's writing guidelines, uses sentence case text and includes i18n support
Documentation was added for features that require explanation or tutorials
Unit or functional tests were updated or added to match the most common scenarios
This was checked for keyboard-only and screenreader accessibility
This renders correctly on smaller devices using a responsive layout. (You can test this in your browser
This was checked for cross-browser compatibility, including a check against IE11

For maintainers

This was checked for breaking API changes and was labeled appropriately

…plash

elasticmachine · 2020-07-01T23:36:21Z

Pinging @elastic/ingest-management (Team:Ingest Management)

elasticmachine · 2020-07-01T23:36:58Z

Pinging @elastic/endpoint-app-team (Feature:Endpoint)

elasticmachine · 2020-07-01T23:36:59Z

Pinging @elastic/endpoint-management (Team:Endpoint Management)

parkiino · 2020-07-02T00:07:15Z

@caitlinbetz @bfishel @kevinlog are we going to change the text to this? It seems a little less informative than the current info, but just wanted to make sure.

kevinlog · 2020-07-02T01:04:36Z

x-pack/plugins/security_solution/server/lib/source_status/elasticsearch_adapter.ts

@@ -8,6 +8,7 @@ import { FrameworkAdapter, FrameworkRequest } from '../framework';
 import { SourceStatusAdapter } from './index';
 import { buildQuery } from './query.dsl';
 import { ApmServiceNameAgg } from './types';
+import { ENDPOINT_METADATA_INDEX } from '../../../common/constants';


this should work, but we'll also wanna make sure that the endpoint events and alerts index are added to the defaults. Can be in another PR

kevinlog · 2020-07-02T01:12:12Z

x-pack/plugins/security_solution/public/common/hooks/endpoint/ingest_enabled.ts

+  const read = services.application.capabilities.ingestManager?.read ?? false;
+
+  // Check if all Ingest Manager permissions are enabled
+  if (show === false || write === false || read === false) {


nit - could just return show === true && write === true && read === true

Alternatively, to make this more versatile in the future, you could return each of show, write, and read in an object together and the dev could decide what to do with them.

kevinlog · 2020-07-02T01:31:22Z

x-pack/plugins/security_solution/public/common/translations.ts

+export const EMPTY_ACTION_ENDPOINT = i18n.translate(
+  'xpack.securitySolution.pages.common.emptyActionEndpoint',
+  {
+    defaultMessage: 'Add data with Elastic Agent',


We should probably note that this is Beta

Add data with Elastic Agent (Beta) ?

@caitlinbetz @bfishel

EDIT: also, maybe it shouldn't be the first button listed?

kevinlog · 2020-07-02T01:34:56Z

@parkiino I had a couple comments, the only one I think we should resolve before merging is the Button text and placement

I pulled it down and it looks and works great!

…plash

hbharding · 2020-07-02T17:16:30Z

Hi @parkiino thanks! I just had one nit about the buttons I saw in the GIF. Per EUI guidelines for buttons, there should only be "one primary button per layout". I'd suggest changing the buttons to something like:

If we want to "recommend" a specific action, like going through Ingest Manager, the first option could work. If we want to treat all actions equally, i'd recommend the 2nd option.

…plash

hbharding · 2020-07-02T17:39:27Z

After a quick discussion, something like this may make the most sense. I changed some of the copy, but I'll leave that to your team to decide what it should say.

jfsiii

👍 for the Ingest changes. I left comments/suggestions but the changes in Ingest are small enough it should be easy enough to back out or update if we need to.

jfsiii · 2020-07-02T17:53:26Z

...lugins/ingest_manager/public/applications/ingest_manager/sections/epm/screens/home/index.tsx

+  const initialCategory =
+    queryParams.get('category') !== null ? (queryParams.get('category') as string) : '';


Is null significant? If possible, I'd prefer

Suggested change

const initialCategory =

queryParams.get('category') !== null ? (queryParams.get('category') as string) : '';

const initialCategory = queryParams.get('category') || '';

I find it more straightforward and we don't lose any safety, afaict.

jfsiii · 2020-07-02T17:54:35Z

...lugins/ingest_manager/public/applications/ingest_manager/sections/epm/screens/home/index.tsx

+        // clear category query param in the url
+        if (queryParams.get('category') !== null) {
+          history.push({});
+        }


@parkiino is null significant here? Can we rely on "truthy"?

Suggested change

// clear category query param in the url

if (queryParams.get('category') !== null) {

history.push({});

}

if (queryParams.get('category')) {

cc @jen-huang and @neptunian for thoughts on dealing with the params/state

…plash

kevinlog · 2020-07-06T19:41:25Z

@elasticmachine merge upstream

update security solution empty page

kibanamachine · 2020-07-07T00:42:23Z

💔 Build Failed

continuous-integration/kibana-ci/pull-request
Commit: 7609a82
Pipeline Steps (look for red circles / failed steps)
Interpreting CI Failures

Failed CI Steps

Test Failures

Kibana Pipeline / kibana-xpack-agent / re-orders columns via drag and drop.Events Viewer Events columns re-orders columns via drag and drop

Link to Jenkins

Standard Out

Failed Tests Reporter:
  - Test has failed 1 times on tracked branches: https://github.com/elastic/kibana/issues/70757

Stack Trace

AssertionError: Timed out retrying: expected '@timestampmessagehost.nameevent.moduleevent.datasetevent.actionuser.namesource.ipdestination.ip' to equal 'message@timestamphost.nameevent.moduleevent.datasetevent.actionuser.namesource.ipdestination.ip'
    at applyChainer (http://elastic:changeme@localhost:61131/__cypress/runner/cypress_runner.js:131898:32)
    at http://elastic:changeme@localhost:61131/__cypress/runner/cypress_runner.js:131940:16
    at arrayReduce (http://elastic:changeme@localhost:61131/__cypress/runner/cypress_runner.js:18578:21)
    at Function.reduce (http://elastic:changeme@localhost:61131/__cypress/runner/cypress_runner.js:27576:14)
    at applyChainers (http://elastic:changeme@localhost:61131/__cypress/runner/cypress_runner.js:131929:22)
    at tryCatcher (http://elastic:changeme@localhost:61131/__cypress/runner/cypress_runner.js:9065:23)
    at Function.Promise.attempt.Promise.try (http://elastic:changeme@localhost:61131/__cypress/runner/cypress_runner.js:6339:29)
    at Context.shouldFn (http://elastic:changeme@localhost:61131/__cypress/runner/cypress_runner.js:131946:26)
    at Context.should (http://elastic:changeme@localhost:61131/__cypress/runner/cypress_runner.js:131964:23)
    at http://elastic:changeme@localhost:61131/__cypress/runner/cypress_runner.js:127819:39
    at assertions (http://elastic:changeme@localhost:61131/__cypress/runner/cypress_runner.js:128079:14)
    at tryCatcher (http://elastic:changeme@localhost:61131/__cypress/runner/cypress_runner.js:9065:23)
    at Object.gotValue (http://elastic:changeme@localhost:61131/__cypress/runner/cypress_runner.js:8209:18)
    at Object.gotAccum (http://elastic:changeme@localhost:61131/__cypress/runner/cypress_runner.js:8196:25)
    at Object.tryCatcher (http://elastic:changeme@localhost:61131/__cypress/runner/cypress_runner.js:9065:23)
    at Promise._settlePromiseFromHandler (http://elastic:changeme@localhost:61131/__cypress/runner/cypress_runner.js:7000:31)

Kibana Pipeline / kibana-xpack-agent / Chrome X-Pack UI Functional Tests.x-pack/test/functional/apps/dashboard/_async_dashboard·ts.dashboard sample data dashboard "before all" hook for "should launch sample flights data set dashboard"

Link to Jenkins

Standard Out

Failed Tests Reporter:
  - Test has failed 2 times on tracked branches: https://github.com/elastic/kibana/issues/70715

[00:00:00]       │
[00:00:00]         └-: dashboard
[00:00:00]           └-> "before all" hook
[00:09:40]           └-: sample data dashboard
[00:09:40]             └-> "before all" hook
[00:09:40]             └-> "before all" hook
[00:09:40]               │ debg ... sleep(5000) start
[00:09:45]               │ debg ... sleep(5000) end
[00:09:45]               │ debg navigateToActualUrl http://localhost:6181/app/home#/tutorial_directory/sampleData
[00:09:45]               │ debg browser[INFO] http://localhost:6181/app/home?_t=1594078944173#/tutorial_directory/sampleData 341 Refused to execute inline script because it violates the following Content Security Policy directive: "script-src 'unsafe-eval' 'self'". Either the 'unsafe-inline' keyword, a hash ('sha256-P5polb1UreUSOe5V/Pv7tc+yeZuJXiOi/3fqhGsU7BE='), or a nonce ('nonce-...') is required to enable inline execution.
[00:09:45]               │
[00:09:45]               │ debg browser[INFO] http://localhost:6181/bundles/app/core/bootstrap.js 42:19 "^ A single error about an inline script not firing due to content security policy is expected!"
[00:09:45]               │ debg currentUrl = http://localhost:6181/app/home#/tutorial_directory/sampleData
[00:09:45]               │          appUrl = http://localhost:6181/app/home#/tutorial_directory/sampleData
[00:09:45]               │ debg TestSubjects.find(kibanaChrome)
[00:09:45]               │ debg Find.findByCssSelector('[data-test-subj="kibanaChrome"]') with timeout=60000
[00:09:47]               │ debg isGlobalLoadingIndicatorVisible
[00:09:47]               │ debg TestSubjects.exists(globalLoadingIndicator)
[00:09:47]               │ debg Find.existsByDisplayedByCssSelector('[data-test-subj="globalLoadingIndicator"]') with timeout=1500
[00:09:47]               │ debg browser[INFO] http://localhost:6181/34380/bundles/kbn-ui-shared-deps/kbn-ui-shared-deps.js 452:106112 "INFO: 2020-07-06T23:42:25Z
[00:09:47]               │        Adding connection to http://localhost:6181/elasticsearch
[00:09:47]               │
[00:09:47]               │      "
[00:09:48]               │ debg TestSubjects.exists(globalLoadingIndicator-hidden)
[00:09:48]               │ debg Find.existsByCssSelector('[data-test-subj="globalLoadingIndicator-hidden"]') with timeout=100000
[00:09:48]               │ debg TestSubjects.exists(addSampleDataSetflights)
[00:09:48]               │ debg Find.existsByDisplayedByCssSelector('[data-test-subj="addSampleDataSetflights"]') with timeout=2500
[00:09:48]               │ debg TestSubjects.click(addSampleDataSetflights)
[00:09:48]               │ debg Find.clickByCssSelector('[data-test-subj="addSampleDataSetflights"]') with timeout=10000
[00:09:48]               │ debg Find.findByCssSelector('[data-test-subj="addSampleDataSetflights"]') with timeout=10000
[00:09:48]               │ debg TestSubjects.find(sampleDataSetCardflights)
[00:09:48]               │ debg Find.findByCssSelector('[data-test-subj="sampleDataSetCardflights"]') with timeout=10000
[00:09:49]               │ debg TestSubjects.exists(addSampleDataSetflights)
[00:09:49]               │ debg Find.existsByDisplayedByCssSelector('[data-test-subj="addSampleDataSetflights"]') with timeout=2500
[00:09:49]               │ info Taking screenshot "/dev/shm/workspace/kibana/x-pack/test/functional/screenshots/failure/dashboard sample data dashboard _before all_ hook.png"
[00:09:50]               │ info Current URL is: http://localhost:6181/app/home#/tutorial_directory/sampleData
[00:09:50]               │ info Saving page source to: /dev/shm/workspace/kibana/x-pack/test/functional/failure_debug/html/dashboard sample data dashboard _before all_ hook.html
[00:09:50]               └- ✖ fail: "dashboard sample data dashboard "before all" hook for "should launch sample flights data set dashboard""
[00:09:50]               │

Stack Trace

Error: expected false to equal true
    at Assertion.assert (/dev/shm/workspace/kibana/packages/kbn-expect/expect.js:100:11)
    at Assertion.be.Assertion.equal (/dev/shm/workspace/kibana/packages/kbn-expect/expect.js:227:8)
    at Assertion.be (/dev/shm/workspace/kibana/packages/kbn-expect/expect.js:69:22)
    at Context.before (test/functional/apps/dashboard/_async_dashboard.ts:39:30)
    at process._tickCallback (internal/process/next_tick.js:68:7)

Kibana Pipeline / kibana-xpack-agent / Chrome X-Pack UI Functional Tests.x-pack/test/functional/apps/dashboard/_async_dashboard·ts.dashboard sample data dashboard "after all" hook for "toggle from Discover to Dashboard attempt 2"

Link to Jenkins

Standard Out

Failed Tests Reporter:
  - Test has failed 15 times on tracked branches: https://github.com/elastic/kibana/issues/65949

[00:00:00]       │
[00:00:00]         └-: dashboard
[00:00:00]           └-> "before all" hook
[00:09:40]           └-: sample data dashboard
[00:09:40]             └-> "before all" hook
[00:09:40]             └-> "before all" hook
[00:09:40]               │ debg ... sleep(5000) start
[00:09:45]               │ debg ... sleep(5000) end
[00:09:45]               │ debg navigateToActualUrl http://localhost:6181/app/home#/tutorial_directory/sampleData
[00:09:45]               │ debg browser[INFO] http://localhost:6181/app/home?_t=1594078944173#/tutorial_directory/sampleData 341 Refused to execute inline script because it violates the following Content Security Policy directive: "script-src 'unsafe-eval' 'self'". Either the 'unsafe-inline' keyword, a hash ('sha256-P5polb1UreUSOe5V/Pv7tc+yeZuJXiOi/3fqhGsU7BE='), or a nonce ('nonce-...') is required to enable inline execution.
[00:09:45]               │
[00:09:45]               │ debg browser[INFO] http://localhost:6181/bundles/app/core/bootstrap.js 42:19 "^ A single error about an inline script not firing due to content security policy is expected!"
[00:09:45]               │ debg currentUrl = http://localhost:6181/app/home#/tutorial_directory/sampleData
[00:09:45]               │          appUrl = http://localhost:6181/app/home#/tutorial_directory/sampleData
[00:09:45]               │ debg TestSubjects.find(kibanaChrome)
[00:09:45]               │ debg Find.findByCssSelector('[data-test-subj="kibanaChrome"]') with timeout=60000
[00:09:47]               │ debg isGlobalLoadingIndicatorVisible
[00:09:47]               │ debg TestSubjects.exists(globalLoadingIndicator)
[00:09:47]               │ debg Find.existsByDisplayedByCssSelector('[data-test-subj="globalLoadingIndicator"]') with timeout=1500
[00:09:47]               │ debg browser[INFO] http://localhost:6181/34380/bundles/kbn-ui-shared-deps/kbn-ui-shared-deps.js 452:106112 "INFO: 2020-07-06T23:42:25Z
[00:09:47]               │        Adding connection to http://localhost:6181/elasticsearch
[00:09:47]               │
[00:09:47]               │      "
[00:09:48]               │ debg TestSubjects.exists(globalLoadingIndicator-hidden)
[00:09:48]               │ debg Find.existsByCssSelector('[data-test-subj="globalLoadingIndicator-hidden"]') with timeout=100000
[00:09:48]               │ debg TestSubjects.exists(addSampleDataSetflights)
[00:09:48]               │ debg Find.existsByDisplayedByCssSelector('[data-test-subj="addSampleDataSetflights"]') with timeout=2500
[00:09:48]               │ debg TestSubjects.click(addSampleDataSetflights)
[00:09:48]               │ debg Find.clickByCssSelector('[data-test-subj="addSampleDataSetflights"]') with timeout=10000
[00:09:48]               │ debg Find.findByCssSelector('[data-test-subj="addSampleDataSetflights"]') with timeout=10000
[00:09:48]               │ debg TestSubjects.find(sampleDataSetCardflights)
[00:09:48]               │ debg Find.findByCssSelector('[data-test-subj="sampleDataSetCardflights"]') with timeout=10000
[00:09:49]               │ debg TestSubjects.exists(addSampleDataSetflights)
[00:09:49]               │ debg Find.existsByDisplayedByCssSelector('[data-test-subj="addSampleDataSetflights"]') with timeout=2500
[00:09:49]               │ info Taking screenshot "/dev/shm/workspace/kibana/x-pack/test/functional/screenshots/failure/dashboard sample data dashboard _before all_ hook.png"
[00:09:50]               │ info Current URL is: http://localhost:6181/app/home#/tutorial_directory/sampleData
[00:09:50]               │ info Saving page source to: /dev/shm/workspace/kibana/x-pack/test/functional/failure_debug/html/dashboard sample data dashboard _before all_ hook.html
[00:09:50]               └- ✖ fail: "dashboard sample data dashboard "before all" hook for "should launch sample flights data set dashboard""
[00:09:50]               │
[00:09:50]               └-> "after all" hook
[00:09:50]                 │ debg navigateToActualUrl http://localhost:6181/app/home#/tutorial_directory/sampleData
[00:09:50]                 │ debg browser[INFO] http://localhost:6181/app/home?_t=1594078948830#/tutorial_directory/sampleData 341 Refused to execute inline script because it violates the following Content Security Policy directive: "script-src 'unsafe-eval' 'self'". Either the 'unsafe-inline' keyword, a hash ('sha256-P5polb1UreUSOe5V/Pv7tc+yeZuJXiOi/3fqhGsU7BE='), or a nonce ('nonce-...') is required to enable inline execution.
[00:09:50]                 │
[00:09:50]                 │ debg browser[INFO] http://localhost:6181/bundles/app/core/bootstrap.js 42:19 "^ A single error about an inline script not firing due to content security policy is expected!"
[00:09:50]                 │ debg currentUrl = http://localhost:6181/app/home#/tutorial_directory/sampleData
[00:09:50]                 │          appUrl = http://localhost:6181/app/home#/tutorial_directory/sampleData
[00:09:50]                 │ debg TestSubjects.find(kibanaChrome)
[00:09:50]                 │ debg Find.findByCssSelector('[data-test-subj="kibanaChrome"]') with timeout=60000
[00:09:52]                 │ debg isGlobalLoadingIndicatorVisible
[00:09:52]                 │ debg TestSubjects.exists(globalLoadingIndicator)
[00:09:52]                 │ debg Find.existsByDisplayedByCssSelector('[data-test-subj="globalLoadingIndicator"]') with timeout=1500
[00:09:52]                 │ debg browser[INFO] http://localhost:6181/34380/bundles/kbn-ui-shared-deps/kbn-ui-shared-deps.js 452:106112 "INFO: 2020-07-06T23:42:30Z
[00:09:52]                 │        Adding connection to http://localhost:6181/elasticsearch
[00:09:52]                 │
[00:09:52]                 │      "
[00:09:52]                 │ debg TestSubjects.exists(globalLoadingIndicator-hidden)
[00:09:52]                 │ debg Find.existsByCssSelector('[data-test-subj="globalLoadingIndicator-hidden"]') with timeout=100000
[00:09:52]                 │ debg TestSubjects.find(removeSampleDataSetflights)
[00:09:52]                 │ debg Find.findByCssSelector('[data-test-subj="removeSampleDataSetflights"]') with timeout=10000
[00:10:02]                 │ debg --- retry.tryForTime error: Waiting for element to be located By(css selector, [data-test-subj="removeSampleDataSetflights"])
[00:10:02]                 │      Wait timed out after 10015ms
[00:10:03]                 │ debg TestSubjects.find(removeSampleDataSetflights)
[00:10:03]                 │ debg Find.findByCssSelector('[data-test-subj="removeSampleDataSetflights"]') with timeout=10000
[00:10:13]                 │ debg --- retry.tryForTime error: Waiting for element to be located By(css selector, [data-test-subj="removeSampleDataSetflights"])
[00:10:13]                 │      Wait timed out after 10014ms
[00:10:13]                 │ debg TestSubjects.find(removeSampleDataSetflights)
[00:10:13]                 │ debg Find.findByCssSelector('[data-test-subj="removeSampleDataSetflights"]') with timeout=10000
[00:10:23]                 │ debg --- retry.tryForTime error: Waiting for element to be located By(css selector, [data-test-subj="removeSampleDataSetflights"])
[00:10:23]                 │      Wait timed out after 10048ms
[00:10:24]                 │ debg TestSubjects.find(removeSampleDataSetflights)
[00:10:24]                 │ debg Find.findByCssSelector('[data-test-subj="removeSampleDataSetflights"]') with timeout=10000
[00:10:34]                 │ debg --- retry.tryForTime error: Waiting for element to be located By(css selector, [data-test-subj="removeSampleDataSetflights"])
[00:10:34]                 │      Wait timed out after 10054ms
[00:10:34]                 │ debg TestSubjects.find(removeSampleDataSetflights)
[00:10:34]                 │ debg Find.findByCssSelector('[data-test-subj="removeSampleDataSetflights"]') with timeout=10000
[00:10:44]                 │ debg --- retry.tryForTime error: Waiting for element to be located By(css selector, [data-test-subj="removeSampleDataSetflights"])
[00:10:44]                 │      Wait timed out after 10028ms
[00:10:45]                 │ debg TestSubjects.find(removeSampleDataSetflights)
[00:10:45]                 │ debg Find.findByCssSelector('[data-test-subj="removeSampleDataSetflights"]') with timeout=10000
[00:10:55]                 │ debg --- retry.tryForTime error: Waiting for element to be located By(css selector, [data-test-subj="removeSampleDataSetflights"])
[00:10:55]                 │      Wait timed out after 10038ms
[00:10:55]                 │ debg TestSubjects.find(removeSampleDataSetflights)
[00:10:55]                 │ debg Find.findByCssSelector('[data-test-subj="removeSampleDataSetflights"]') with timeout=10000
[00:11:05]                 │ debg --- retry.tryForTime error: Waiting for element to be located By(css selector, [data-test-subj="removeSampleDataSetflights"])
[00:11:05]                 │      Wait timed out after 10005ms
[00:11:06]                 │ debg TestSubjects.find(removeSampleDataSetflights)
[00:11:06]                 │ debg Find.findByCssSelector('[data-test-subj="removeSampleDataSetflights"]') with timeout=10000
[00:11:16]                 │ debg --- retry.tryForTime error: Waiting for element to be located By(css selector, [data-test-subj="removeSampleDataSetflights"])
[00:11:16]                 │      Wait timed out after 10042ms
[00:11:16]                 │ debg TestSubjects.find(removeSampleDataSetflights)
[00:11:16]                 │ debg Find.findByCssSelector('[data-test-subj="removeSampleDataSetflights"]') with timeout=10000
[00:11:26]                 │ debg --- retry.tryForTime error: Waiting for element to be located By(css selector, [data-test-subj="removeSampleDataSetflights"])
[00:11:26]                 │      Wait timed out after 10052ms
[00:11:27]                 │ debg TestSubjects.find(removeSampleDataSetflights)
[00:11:27]                 │ debg Find.findByCssSelector('[data-test-subj="removeSampleDataSetflights"]') with timeout=10000
[00:11:37]                 │ debg --- retry.tryForTime error: Waiting for element to be located By(css selector, [data-test-subj="removeSampleDataSetflights"])
[00:11:37]                 │      Wait timed out after 10035ms
[00:11:37]                 │ debg TestSubjects.find(removeSampleDataSetflights)
[00:11:37]                 │ debg Find.findByCssSelector('[data-test-subj="removeSampleDataSetflights"]') with timeout=10000
[00:11:47]                 │ debg --- retry.tryForTime error: Waiting for element to be located By(css selector, [data-test-subj="removeSampleDataSetflights"])
[00:11:47]                 │      Wait timed out after 10014ms
[00:11:48]                 │ debg TestSubjects.find(removeSampleDataSetflights)
[00:11:48]                 │ debg Find.findByCssSelector('[data-test-subj="removeSampleDataSetflights"]') with timeout=10000
[00:11:58]                 │ debg --- retry.tryForTime error: Waiting for element to be located By(css selector, [data-test-subj="removeSampleDataSetflights"])
[00:11:58]                 │      Wait timed out after 10057ms
[00:11:59]                 │ info Taking screenshot "/dev/shm/workspace/kibana/x-pack/test/functional/screenshots/failure/dashboard sample data dashboard _after all_ hook.png"
[00:11:59]                 │ info Current URL is: http://localhost:6181/app/home#/tutorial_directory/sampleData
[00:11:59]                 │ info Saving page source to: /dev/shm/workspace/kibana/x-pack/test/functional/failure_debug/html/dashboard sample data dashboard _after all_ hook.html
[00:11:59]                 └- ✖ fail: "dashboard sample data dashboard "after all" hook for "toggle from Discover to Dashboard attempt 2""
[00:11:59]                 │

Stack Trace

Error: retry.tryForTime timeout: TimeoutError: Waiting for element to be located By(css selector, [data-test-subj="removeSampleDataSetflights"])
Wait timed out after 10057ms
    at /dev/shm/workspace/kibana/node_modules/selenium-webdriver/lib/webdriver.js:842:17
    at process._tickCallback (internal/process/next_tick.js:68:7)
    at onFailure (/dev/shm/workspace/kibana/test/common/services/retry/retry_for_success.ts:28:9)
    at retryForSuccess (/dev/shm/workspace/kibana/test/common/services/retry/retry_for_success.ts:68:13)

Build metrics

@kbn/optimizer bundle module count

id	value	diff	baseline
securitySolution	790	-1	791

History

💚 Build #59133 succeeded 7609a82
💔 Build #58988 failed 50307f8
💔 Build #58799 failed a30978c
💔 Build #58541 failed e119a76
💔 Build #58515 failed 295225e

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

* master: (53 commits) [Composable template] Details panel + delete functionality (elastic#70814) [Uptime] Ping list body scroll (elastic#70781) moving indexPattern.delete() to indexPatterns.delete(indexPattern) (elastic#70430) Adapt expected response of advanced settings feature control for cloud tests (elastic#70793) skip flaky suite (elastic#70885) skip flaky suite (elastic#67814) skip flaky suite (elastic#70906) Revert "reenable regression and classification functional tests (elastic#70661)" (elastic#70908) Added UI validation when creating a Webhook connector with invalid URL (elastic#70025) [Security Solution] Change default index pattern (elastic#70797) ServiceNow push to Incident generic implementation (supporting both Case specific and generic Alerts) (elastic#68464) add button link to ingest (elastic#70142) reenable regression and classification functional tests (elastic#70661) [Component templates] Form wizard (elastic#69732) [Ingest Manager] Copy changes (elastic#70828) Adding test user to maps functional tests - PR 1 (elastic#70649) [Ingest Manager] Support limiting integrations on an agent config (elastic#70542) skip flaky suite (elastic#70880) [Metrics UI] Fix a bug in Metric Threshold query filter construction (elastic#70672) upgrade caniuse-lite database (elastic#70833) ...

* master: (46 commits) [Composable template] Details panel + delete functionality (elastic#70814) [Uptime] Ping list body scroll (elastic#70781) moving indexPattern.delete() to indexPatterns.delete(indexPattern) (elastic#70430) Adapt expected response of advanced settings feature control for cloud tests (elastic#70793) skip flaky suite (elastic#70885) skip flaky suite (elastic#67814) skip flaky suite (elastic#70906) Revert "reenable regression and classification functional tests (elastic#70661)" (elastic#70908) Added UI validation when creating a Webhook connector with invalid URL (elastic#70025) [Security Solution] Change default index pattern (elastic#70797) ServiceNow push to Incident generic implementation (supporting both Case specific and generic Alerts) (elastic#68464) add button link to ingest (elastic#70142) reenable regression and classification functional tests (elastic#70661) [Component templates] Form wizard (elastic#69732) [Ingest Manager] Copy changes (elastic#70828) Adding test user to maps functional tests - PR 1 (elastic#70649) [Ingest Manager] Support limiting integrations on an agent config (elastic#70542) skip flaky suite (elastic#70880) [Metrics UI] Fix a bug in Metric Threshold query filter construction (elastic#70672) upgrade caniuse-lite database (elastic#70833) ...

* actions/feature: (46 commits) [Composable template] Details panel + delete functionality (elastic#70814) [Uptime] Ping list body scroll (elastic#70781) moving indexPattern.delete() to indexPatterns.delete(indexPattern) (elastic#70430) Adapt expected response of advanced settings feature control for cloud tests (elastic#70793) skip flaky suite (elastic#70885) skip flaky suite (elastic#67814) skip flaky suite (elastic#70906) Revert "reenable regression and classification functional tests (elastic#70661)" (elastic#70908) Added UI validation when creating a Webhook connector with invalid URL (elastic#70025) [Security Solution] Change default index pattern (elastic#70797) ServiceNow push to Incident generic implementation (supporting both Case specific and generic Alerts) (elastic#68464) add button link to ingest (elastic#70142) reenable regression and classification functional tests (elastic#70661) [Component templates] Form wizard (elastic#69732) [Ingest Manager] Copy changes (elastic#70828) Adding test user to maps functional tests - PR 1 (elastic#70649) [Ingest Manager] Support limiting integrations on an agent config (elastic#70542) skip flaky suite (elastic#70880) [Metrics UI] Fix a bug in Metric Threshold query filter construction (elastic#70672) upgrade caniuse-lite database (elastic#70833) ...

update security solution empty page (#70142) Co-authored-by: Elastic Machine <[email protected]>

parkiino added 3 commits June 30, 2020 10:39

add button link to ingest

ddc3f39

link does not do full refresh

1c078cf

use queryparam initially, navigate to correct url

604316a

parkiino force-pushed the task/onboarding-splash branch from 320a875 to 604316a Compare June 30, 2020 22:07

parkiino added 6 commits July 1, 2020 12:00

hook to check ingest enabled

460c5f8

Merge remote-tracking branch 'upstream/master' into task/onboarding-s…

36b934f

…plash

Merge remote-tracking branch 'upstream/master' into task/onboarding-s…

71c9aac

…plash

tests

2113b99

checks if metadata index is present

415ae91

modify ingest url hook naming

ac75c49

parkiino marked this pull request as ready for review July 1, 2020 23:36

parkiino requested a review from a team as a code owner July 1, 2020 23:36

parkiino requested a review from a team July 1, 2020 23:36

parkiino requested a review from a team as a code owner July 1, 2020 23:36

botelastic bot added the Team:Fleet Team label for Observability Data Collection Fleet team label Jul 1, 2020

parkiino added Feature:Endpoint Elastic Endpoint feature release_note:skip Skip the PR/issue when compiling release notes Team:Endpoint Management v7.9.0 v8.0.0 labels Jul 1, 2020

kevinlog reviewed Jul 2, 2020

View reviewed changes

parkiino added 2 commits July 2, 2020 11:45

modify hook to be more robust

55261bc

Merge remote-tracking branch 'upstream/master' into task/onboarding-s…

504f82b

…plash

add beta to button

b79f6d7

kevinlog approved these changes Jul 2, 2020

View reviewed changes

Merge remote-tracking branch 'upstream/master' into task/onboarding-s…

1844e6b

…plash

jfsiii approved these changes Jul 2, 2020

View reviewed changes

parkiino added 9 commits July 2, 2020 15:36

remove tertiary action, make secondary action

7c932c6

comments

a65f1a5

make network, hosts, alerts/detection use overview empty

a443859

Merge remote-tracking branch 'upstream/master' into task/onboarding-s…

295225e

…plash

type check

e119a76

fix tests

613f90e

Merge remote-tracking branch 'upstream/master' into task/onboarding-s…

e655571

…plash

i18n

a30978c

text changes

50307f8

Merge branch 'master' into task/onboarding-splash

7609a82

parkiino merged commit 5992424 into elastic:master Jul 6, 2020

parkiino deleted the task/onboarding-splash branch July 6, 2020 22:52

parkiino mentioned this pull request Jul 6, 2020

[7.x] add button link to ingest (#70142) #70896

Merged

parkiino added a commit to parkiino/kibana that referenced this pull request Jul 6, 2020

add button link to ingest (elastic#70142)

1ef631b

update security solution empty page

parkiino added a commit that referenced this pull request Jul 7, 2020

[7.x] add button link to ingest (#70142) (#70896)

4bba510

update security solution empty page (#70142) Co-authored-by: Elastic Machine <[email protected]>

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

add button link to ingest #70142

add button link to ingest #70142

parkiino commented Jun 27, 2020 •

edited

Loading

elasticmachine commented Jul 1, 2020

elasticmachine commented Jul 1, 2020

elasticmachine commented Jul 1, 2020

parkiino commented Jul 2, 2020

kevinlog Jul 2, 2020

kevinlog Jul 2, 2020

kevinlog Jul 2, 2020 •

edited

Loading

kevinlog commented Jul 2, 2020

hbharding commented Jul 2, 2020

hbharding commented Jul 2, 2020

jfsiii left a comment

jfsiii Jul 2, 2020

jfsiii Jul 2, 2020

kevinlog commented Jul 6, 2020

kibanamachine commented Jul 7, 2020

Standard Out

Stack Trace

Standard Out

Stack Trace

Standard Out

Stack Trace

		const initialCategory =
		queryParams.get('category') !== null ? (queryParams.get('category') as string) : '';

	const initialCategory =
	queryParams.get('category') !== null ? (queryParams.get('category') as string) : '';
	const initialCategory = queryParams.get('category') \|\| '';

add button link to ingest #70142

add button link to ingest #70142

Conversation

parkiino commented Jun 27, 2020 • edited Loading

Summary

Checklist

For maintainers

elasticmachine commented Jul 1, 2020

elasticmachine commented Jul 1, 2020

elasticmachine commented Jul 1, 2020

parkiino commented Jul 2, 2020

kevinlog Jul 2, 2020

Choose a reason for hiding this comment

kevinlog Jul 2, 2020

Choose a reason for hiding this comment

kevinlog Jul 2, 2020 • edited Loading

Choose a reason for hiding this comment

kevinlog commented Jul 2, 2020

hbharding commented Jul 2, 2020

hbharding commented Jul 2, 2020

jfsiii left a comment

Choose a reason for hiding this comment

jfsiii Jul 2, 2020

Choose a reason for hiding this comment

jfsiii Jul 2, 2020

Choose a reason for hiding this comment

kevinlog commented Jul 6, 2020

kibanamachine commented Jul 7, 2020

💔 Build Failed

Failed CI Steps

Test Failures

Standard Out

Stack Trace

Standard Out

Stack Trace

Standard Out

Stack Trace

Build metrics

@kbn/optimizer bundle module count

History

parkiino commented Jun 27, 2020 •

edited

Loading

kevinlog Jul 2, 2020 •

edited

Loading