[ML] DF Analytics: add ability to edit job for fields supported by API #70489
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alvarezmelissa87
added
:ml
Feature:Data Frame Analytics
|
Pinging @elastic/ml-ui (:ml) |
qn895
reviewed
Jul 2, 2020
...ame_analytics/pages/analytics_management/components/analytics_list/edit_analytics_flyout.tsx
Outdated
Show resolved
Hide resolved
...ame_analytics/pages/analytics_management/components/analytics_list/edit_analytics_flyout.tsx
Show resolved
Hide resolved
...ame_analytics/pages/analytics_management/components/analytics_list/edit_analytics_flyout.tsx
Outdated
Show resolved
Hide resolved
x-pack/plugins/ml/public/application/services/ml_api_service/data_frame_analytics.ts
Outdated
Show resolved
Hide resolved
...ame_analytics/pages/analytics_management/components/analytics_list/edit_analytics_flyout.tsx
Outdated
Show resolved
Hide resolved
...ame_analytics/pages/analytics_management/components/analytics_list/edit_analytics_flyout.tsx
Show resolved
Hide resolved
alvarezmelissa87
force-pushed
the
ml-dfanalytics-edit-job
branch
from
d178c4c to
81907a1
Compare
alvarezmelissa87
force-pushed
the
ml-dfanalytics-edit-job
branch
from
1086c4f to
9ac1b43
Compare
peteharverson
approved these changes
Jul 6, 2020
💚 Build SucceededBuild metrics
History
To update your PR or re-run it, just comment with: |
qn895
approved these changes
Jul 6, 2020
|
LGTM 👍 |
alvarezmelissa87
added a commit
to alvarezmelissa87/kibana
that referenced
this pull request
Jul 6, 2020
elastic#70489) * wip: add edit action to dfanalytics table * add update endpoint and edit flyout * show success and error toasts. close flyout and refresh on success * show permission message in edit action * update types * disable update button if mml not valid * show error in toast, init values are config values * fix undefined check for allow lazy start * prevent update if mml is empty
alvarezmelissa87
added a commit
that referenced
this pull request
Jul 6, 2020
#70489) (#70863) * wip: add edit action to dfanalytics table * add update endpoint and edit flyout * show success and error toasts. close flyout and refresh on success * show permission message in edit action * update types * disable update button if mml not valid * show error in toast, init values are config values * fix undefined check for allow lazy start * prevent update if mml is empty
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Related meta issue: #70354
Adds
Editaction to analytics list:Able to edit
description,allow_lazy_start, andmodel_memory_limit(mml only if job is stopped). Initial values default to what the current values are in the config.Validate mml:
Disable update if mml empty or invalid:
Checklist
Delete any items that are not applicable to this PR.