[Ingest Manager] Fix agent ack after input format change #70335
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nchaulet
added
bug
|
Pinging @elastic/ingest-management (Team:Ingest Management) |
nchaulet
added
the
release_note:skip
| return [input.package.name, ...acc]; | ||
| const packageName = input.meta?.package?.name; | ||
| if (packageName && acc.indexOf(packageName) < 0) { | ||
| return [packageName, ...acc]; |
There was a problem hiding this comment.
Do we need to handle cases where packages are removed?
There was a problem hiding this comment.
I rebuild this array each time from the full config, it should work for package removed too.
There was a problem hiding this comment.
May want to add a test case for this if possible
nnamdifrankie
approved these changes
Jun 30, 2020
jen-huang
approved these changes
Jun 30, 2020
💚 Build SucceededBuild metrics
History
To update your PR or re-run it, just comment with: |
Bamieh
pushed a commit
to Bamieh/kibana
that referenced
this pull request
Jul 1, 2020
gmmorris
added a commit
to gmmorris/kibana
that referenced
this pull request
Jul 1, 2020
…-based-rbac * upstream/master: (38 commits) Move logger configuration integration test to jest (elastic#70378) Changes observability plugin codeowner (elastic#70439) update (elastic#70424) [Logs UI] Avoid CCS-incompatible index name resolution (elastic#70179) Enable "Explore underlying data" actions for Lens visualizations (elastic#70047) Initial work on uptime homepage API (elastic#70135) expressions indexPattern function (elastic#70315) [Discover] Deangularization context error message refactoring (elastic#70090) [Lens] Add "no data" popover (elastic#69147) [Lens] Move chart switcher over (elastic#70182) chore: add missing mjs extension (elastic#70326) [Lens] Multiple y axes (elastic#69911) skip flaky suite (elastic#70386) fix bug to add timeline to case (elastic#70343) [QA][Code Coverage] Drop catchError and use try / catch instead, (elastic#69198) [QA] [Code Coverage] Integrate with Team Assignment Pipeline and Add Research and Development Indexes and Cluster (elastic#69348) [Metrics UI] Add context.reason and alertOnNoData to Inventory alerts (elastic#70260) Resolver refactoring (elastic#70312) [Ingest Manager] Fix agent ack after input format change (elastic#70335) [eslint][ts] Enable prefer-ts-expect-error (elastic#70022) ...
jen-huang
pushed a commit
to jen-huang/kibana
that referenced
this pull request
Jul 1, 2020
|
Kicking off a backport for this to avoid potential conflicts with other incoming backports. |
jen-huang
added a commit
that referenced
this pull request
Jul 2, 2020
…0523) Co-authored-by: Nicolas Chaulet <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR #69864 change the agent config input structure to move the package info under the
metakey. We used that information to set the packages that an agent are using.Fix that, and add a functional test to be sure
agent.packagesis properly populated