Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Lens] Move chart switcher over #70182

Merged
merged 5 commits into from
Jul 1, 2020

Conversation

flash1293
Copy link
Contributor

Fixes #69415

This PR moves the chart switcher into the toolbar

Screenshot 2020-06-29 at 11 11 39

Screenshot 2020-06-29 at 11 23 23

@flash1293 flash1293 marked this pull request as ready for review June 29, 2020 15:17
@flash1293 flash1293 requested a review from a team June 29, 2020 15:17
@flash1293 flash1293 requested a review from a team as a code owner June 29, 2020 15:17
@flash1293 flash1293 added the Team:Visualizations Visualization editors, elastic-charts and infrastructure label Jun 29, 2020
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-app (Team:KibanaApp)

@flash1293 flash1293 added the release_note:skip Skip the PR/issue when compiling release notes label Jun 29, 2020
@flash1293
Copy link
Contributor Author

@cchaos Could you check the styling of the button? Not 100% sure about it.

@cchaos
Copy link
Contributor

cchaos commented Jun 29, 2020

Thanks @flash1293 ! That's actually quite close and good enough for me in this PR as I'll do a follow-up when this one and the other settings one get merged.

@flash1293
Copy link
Contributor Author

@cchaos can you approve in that case?

Copy link
Contributor

@cchaos cchaos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Screenshots and code LGTM. I'll do a follow up if necessary.

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Build metrics

@kbn/optimizer bundle module count

id value diff baseline
lens 88 +5 83

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

Copy link
Contributor

@wylieconlon wylieconlon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@flash1293 flash1293 merged commit a49f5ce into elastic:master Jul 1, 2020
@flash1293 flash1293 deleted the lens/move-chartswitcher branch July 1, 2020 08:08
flash1293 added a commit to flash1293/kibana that referenced this pull request Jul 1, 2020
Bamieh pushed a commit to Bamieh/kibana that referenced this pull request Jul 1, 2020
gmmorris added a commit to gmmorris/kibana that referenced this pull request Jul 1, 2020
…-based-rbac

* upstream/master: (38 commits)
  Move logger configuration integration test to jest (elastic#70378)
  Changes observability plugin codeowner (elastic#70439)
  update (elastic#70424)
  [Logs UI] Avoid CCS-incompatible index name resolution (elastic#70179)
  Enable "Explore underlying data" actions for Lens visualizations (elastic#70047)
  Initial work on uptime homepage API (elastic#70135)
  expressions indexPattern function (elastic#70315)
  [Discover] Deangularization context error message refactoring (elastic#70090)
  [Lens] Add "no data" popover (elastic#69147)
  [Lens] Move chart switcher over (elastic#70182)
  chore: add missing mjs extension (elastic#70326)
  [Lens] Multiple y axes (elastic#69911)
  skip flaky suite (elastic#70386)
  fix bug to add timeline to case (elastic#70343)
  [QA][Code Coverage] Drop catchError and use try / catch instead, (elastic#69198)
  [QA] [Code Coverage] Integrate with Team Assignment Pipeline and Add Research and Development Indexes and Cluster (elastic#69348)
  [Metrics UI] Add context.reason and alertOnNoData to Inventory alerts (elastic#70260)
  Resolver refactoring (elastic#70312)
  [Ingest Manager] Fix agent ack after input format change (elastic#70335)
  [eslint][ts] Enable prefer-ts-expect-error (elastic#70022)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature:Lens release_note:skip Skip the PR/issue when compiling release notes Team:Visualizations Visualization editors, elastic-charts and infrastructure v7.9.0 v8.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Move chart switch into toolbar area
5 participants