[APM] Add callout to inform users of high cardinality in unique transaction names #69112
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Pinging @elastic/apm-ui (Team:apm) |
10 tasks
|
retest |
1 similar comment
|
retest |
Showing a callout to inform the user we have detected a high cardinality in unique transaction names and enabling them how to fix it.
sorenlouv
force-pushed
the
apm-callout-unique-transaction-names
branch
from
3185602
to
2ea3755
Compare
|
@elasticmachine merge upstream |
| <EuiCode> | ||
| xpack.apm.ui.transactionGroupBucketSize | ||
| </EuiCode>.{' '} | ||
| <EuiLink href="#">Learn more in the docs.</EuiLink>. |
There was a problem hiding this comment.
I think we should add the docs link instead of #.
There was a problem hiding this comment.
I guess still waiting for #67691
| iconType="alert" | ||
| > | ||
| <p> | ||
| The number of unique transaction names exceeds the configured |
There was a problem hiding this comment.
Shouldn't we translate this text too?
cauemarcondes
approved these changes
Jun 16, 2020
bmorelli25
reviewed
Jun 24, 2020
x-pack/plugins/apm/public/components/app/TransactionOverview/index.tsx
Outdated
Show resolved
Hide resolved
Co-authored-by: Brandon Morelli <[email protected]>
|
@elasticmachine merge upstream |
💚 Build SucceededBuild metricspage load asset sizebeta
History
To update your PR or re-run it, just comment with: |
sorenlouv
added a commit
to sorenlouv/kibana
that referenced
this pull request
Jun 27, 2020
…action names (elastic#69112) * [APM] Add callout Showing a callout to inform the user we have detected a high cardinality in unique transaction names and enabling them how to fix it. * Changed color and icon * Updated copy and styling * Check number of returned buckets * Add translations and docs * Update docs link Co-authored-by: Brandon Morelli <[email protected]> * Fix tests Co-authored-by: Casper Hübertz <[email protected]> Co-authored-by: Elastic Machine <[email protected]> Co-authored-by: Brandon Morelli <[email protected]>
sorenlouv
added a commit
that referenced
this pull request
Jun 28, 2020
…action names (#69112) (#70153) * [APM] Add callout Showing a callout to inform the user we have detected a high cardinality in unique transaction names and enabling them how to fix it. * Changed color and icon * Updated copy and styling * Check number of returned buckets * Add translations and docs * Update docs link Co-authored-by: Brandon Morelli <[email protected]> * Fix tests Co-authored-by: Casper Hübertz <[email protected]> Co-authored-by: Elastic Machine <[email protected]> Co-authored-by: Brandon Morelli <[email protected]> Co-authored-by: Casper Hübertz <[email protected]> Co-authored-by: Elastic Machine <[email protected]> Co-authored-by: Brandon Morelli <[email protected]>
|
tests ok: |
cauemarcondes
added
the
apm:test-plan-done
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Blocked by #67691
Related to #67273. This involves only the design and copy of the callout. We'd need to set up the proper functionalities to display this only when we're detecting an explosion in transaction names, as described in the original issue.
We're looking to create an agent-agnostic documentation article that we can link to enable the user to fix their issues.
Tasks