-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[APM] Add callout to inform users of high cardinality in unique transaction names #67610
[APM] Add callout to inform users of high cardinality in unique transaction names #67610
Conversation
Showing a callout to inform the user we have detected a high cardinality in unique transaction names and enabling them how to fix it.
Pinging @elastic/apm-ui (Team:apm) |
Thanks for starting this @formgeist. Looks great. |
@nehaduggal mentioned in our meeting that this should using danger styles since it can be a big problem and hide many transactions. |
@smith @nehaduggal Updated to use the danger callout type instead. @bmorelli25 Maybe you have a minute to help me update the initial copy in the callout to fit with your documentation article? I wrote it just as a quick placeholder. TY! |
Love it! For the copy can we add explicitly that number of unique transaction names detected exceeds the configured setting so the user is only seeing subset of all the reported transactions. |
Thanks for the ping. Gail and I bounced some ideas off of each other. Here are a few options we came up with. Any feedback is welcome. This view shows a subset of reported transactions Too many unique transaction names In the docs we can then mention that the number of unique transaction names exceeds the value configured in |
We can access the configured limit so we could write something like: This view shows a subset of reported transactions I know we show the configuration name in the docs but I think it would be useful to also show it directly in the warning message: This view shows a subset of reported transactions |
Looks great. |
Great teamwork 👏 I've updated the copy and styling to match the suggested messaging. I suppose next step is for someone to make this real and read the configuration and change the link once the docs article is ready. |
💚 Build SucceededHistory
To update your PR or re-run it, just comment with: |
replaced by #69112 |
Summary
Related to #67273. This involves only the design and copy of the callout. We'd need to set up the proper functionalities to display this only when we're detecting an explosion in transaction names, as described in the original issue.
We're looking to create an agent-agnostic documentation article that we can link to enable the user to fix their issues.
Tasks
Checklist
Delete any items that are not applicable to this PR.
Documentation was added for features that require explanation or tutorialsUnit or functional tests were updated or added to match the most common scenariosThis was checked for keyboard-only and screenreader accessibilityThis renders correctly on smaller devices using a responsive layout. (You can test this in your browserThis was checked for cross-browser compatibility, including a check against IE11For maintainers
This was checked for breaking API changes and was labeled appropriately