Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Logs UI] View in context tweaks #67777

Merged
merged 8 commits into from
Jun 8, 2020
Merged

[Logs UI] View in context tweaks #67777

merged 8 commits into from
Jun 8, 2020

Conversation

afgomez
Copy link
Contributor

@afgomez afgomez commented May 29, 2020 •
edited
Loading

Summary

Closes #64910

Makes some visual tweaks to the view in context UI.

  • Bigger hit area for the log line actions button

Screenshot 2020-05-29 at 17 17 55

  • Adjusted paddings and spacings in the modal itself.

Screenshot 2020-05-29 at 17 18 10

  • Use of EuiContextMenu for the actions menu

@afgomez afgomez added v8.0.0 Feature:Logs UI Logs UI feature Team:Infra Monitoring UI - DEPRECATED DEPRECATED - Label for the Infra Monitoring UI team. Use Team:obs-ux-infra_services release_note:skip Skip the PR/issue when compiling release notes v7.9.0 labels May 29, 2020
@afgomez afgomez added this to the Logs UI 7.9 milestone May 29, 2020
@afgomez afgomez requested a review from a team as a code owner May 29, 2020 15:23
@elasticmachine
Copy link
Contributor

Pinging @elastic/logs-metrics-ui (Team:logs-metrics-ui)

@katrin-freihofner
Copy link
Contributor

🙌 thank you, this is great!

@Kerry350 Kerry350 self-requested a review June 5, 2020 10:07
Kerry350
Kerry350 approved these changes Jun 5, 2020
View reviewed changes
Copy link
Contributor

@Kerry350 Kerry350 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@afgomez
Copy link
Contributor Author

afgomez commented Jun 8, 2020

@elasticmachine merge upstream

katrin-freihofner
katrin-freihofner approved these changes Jun 8, 2020
View reviewed changes
Copy link
Contributor

@katrin-freihofner katrin-freihofner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

Restore ownFocus in the menu
c869294 
The shared observability component added the `ownFocus` property to the
popover menu. This added some accessibility text that we want to keep.
@kibanamachine
Copy link
Contributor

💚 Build Succeeded

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@afgomez afgomez merged commit e66eaf7 into elastic:master Jun 8, 2020
@afgomez afgomez deleted the 64910-view-in-context-tweaks branch June 8, 2020 13:49
@afgomez afgomez mentioned this pull request Jun 8, 2020
Merged
gmmorris added a commit to gmmorris/kibana that referenced this pull request Jun 8, 2020
@gmmorris
Merge branch 'master' into alerting/consumer-based-rbac
445710f 
* master:
  [ML] DFAnalytics results: ensure ml result fields are shown in data grid (elastic#68305)
  [security_solution] enable react-hooks/exhaustive-deps (elastic#68470)
  Closes elastic#66867 by adding missing, requried API params (elastic#68465)
  [Telemetry] collect number of visualization saved in the past 7, 30 and 90 days (elastic#67865)
  [Logs UI] View in context tweaks (elastic#67777)
  Kibana developer examples landing page (elastic#67049)
  Bump decompress package version (elastic#68386)
  fix elastic#66185 (elastic#66186)
  Bump pdfmake package version (elastic#68395)
  Unskip embeddables/adding_children suite (elastic#68111)
  Add embed mode options in the Share UI (elastic#58435)
  Adding key to avoid react warning (elastic#68491)
afgomez pushed a commit that referenced this pull request Jun 9, 2020
@elasticmachine
[7.x] [Logs UI] View in context tweaks (#67777) (#68516)
4f8d5a4 
Co-authored-by: Elastic Machine <[email protected]>

Co-authored-by: Elastic Machine <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Kerry350 Kerry350 Kerry350 approved these changes

@katrin-freihofner katrin-freihofner katrin-freihofner approved these changes

Assignees
No one assigned
Labels
Feature:Logs UI Logs UI feature release_note:skip Skip the PR/issue when compiling release notes Team:Infra Monitoring UI - DEPRECATED DEPRECATED - Label for the Infra Monitoring UI team. Use Team:obs-ux-infra_services v7.9.0 v8.0.0
Projects
None yet
Milestone
Logs UI 7.9
Development

Successfully merging this pull request may close these issues.

[Logs UI] view in context visual fine-tuning
5 participants
@afgomez @elasticmachine @katrin-freihofner @kibanamachine @Kerry350