Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Logs UI] view in context visual fine-tuning #64910

Closed
4 tasks
katrin-freihofner opened this issue Apr 30, 2020 · 3 comments · Fixed by #67777
Closed
4 tasks

[Logs UI] view in context visual fine-tuning #64910

katrin-freihofner opened this issue Apr 30, 2020 · 3 comments · Fixed by #67777
Assignees
Labels
Feature:Logs UI Logs UI feature Team:Infra Monitoring UI - DEPRECATED DEPRECATED - Label for the Infra Monitoring UI team. Use Team:obs-ux-infra_services
Milestone

Comments

@katrin-freihofner
Copy link
Contributor

katrin-freihofner commented Apr 30, 2020

I found some minor things, where we should fine-tune the UI of the new view in context feature. The screenshots here show what I think it could look like.

  • the button to trigger the menu is very small - let's increase its size to 32x32px

Screenshot 2020-04-30 at 11 10 29

  • the dropdown with the View details and View in context actions does not have the same styling as our other dropdowns, for example this one:

Screenshot 2020-04-30 at 11 10 44

...also the actions hover state looks different.
  • an increased padding at the top (for the screenshot I set all paddings to 16px)
  • a small EUI spacer after the file info ("Displayed logs are from file...")

Screenshot 2020-04-30 at 16 56 19

@katrin-freihofner katrin-freihofner added the Team:Infra Monitoring UI - DEPRECATED DEPRECATED - Label for the Infra Monitoring UI team. Use Team:obs-ux-infra_services label Apr 30, 2020
@elasticmachine
Copy link
Contributor

Pinging @elastic/logs-metrics-ui (Team:logs-metrics-ui)

@sgrodzicki sgrodzicki added the Feature:Logs UI Logs UI feature label May 5, 2020
@sgrodzicki sgrodzicki added this to the Logs UI 7.9 milestone May 25, 2020
@afgomez afgomez self-assigned this May 27, 2020
@afgomez
Copy link
Contributor

afgomez commented May 29, 2020

the dropdown with the View details and View in context actions does not have the same styling as our other dropdowns, for example this one:

For this I'm using a component shared in observability. It's used for example in the inventory view in the metrics app.

Screenshot 2020-05-29 at 12 05 33

I can either make the changes for that component, and change it everywhere, or I can use a different component in the logs UI.

I think the first option might be better, but maybe you prefer to keep the existing style in the metrics app.

@katrin-freihofner
Copy link
Contributor Author

I see. I think we should use the standard EuiContextMenu for the log lines. We use the shared observability component for cross-linking between apps, where we have different sections for the individual apps. Does this answer your question?

@zube zube bot added [zube]: Done and removed [zube]: Ready labels Jun 8, 2020
@zube zube bot removed the [zube]: Done label Oct 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature:Logs UI Logs UI feature Team:Infra Monitoring UI - DEPRECATED DEPRECATED - Label for the Infra Monitoring UI team. Use Team:obs-ux-infra_services
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants