[Logs UI] Restore call to UsageCollector.countLogs
#67051
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Before 0a1ffd9 there was a call to `UsageCollector` to track telemetry for the logs app. The call was done from the GraphQL resolver and was removed by mistake when cleaning up all GraphQL code. This commit restores the call at the route handler level.
afgomez
added
bug
|
Pinging @elastic/logs-metrics-ui (Team:logs-metrics-ui) |
💚 Build SucceededTo update your PR or re-run it, just comment with: |
jasonrhodes
approved these changes
May 19, 2020
| @@ -47,6 +48,8 @@ export const initLogEntriesSummaryRoute = ({ framework, logEntries }: InfraBacke | |||
| parseFilterQuery(query) | |||
| ); | |||
|
|
|||
| UsageCollector.countLogs(); | |||
There was a problem hiding this comment.
Should this be in its own try/catch so we don't bounce to an error message just because the usage collector fails?
There was a problem hiding this comment.
Good point, but if the data collection might fail I think it should be handled inside the telemetry call itself and not in the application code. I think telemetry should behave like a black box for app code
|
I tested this locally and it's working now, good work. I also logged #67063 to add tests for this and all of our Logs/Metrics telemetry. |
This was referenced May 20, 2020
afgomez
pushed a commit
to afgomez/kibana
that referenced
this pull request
May 20, 2020
afgomez
pushed a commit
to afgomez/kibana
that referenced
this pull request
May 20, 2020
afgomez
pushed a commit
that referenced
this pull request
May 20, 2020
afgomez
pushed a commit
that referenced
this pull request
May 20, 2020
afgomez
pushed a commit
that referenced
this pull request
May 20, 2020
jloleysens
added a commit
to jloleysens/kibana
that referenced
this pull request
May 20, 2020
…ent/add-support-in-url-for-hidden-toggle * 'master' of github.com:elastic/kibana: (49 commits) [Uptime] Improve responsiveness details page (elastic#67034) skip flaky suite (elastic#66669) Revert "Integration of a static filesystem for the node_modules (elastic#47998)" (elastic#67124) Support api_integration/kibana/stats against remote hosts (elastic#53000) chore(NA): add module name mapper for src plugins on x-pack (elastic#67103) Change the error message on TSVB in order to be more user friendly (elastic#67090) [kbn/optimizer] poll parent process to avoid zombie processes (elastic#67059) [Visualize] Lazy load default editor, fix duplicated styles (elastic#66732) Bump styled-component dependencies (elastic#66611) Bump react-markdown dependencies (elastic#66615) Fix Core docs links (elastic#66977) Timelion graph is not refreshing content after searching or filtering (elastic#67023) Remove `--xpack.endpoint.enabled=true` from README.md file (elastic#67053) Move apm tutorial from apm plugin into apm_oss plugin (elastic#66432) [Logs UI] Restore call to `UsageCollector.countLogs` (elastic#67051) Remove unused license check result from LP Security plugin (elastic#66966) [Saved Objects] adds support for including hidden types in saved objects client (elastic#66879) [Discover] Deangularize timechart header (elastic#66532) [Discover] Improve and unskip a11y context view test (elastic#66959) [SIEM] Refactor Timeline.timelineType draft to Timeline.status draft (elastic#66864) ... # Conflicts: # x-pack/plugins/index_management/__jest__/client_integration/helpers/home.helpers.ts
gmmorris
added a commit
to gmmorris/kibana
that referenced
this pull request
May 21, 2020
* master: [apm] Annotation API documentation (elastic#65963) [Uptime] Improve responsiveness details page (elastic#67034) skip flaky suite (elastic#66669) Revert "Integration of a static filesystem for the node_modules (elastic#47998)" (elastic#67124) Support api_integration/kibana/stats against remote hosts (elastic#53000) chore(NA): add module name mapper for src plugins on x-pack (elastic#67103) Change the error message on TSVB in order to be more user friendly (elastic#67090) [kbn/optimizer] poll parent process to avoid zombie processes (elastic#67059) [Visualize] Lazy load default editor, fix duplicated styles (elastic#66732) Bump styled-component dependencies (elastic#66611) Bump react-markdown dependencies (elastic#66615) Fix Core docs links (elastic#66977) Timelion graph is not refreshing content after searching or filtering (elastic#67023) Remove `--xpack.endpoint.enabled=true` from README.md file (elastic#67053) Move apm tutorial from apm plugin into apm_oss plugin (elastic#66432) [Logs UI] Restore call to `UsageCollector.countLogs` (elastic#67051) Remove unused license check result from LP Security plugin (elastic#66966)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before 0a1ffd9 there was a call to
UsageCollectorto track telemetry for the logs app. The call was donefrom the GraphQL resolver and was removed by mistake when cleaning up
all GraphQL code.
This commit restores the call at the route handler level.