Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support api_integration/kibana/stats against remote hosts #53000

Merged
merged 25 commits into from
May 20, 2020
Merged

Support api_integration/kibana/stats against remote hosts #53000

merged 25 commits into from
May 20, 2020

Conversation

jbudz
Copy link
Member

@jbudz jbudz commented Dec 13, 2019 •
edited
Loading

The stats API integration tests run under the assumption of a fixed
kibana.yml. This is the case when running against a
default FTR configuration, but not when running against remote servers.
This relaxes a few assertions and conditionally runs in cases that can't be
relaxed.

Resolves #37386

@jbudz
Support api_integration/kibana/stats against remote hosts
20ad523 
The stats API integration tests run under the assumption of a fixed
kibana.yml.  This is the case when running against a
default FTR configuration, but not when running against remote servers.
This relaxes a few assertions and conditionally runs in cases that can't be
relaxed.

Resolves elastic#37386
@jbudz jbudz added release_note:skip Skip the PR/issue when compiling release notes v7.5.1 v7.6.0 v8.0.0 labels Dec 13, 2019
@jbudz jbudz requested a review from liza-mae December 13, 2019 15:55
@elasticmachine
Copy link
Contributor

💔 Build Failed

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@liza-mae
Copy link
Contributor

Thanks @jbudz for jumping in to fix this.

I tested it on cloud, although it seems to have resolved the original failure I am getting another one now:

✖ fail: "apis kibana stats /api/stats operational stats and usage stats with auth should return 200 for extended"
✖ fail: "apis kibana stats /api/stats operational stats and usage stats with auth should return 200 for extended and legacy"

Error: expected 3 to equal 0

@jbudz
Copy link
Member Author

jbudz commented Jan 27, 2020

@elasticmachine merge upstream

@jbudz jbudz added v7.7.0 and removed v7.6.0 labels Feb 4, 2020
@jbudz
Copy link
Member Author

jbudz commented Feb 5, 2020

@elasticmachine merge upstream

@jbudz
Copy link
Member Author

jbudz commented Feb 10, 2020

@elasticmachine merge upstream

@jbudz
Copy link
Member Author

jbudz commented Feb 18, 2020

@elasticmachine merge upstream

@jbudz jbudz added the Team:Operations Team label for Operations Team label Feb 18, 2020
@jbudz
Copy link
Member Author

jbudz commented May 15, 2020

@elasticmachine merge upstream

@jbudz
Copy link
Member Author

jbudz commented May 15, 2020

@elasticmachine merge upstream

@jbudz
Copy link
Member Author

jbudz commented May 18, 2020

@elasticmachine merge upstream

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@tylersmalley
Copy link
Contributor

@liza-mae can you review this again or resolve your requested changes?

liza-mae
liza-mae approved these changes May 20, 2020
View reviewed changes
Copy link
Contributor

@liza-mae liza-mae left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, it now passes on cloud! Thanks @jbudz

@tylersmalley tylersmalley merged commit 5ab3e19 into elastic:master May 20, 2020
jloleysens added a commit to jloleysens/kibana that referenced this pull request May 20, 2020
@jloleysens
Merge branch 'master' of github.com:elastic/kibana into index-managem…
d6da4bd 
…ent/add-support-in-url-for-hidden-toggle

* 'master' of github.com:elastic/kibana: (49 commits)
  [Uptime] Improve responsiveness details page (elastic#67034)
  skip flaky suite (elastic#66669)
  Revert "Integration of a static filesystem for the node_modules (elastic#47998)" (elastic#67124)
  Support api_integration/kibana/stats against remote hosts (elastic#53000)
  chore(NA): add module name mapper for src plugins on x-pack (elastic#67103)
  Change the error message on TSVB in order to be more user friendly (elastic#67090)
  [kbn/optimizer] poll parent process to avoid zombie processes (elastic#67059)
  [Visualize] Lazy load default editor, fix duplicated styles (elastic#66732)
  Bump styled-component dependencies (elastic#66611)
  Bump react-markdown dependencies (elastic#66615)
  Fix Core docs links (elastic#66977)
  Timelion graph is not refreshing content after searching or filtering (elastic#67023)
  Remove `--xpack.endpoint.enabled=true` from README.md file (elastic#67053)
  Move apm tutorial from apm plugin into apm_oss plugin (elastic#66432)
  [Logs UI] Restore call to `UsageCollector.countLogs` (elastic#67051)
  Remove unused license check result from LP Security plugin (elastic#66966)
  [Saved Objects] adds support for including hidden types in saved objects client (elastic#66879)
  [Discover] Deangularize timechart header (elastic#66532)
  [Discover] Improve and unskip a11y context view test (elastic#66959)
  [SIEM] Refactor Timeline.timelineType draft to Timeline.status draft (elastic#66864)
  ...

# Conflicts:
#	x-pack/plugins/index_management/__jest__/client_integration/helpers/home.helpers.ts
gmmorris added a commit to gmmorris/kibana that referenced this pull request May 21, 2020
@gmmorris
Merge branch 'master' into saved-objects/scoped-client-with-extra-types
0660d44 
* master:
  [apm] Annotation API documentation (elastic#65963)
  [Uptime] Improve responsiveness details page (elastic#67034)
  skip flaky suite (elastic#66669)
  Revert "Integration of a static filesystem for the node_modules (elastic#47998)" (elastic#67124)
  Support api_integration/kibana/stats against remote hosts (elastic#53000)
  chore(NA): add module name mapper for src plugins on x-pack (elastic#67103)
  Change the error message on TSVB in order to be more user friendly (elastic#67090)
  [kbn/optimizer] poll parent process to avoid zombie processes (elastic#67059)
  [Visualize] Lazy load default editor, fix duplicated styles (elastic#66732)
  Bump styled-component dependencies (elastic#66611)
  Bump react-markdown dependencies (elastic#66615)
  Fix Core docs links (elastic#66977)
  Timelion graph is not refreshing content after searching or filtering (elastic#67023)
  Remove `--xpack.endpoint.enabled=true` from README.md file (elastic#67053)
  Move apm tutorial from apm plugin into apm_oss plugin (elastic#66432)
  [Logs UI] Restore call to `UsageCollector.countLogs` (elastic#67051)
  Remove unused license check result from LP Security plugin (elastic#66966)
gmmorris added a commit to gmmorris/kibana that referenced this pull request May 21, 2020
@gmmorris
Merge branch 'master' into actions/hide-action-type
c3c639d 
* master: (21 commits)
  [Alerting] Hides the `alert` SavedObjects type (elastic#66719)
  skip flaky suite (elastic#66869)
  fix visual baseline tests
  [kbn/optimizer] require fsevents on macos (elastic#67147)
  [APM] Fix obscured service map connections (elastic#67129)
  [apm] Annotation API documentation (elastic#65963)
  [Uptime] Improve responsiveness details page (elastic#67034)
  skip flaky suite (elastic#66669)
  Revert "Integration of a static filesystem for the node_modules (elastic#47998)" (elastic#67124)
  Support api_integration/kibana/stats against remote hosts (elastic#53000)
  chore(NA): add module name mapper for src plugins on x-pack (elastic#67103)
  Change the error message on TSVB in order to be more user friendly (elastic#67090)
  [kbn/optimizer] poll parent process to avoid zombie processes (elastic#67059)
  [Visualize] Lazy load default editor, fix duplicated styles (elastic#66732)
  Bump styled-component dependencies (elastic#66611)
  Bump react-markdown dependencies (elastic#66615)
  Fix Core docs links (elastic#66977)
  Timelion graph is not refreshing content after searching or filtering (elastic#67023)
  Remove `--xpack.endpoint.enabled=true` from README.md file (elastic#67053)
  Move apm tutorial from apm plugin into apm_oss plugin (elastic#66432)
  ...
@kibanamachine kibanamachine added the backport missing Added to PRs automatically when the are determined to be missing a backport. label May 22, 2020
@kibanamachine
Copy link
Contributor

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create backports run node scripts/backport --pr 53000 or prevent reminders by adding the backport:skip label.

2 similar comments
@kibanamachine
Copy link
Contributor

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create backports run node scripts/backport --pr 53000 or prevent reminders by adding the backport:skip label.

@kibanamachine
Copy link
Contributor

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create backports run node scripts/backport --pr 53000 or prevent reminders by adding the backport:skip label.

@liza-mae
Copy link
Contributor

@jbudz is this to be backported?

@kibanamachine
Copy link
Contributor

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create backports run node scripts/backport --pr 53000 or prevent reminders by adding the backport:skip label.

5 similar comments
@kibanamachine
Copy link
Contributor

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create backports run node scripts/backport --pr 53000 or prevent reminders by adding the backport:skip label.

@kibanamachine
Copy link
Contributor

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create backports run node scripts/backport --pr 53000 or prevent reminders by adding the backport:skip label.

@kibanamachine
Copy link
Contributor

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create backports run node scripts/backport --pr 53000 or prevent reminders by adding the backport:skip label.

@kibanamachine
Copy link
Contributor

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create backports run node scripts/backport --pr 53000 or prevent reminders by adding the backport:skip label.

@kibanamachine
Copy link
Contributor

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create backports run node scripts/backport --pr 53000 or prevent reminders by adding the backport:skip label.

@jbudz jbudz added backport:skip This commit does not require backporting and removed backport missing Added to PRs automatically when the are determined to be missing a backport. labels Jun 4, 2020
jbudz added a commit that referenced this pull request Jun 4, 2020
@jbudz @elasticmachine
Support api_integration/kibana/stats against remote hosts (#53000)
6cff2c9 
* Support api_integration/kibana/stats against remote hosts

The stats API integration tests run under the assumption of a fixed
kibana.yml.  This is the case when running against a
default FTR configuration, but not when running against remote servers.
This relaxes a few assertions and conditionally runs in cases that can't be
relaxed.

Resolves #37386

Co-authored-by: Elastic Machine <[email protected]>
@jbudz
Copy link
Member Author

jbudz commented Jun 4, 2020

7.9/x: 6cff2c9

@jbudz jbudz mentioned this pull request Aug 17, 2020
Closed
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@liza-mae liza-mae liza-mae approved these changes

@tylersmalley tylersmalley tylersmalley approved these changes

Assignees
No one assigned
Labels
backport:skip This commit does not require backporting release_note:skip Skip the PR/issue when compiling release notes Team:Operations Team label for Operations Team v7.9.0 v8.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

apis kibana stats /api/stats test failures (4)
6 participants
@jbudz @elasticmachine @liza-mae @tylersmalley @kibanamachine @rashmivkulkarni