[Reporting] Formatting fixes for CSV export in Discover, CSV download from Dashboard panel #67027

tsullivan · 2020-05-19T15:32:35Z

Summary

Part of #68718.

Addresses bugs and inconsistencies in CSV exports via more code re-use and better interfaces to the reusable code.

Fixes the BOM issue for Download CSV
Fixes Download CSV showing raw data instead of formatted per the index pattern
Fixes the date + timezone formatting issues for Download CSV
Makes timezone formatting work if Advanced Settings dateFormat:tz is set to browser
Completes export when the index pattern contains an alias to a closed index

Checklist

Delete any items that are not applicable to this PR.

Unit or functional tests were updated or added to match the most common scenarios
FieldFormatter for date_nanos strings appears to not be able to apply a timezone on the server-side: [Data Plugin] Allow server-side date formatters to accept custom timezone #70668
TODO: more tests

For maintainers

This was checked for breaking API changes and was labeled appropriately

tsullivan · 2020-06-10T22:14:41Z

x-pack/plugins/reporting/server/export_types/csv_from_savedobject/server/execute_job.ts

-        'xpack.reporting.exportTypes.csv_from_savedobject.executeJob.failedToAccessPanel',
-        { defaultMessage: 'Failed to access panel metadata for job execution' }
-      );
-    }


This check didn't make sense because panel is constructed in the create_job

tsullivan · 2020-06-11T18:07:44Z

Related: #60737 (comment)

tsullivan · 2020-06-16T20:39:58Z

x-pack/plugins/reporting/server/export_types/csv_from_savedobject/server/create_job.ts

+          (ref: SavedObjectReference) => ref.type === 'index-pattern'
+        );
+        if (!indexPatternMeta) {
+          throw new Error('Could not find index pattern for the saved search!');


Error checking was moved here from create_job_search.ts which has been factored out

…nload from Dashboard panel commit e195964deaa3e7e8d94704d6514e01498c913a81 Author: Timothy Sullivan <[email protected]> Date: Mon Jul 13 10:17:36 2020 -0700 Squashed commit of the following: commit 87c9c496a6cccaf7a60a44b496f7c0c0423cd2ea Merge: d531101ab3 ed749eb Author: Timothy Sullivan <[email protected]> Date: Mon Jul 13 10:17:02 2020 -0700 Merge branch 'data/allow-custom-formatting' into reporting/csv-date-format-consistency commit d531101ab3c2f12628287bd5ad4a02bbf8b5c990 Merge: 400e2ffba4 17dc043 Author: Timothy Sullivan <[email protected]> Date: Mon Jul 13 10:15:38 2020 -0700 Merge branch 'master' into reporting/csv-date-format-consistency commit ed749eb Author: Timothy Sullivan <[email protected]> Date: Mon Jul 13 10:12:28 2020 -0700 move shared code to common commit 4e5eebd Author: Timothy Sullivan <[email protected]> Date: Mon Jul 13 09:07:32 2020 -0700 3td time api doc chagens commit 34df331 Merge: 54fa2fe 17dc043 Author: Timothy Sullivan <[email protected]> Date: Mon Jul 13 08:50:21 2020 -0700 Merge branch 'master' into data/allow-custom-formatting commit 400e2ffba4546cf78c53ce96b45a59878f0df076 Author: Timothy Sullivan <[email protected]> Date: Sun Jul 12 21:29:34 2020 -0700 [Reporting] Data formatting fixes for CSV export in Discover, CSV download from Dashboard panel commit 54fa2fe Merge: 1b6e9e8 e1253ed Author: Elastic Machine <[email protected]> Date: Sun Jul 12 22:18:38 2020 -0600 Merge branch 'master' into data/allow-custom-formatting commit 1b6e9e8 Author: Timothy Sullivan <[email protected]> Date: Fri Jul 10 15:03:08 2020 -0700 weird api change needed but no real diff commit fc9ff7b Merge: 736e9ee 66c531d Author: Timothy Sullivan <[email protected]> Date: Fri Jul 10 14:51:51 2020 -0700 Merge branch 'master' into data/allow-custom-formatting commit 736e9ee Author: Timothy Sullivan <[email protected]> Date: Thu Jul 9 17:43:10 2020 -0700 fix path for tests commit 1bebcc8 Author: Timothy Sullivan <[email protected]> Date: Thu Jul 9 17:25:09 2020 -0700 re-use public code in server, add test commit 1e1d3c5 Author: Timothy Sullivan <[email protected]> Date: Thu Jul 9 16:35:30 2020 -0700 rerun api changes commit 231f793 Author: Timothy Sullivan <[email protected]> Date: Thu Jul 9 16:31:55 2020 -0700 fix src/plugins/data/public/field_formats/constants.ts commit d42275c Merge: 206aed6 8e2277a Author: Timothy Sullivan <[email protected]> Date: Thu Jul 9 16:01:40 2020 -0700 Merge branch 'master' into data/allow-custom-formatting commit 206aed6 Merge: 5aa2d80 09da110 Author: Timothy Sullivan <[email protected]> Date: Thu Jul 9 15:03:12 2020 -0700 Merge branch 'master' into data/allow-custom-formatting commit 5aa2d80 Author: Timothy Sullivan <[email protected]> Date: Wed Jul 8 12:12:31 2020 -0700 api doc changes commit 76e2c30 Merge: 1789afc 595e9c2 Author: Timothy Sullivan <[email protected]> Date: Wed Jul 8 12:04:12 2020 -0700 Merge branch 'master' into data/allow-custom-formatting commit 1789afc Author: Timothy Sullivan <[email protected]> Date: Fri Jul 3 11:23:03 2020 -0700 simplify changes commit 6428455 Author: Timothy Sullivan <[email protected]> Date: Thu Jul 2 16:05:57 2020 -0700 add more to tests - need help though commit 6aacfbd Author: Timothy Sullivan <[email protected]> Date: Thu Jul 2 12:04:28 2020 -0700 [Data Plugin] Allow server-side date formatters to accept custom timezone When Advanced Settings shows the date format timezone to be "Browser," this means nothing to field formatters in the server-side context. The field formatters need a way to accept custom format parameters. This allows a server-side module that creates a FieldFormatMap to set a timezone as a custom parameter. When custom formatting parameters exist, they get combined with the defaults.

tsullivan · 2020-07-13T22:24:03Z

x-pack/plugins/reporting/server/export_types/csv/types.d.ts

@@ -95,22 +101,3 @@ export interface CsvResultFromSearch {
  type: string;
  result: SavedSearchGeneratorResult;
 }
-
-export interface GenerateCsvParams {


Moved to server/export_types/csv/server/generate_csv/index.ts since it's only used for that module

tsullivan · 2020-07-13T22:25:18Z

x-pack/plugins/reporting/server/export_types/csv/server/generate_csv/hit_iterator.ts

      logger.debug('executing scroll request');
      return parseResponse(
-        callEndpoint('scroll', {
+        await callEndpoint('scroll', {


The previous code was passing through a promise, for it to be resolved in some other context

tsullivan · 2020-07-13T22:26:02Z

x-pack/plugins/reporting/server/export_types/csv/server/generate_csv/hit_iterator.ts

@@ -10,8 +10,10 @@ import { CancellationToken } from '../../../../../common';
 import { LevelLogger } from '../../../../lib';
 import { ScrollConfig } from '../../../../types';

-async function parseResponse(request: SearchResponse<any>) {
-  const response = await request;


This await was cheating against the TS type of request

joelgriffith

Changes LGTM

kibanamachine · 2020-07-14T00:18:36Z

💚 Build Succeeded

continuous-integration/kibana-ci/pull-request
Commit: a2cecc4

Build metrics

✅ unchanged

History

💚 Build #61134 succeeded 15b21a1
💚 Build #61075 succeeded 14a7170a9d27c2aedc1bf81514434296faa91823
💔 Build #60999 failed c7840aed95e3e131596cd8823420a6c681cc308e
💔 Build #60730 failed 400e2ffba4546cf78c53ce96b45a59878f0df076
💔 Build #60557 failed 2b90fb219338eda99c917fbd1f44c124220c407e

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

… from Dashboard panel (elastic#67027) * [Reporting] Data formatting fixes for CSV export in Discover, CSV download from Dashboard panel commit e195964deaa3e7e8d94704d6514e01498c913a81 Author: Timothy Sullivan <[email protected]> Date: Mon Jul 13 10:17:36 2020 -0700 Squashed commit of the following: commit 87c9c496a6cccaf7a60a44b496f7c0c0423cd2ea Merge: d531101ab3 ed749eb Author: Timothy Sullivan <[email protected]> Date: Mon Jul 13 10:17:02 2020 -0700 Merge branch 'data/allow-custom-formatting' into reporting/csv-date-format-consistency commit d531101ab3c2f12628287bd5ad4a02bbf8b5c990 Merge: 400e2ffba4 17dc043 Author: Timothy Sullivan <[email protected]> Date: Mon Jul 13 10:15:38 2020 -0700 Merge branch 'master' into reporting/csv-date-format-consistency commit ed749eb Author: Timothy Sullivan <[email protected]> Date: Mon Jul 13 10:12:28 2020 -0700 move shared code to common commit 4e5eebd Author: Timothy Sullivan <[email protected]> Date: Mon Jul 13 09:07:32 2020 -0700 3td time api doc chagens commit 34df331 Merge: 54fa2fe 17dc043 Author: Timothy Sullivan <[email protected]> Date: Mon Jul 13 08:50:21 2020 -0700 Merge branch 'master' into data/allow-custom-formatting commit 400e2ffba4546cf78c53ce96b45a59878f0df076 Author: Timothy Sullivan <[email protected]> Date: Sun Jul 12 21:29:34 2020 -0700 [Reporting] Data formatting fixes for CSV export in Discover, CSV download from Dashboard panel commit 54fa2fe Merge: 1b6e9e8 e1253ed Author: Elastic Machine <[email protected]> Date: Sun Jul 12 22:18:38 2020 -0600 Merge branch 'master' into data/allow-custom-formatting commit 1b6e9e8 Author: Timothy Sullivan <[email protected]> Date: Fri Jul 10 15:03:08 2020 -0700 weird api change needed but no real diff commit fc9ff7b Merge: 736e9ee 66c531d Author: Timothy Sullivan <[email protected]> Date: Fri Jul 10 14:51:51 2020 -0700 Merge branch 'master' into data/allow-custom-formatting commit 736e9ee Author: Timothy Sullivan <[email protected]> Date: Thu Jul 9 17:43:10 2020 -0700 fix path for tests commit 1bebcc8 Author: Timothy Sullivan <[email protected]> Date: Thu Jul 9 17:25:09 2020 -0700 re-use public code in server, add test commit 1e1d3c5 Author: Timothy Sullivan <[email protected]> Date: Thu Jul 9 16:35:30 2020 -0700 rerun api changes commit 231f793 Author: Timothy Sullivan <[email protected]> Date: Thu Jul 9 16:31:55 2020 -0700 fix src/plugins/data/public/field_formats/constants.ts commit d42275c Merge: 206aed6 8e2277a Author: Timothy Sullivan <[email protected]> Date: Thu Jul 9 16:01:40 2020 -0700 Merge branch 'master' into data/allow-custom-formatting commit 206aed6 Merge: 5aa2d80 09da110 Author: Timothy Sullivan <[email protected]> Date: Thu Jul 9 15:03:12 2020 -0700 Merge branch 'master' into data/allow-custom-formatting commit 5aa2d80 Author: Timothy Sullivan <[email protected]> Date: Wed Jul 8 12:12:31 2020 -0700 api doc changes commit 76e2c30 Merge: 1789afc 595e9c2 Author: Timothy Sullivan <[email protected]> Date: Wed Jul 8 12:04:12 2020 -0700 Merge branch 'master' into data/allow-custom-formatting commit 1789afc Author: Timothy Sullivan <[email protected]> Date: Fri Jul 3 11:23:03 2020 -0700 simplify changes commit 6428455 Author: Timothy Sullivan <[email protected]> Date: Thu Jul 2 16:05:57 2020 -0700 add more to tests - need help though commit 6aacfbd Author: Timothy Sullivan <[email protected]> Date: Thu Jul 2 12:04:28 2020 -0700 [Data Plugin] Allow server-side date formatters to accept custom timezone When Advanced Settings shows the date format timezone to be "Browser," this means nothing to field formatters in the server-side context. The field formatters need a way to accept custom format parameters. This allows a server-side module that creates a FieldFormatMap to set a timezone as a custom parameter. When custom formatting parameters exist, they get combined with the defaults. * comments

… from Dashboard panel (#67027) (#71576) * [Reporting] Data formatting fixes for CSV export in Discover, CSV download from Dashboard panel commit e195964deaa3e7e8d94704d6514e01498c913a81 Author: Timothy Sullivan <[email protected]> Date: Mon Jul 13 10:17:36 2020 -0700 Squashed commit of the following: commit 87c9c496a6cccaf7a60a44b496f7c0c0423cd2ea Merge: d531101ab3 ed749eb Author: Timothy Sullivan <[email protected]> Date: Mon Jul 13 10:17:02 2020 -0700 Merge branch 'data/allow-custom-formatting' into reporting/csv-date-format-consistency commit d531101ab3c2f12628287bd5ad4a02bbf8b5c990 Merge: 400e2ffba4 17dc043 Author: Timothy Sullivan <[email protected]> Date: Mon Jul 13 10:15:38 2020 -0700 Merge branch 'master' into reporting/csv-date-format-consistency commit ed749eb Author: Timothy Sullivan <[email protected]> Date: Mon Jul 13 10:12:28 2020 -0700 move shared code to common commit 4e5eebd Author: Timothy Sullivan <[email protected]> Date: Mon Jul 13 09:07:32 2020 -0700 3td time api doc chagens commit 34df331 Merge: 54fa2fe 17dc043 Author: Timothy Sullivan <[email protected]> Date: Mon Jul 13 08:50:21 2020 -0700 Merge branch 'master' into data/allow-custom-formatting commit 400e2ffba4546cf78c53ce96b45a59878f0df076 Author: Timothy Sullivan <[email protected]> Date: Sun Jul 12 21:29:34 2020 -0700 [Reporting] Data formatting fixes for CSV export in Discover, CSV download from Dashboard panel commit 54fa2fe Merge: 1b6e9e8 e1253ed Author: Elastic Machine <[email protected]> Date: Sun Jul 12 22:18:38 2020 -0600 Merge branch 'master' into data/allow-custom-formatting commit 1b6e9e8 Author: Timothy Sullivan <[email protected]> Date: Fri Jul 10 15:03:08 2020 -0700 weird api change needed but no real diff commit fc9ff7b Merge: 736e9ee 66c531d Author: Timothy Sullivan <[email protected]> Date: Fri Jul 10 14:51:51 2020 -0700 Merge branch 'master' into data/allow-custom-formatting commit 736e9ee Author: Timothy Sullivan <[email protected]> Date: Thu Jul 9 17:43:10 2020 -0700 fix path for tests commit 1bebcc8 Author: Timothy Sullivan <[email protected]> Date: Thu Jul 9 17:25:09 2020 -0700 re-use public code in server, add test commit 1e1d3c5 Author: Timothy Sullivan <[email protected]> Date: Thu Jul 9 16:35:30 2020 -0700 rerun api changes commit 231f793 Author: Timothy Sullivan <[email protected]> Date: Thu Jul 9 16:31:55 2020 -0700 fix src/plugins/data/public/field_formats/constants.ts commit d42275c Merge: 206aed6 8e2277a Author: Timothy Sullivan <[email protected]> Date: Thu Jul 9 16:01:40 2020 -0700 Merge branch 'master' into data/allow-custom-formatting commit 206aed6 Merge: 5aa2d80 09da110 Author: Timothy Sullivan <[email protected]> Date: Thu Jul 9 15:03:12 2020 -0700 Merge branch 'master' into data/allow-custom-formatting commit 5aa2d80 Author: Timothy Sullivan <[email protected]> Date: Wed Jul 8 12:12:31 2020 -0700 api doc changes commit 76e2c30 Merge: 1789afc 595e9c2 Author: Timothy Sullivan <[email protected]> Date: Wed Jul 8 12:04:12 2020 -0700 Merge branch 'master' into data/allow-custom-formatting commit 1789afc Author: Timothy Sullivan <[email protected]> Date: Fri Jul 3 11:23:03 2020 -0700 simplify changes commit 6428455 Author: Timothy Sullivan <[email protected]> Date: Thu Jul 2 16:05:57 2020 -0700 add more to tests - need help though commit 6aacfbd Author: Timothy Sullivan <[email protected]> Date: Thu Jul 2 12:04:28 2020 -0700 [Data Plugin] Allow server-side date formatters to accept custom timezone When Advanced Settings shows the date format timezone to be "Browser," this means nothing to field formatters in the server-side context. The field formatters need a way to accept custom format parameters. This allows a server-side module that creates a FieldFormatMap to set a timezone as a custom parameter. When custom formatting parameters exist, they get combined with the defaults. * comments

* master: (314 commits) [APM] Use status_code field to calculate error rate (elastic#71109) [Observability] Change appLink passing the date range (elastic#71259) [Security] Add Timeline improvements (elastic#71506) adjust vislib bar opacity (elastic#71421) Fix ScopedHistory mock and adapt usages (elastic#71404) [Security Solution] Add hook for reading/writing resolver query params (elastic#70809) [APM] Bug fixes from ML integration testing (elastic#71564) [Discover] Add caused_by.type and caused_by.reason to error toast modal (elastic#70404) [Security Solution] Add 3rd level breadcrumb to admin page (elastic#71275) [Security Solution][Exceptions] Exception modal bulk close alerts that match exception attributes (elastic#71321) Change signal.rule.risk score mapping from keyword to float (elastic#71126) Added help text where needed on connectors and alert actions UI (elastic#69601) [SIEM][Detections] Value Lists Management Modal (elastic#67068) [test] Skips test preventing promotion of ES snapshot elastic#71582 [test] Skips test preventing promotion of ES snapshot elastic#71555 [ILM] Fix alignment of the timing field (elastic#71273) [SIEM][Detection Engine][Lists] Adds the ability for exception lists to be multi-list queried. (elastic#71540) initial telemetry setup (elastic#69330) [Reporting] Formatting fixes for CSV export in Discover, CSV download from Dashboard panel (elastic#67027) Search across spaces (elastic#67644) ...

…t-apps-page-titles * 'master' of github.com:elastic/kibana: (88 commits) [ML] Functional tests - disable DFA creation and cloning tests [APM] Use status_code field to calculate error rate (elastic#71109) [Observability] Change appLink passing the date range (elastic#71259) [Security] Add Timeline improvements (elastic#71506) adjust vislib bar opacity (elastic#71421) Fix ScopedHistory mock and adapt usages (elastic#71404) [Security Solution] Add hook for reading/writing resolver query params (elastic#70809) [APM] Bug fixes from ML integration testing (elastic#71564) [Discover] Add caused_by.type and caused_by.reason to error toast modal (elastic#70404) [Security Solution] Add 3rd level breadcrumb to admin page (elastic#71275) [Security Solution][Exceptions] Exception modal bulk close alerts that match exception attributes (elastic#71321) Change signal.rule.risk score mapping from keyword to float (elastic#71126) Added help text where needed on connectors and alert actions UI (elastic#69601) [SIEM][Detections] Value Lists Management Modal (elastic#67068) [test] Skips test preventing promotion of ES snapshot elastic#71582 [test] Skips test preventing promotion of ES snapshot elastic#71555 [ILM] Fix alignment of the timing field (elastic#71273) [SIEM][Detection Engine][Lists] Adds the ability for exception lists to be multi-list queried. (elastic#71540) initial telemetry setup (elastic#69330) [Reporting] Formatting fixes for CSV export in Discover, CSV download from Dashboard panel (elastic#67027) ... # Conflicts: # x-pack/plugins/index_management/public/application/index.tsx

tsullivan · 2020-07-14T18:56:20Z

...ck/plugins/reporting/server/export_types/csv_from_savedobject/server/lib/get_fake_request.ts

+  }
+
+  return { headers: decryptedHeaders } as KibanaRequest;
+};


Oh snap - this was added from a bad merge. This file should have been removed as of #71031 but I accidentally added it back in this PR somehow.

tsullivan force-pushed the reporting/csv-date-format-consistency branch 2 times, most recently from 4d6eb14 to 892e804 Compare May 19, 2020 16:51

tsullivan changed the title ~~Reporting/csv date format consistency~~ [Reporting] Code cleanup for CSV export for Dashboard May 19, 2020

tsullivan force-pushed the reporting/csv-date-format-consistency branch 3 times, most recently from af43ff0 to e147e1f Compare May 21, 2020 15:53

tsullivan mentioned this pull request May 21, 2020

[Bug] Timezone discrepancy when exporting CSV files from discovery and dashboard #56371

Closed

tsullivan force-pushed the reporting/csv-date-format-consistency branch 4 times, most recently from 24ea1a2 to 086a42a Compare May 27, 2020 20:16

tsullivan force-pushed the reporting/csv-date-format-consistency branch 6 times, most recently from e9211d3 to 18f33e1 Compare June 9, 2020 23:54

tsullivan force-pushed the reporting/csv-date-format-consistency branch from 18f33e1 to 3d4d0d5 Compare June 10, 2020 22:10

tsullivan commented Jun 10, 2020

View reviewed changes

tsullivan changed the title ~~[Reporting] Code cleanup for CSV export for Dashboard~~ [Reporting] Code cleanup for CSV Export Types Jun 11, 2020

tsullivan added release_note:skip Skip the PR/issue when compiling release notes v7.9.0 v8.0.0 labels Jun 11, 2020

tsullivan force-pushed the reporting/csv-date-format-consistency branch 4 times, most recently from 0e2a133 to 2dea8ed Compare June 16, 2020 20:35

tsullivan commented Jun 16, 2020

View reviewed changes

tsullivan force-pushed the reporting/csv-date-format-consistency branch from 2dea8ed to b08ac11 Compare June 16, 2020 20:41

tsullivan force-pushed the reporting/csv-date-format-consistency branch from 97141cb to 69090a2 Compare July 6, 2020 23:35

tsullivan mentioned this pull request Jul 8, 2020

[Reporting] remove async execution from csv_from_savedobject #71031

Merged

2 tasks

tsullivan force-pushed the reporting/csv-date-format-consistency branch 3 times, most recently from 400e2ff to c7840ae Compare July 13, 2020 17:25

tsullivan changed the title ~~[Reporting] Various fixes for CSV export in Discover, CSV download from Dashboard panel~~ [Reporting] Formatting fixes for CSV export in Discover, CSV download from Dashboard panel Jul 13, 2020

tsullivan force-pushed the reporting/csv-date-format-consistency branch from c7840ae to 14a7170 Compare July 13, 2020 19:52

tsullivan force-pushed the reporting/csv-date-format-consistency branch from 14a7170 to 15b21a1 Compare July 13, 2020 22:07

tsullivan commented Jul 13, 2020

View reviewed changes

comments

a2cecc4

joelgriffith approved these changes Jul 13, 2020

View reviewed changes

tsullivan marked this pull request as ready for review July 13, 2020 23:14

tsullivan merged commit 2340f8a into elastic:master Jul 14, 2020

tsullivan deleted the reporting/csv-date-format-consistency branch July 14, 2020 00:22

tsullivan mentioned this pull request Jul 14, 2020

[7.x] [Reporting] Formatting fixes for CSV export in Discover, CSV download from Dashboard panel (#67027) #71576

Merged

tsullivan commented Jul 14, 2020

View reviewed changes

tsullivan mentioned this pull request Jul 14, 2020

[Reporting] Clean up orphaned file #71730

Merged

This was referenced Sep 23, 2020

CSV export date not applying correct date format (from a saved search in a dashboard) #56153

Closed

CSV file generated with erroneous @timestamp field #42231

Closed

romain-chanu mentioned this pull request Feb 8, 2021

[Bug] Timezone not being considered when exporting CSV files from discovery if dateFormat:tz is Browser #56497

Closed

dokmic mentioned this pull request Mar 5, 2021

[CSV export] numeric fields being exported as strings #64170

Closed

tsullivan mentioned this pull request Jul 8, 2021

(Kibana -> Discover -> Reporting -> Generate & Download) How to format 'timstamp' field in CSV report #104243

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Reporting] Formatting fixes for CSV export in Discover, CSV download from Dashboard panel #67027

[Reporting] Formatting fixes for CSV export in Discover, CSV download from Dashboard panel #67027

tsullivan commented May 19, 2020 •

edited

Loading

tsullivan Jun 10, 2020

tsullivan commented Jun 11, 2020

tsullivan Jun 16, 2020

tsullivan Jul 13, 2020

tsullivan Jul 13, 2020

tsullivan Jul 13, 2020

joelgriffith left a comment

kibanamachine commented Jul 14, 2020

tsullivan Jul 14, 2020

[Reporting] Formatting fixes for CSV export in Discover, CSV download from Dashboard panel #67027

[Reporting] Formatting fixes for CSV export in Discover, CSV download from Dashboard panel #67027

Conversation

tsullivan commented May 19, 2020 • edited Loading

Summary

Checklist

For maintainers

tsullivan Jun 10, 2020

Choose a reason for hiding this comment

tsullivan commented Jun 11, 2020

tsullivan Jun 16, 2020

Choose a reason for hiding this comment

tsullivan Jul 13, 2020

Choose a reason for hiding this comment

tsullivan Jul 13, 2020

Choose a reason for hiding this comment

tsullivan Jul 13, 2020

Choose a reason for hiding this comment

joelgriffith left a comment

Choose a reason for hiding this comment

kibanamachine commented Jul 14, 2020

💚 Build Succeeded

Build metrics

History

tsullivan Jul 14, 2020

Choose a reason for hiding this comment

tsullivan commented May 19, 2020 •

edited

Loading