comments

x-pack/plugins/reporting/public/share_context_menu/register_csv_reporting.tsx

@@ -40,6 +40,9 @@ export const csvReportingProvider = ({
     disabled = !enableLinks;
   });
 
+  // If the TZ is set to the default "Browser", it will not be useful for
+  // server-side export. We need to derive the timezone and pass it as a param
+  // to the export API.
   const browserTimezone =
     uiSettings.get('dateFormat:tz') === 'Browser'
       ? moment.tz.guess()

x-pack/plugins/reporting/public/share_context_menu/register_pdf_png_reporting.tsx

@@ -42,6 +42,9 @@ export const reportingPDFPNGProvider = ({
     disabled = !enableLinks;
   });
 
+  // If the TZ is set to the default "Browser", it will not be useful for
+  // server-side export. We need to derive the timezone and pass it as a param
+  // to the export API.
   const browserTimezone =
     uiSettings.get('dateFormat:tz') === 'Browser'
       ? moment.tz.guess()

x-pack/plugins/reporting/server/export_types/csv/server/execute_job.ts

@@ -4,12 +4,55 @@
  * you may not use this file except in compliance with the Elastic License.
  */
 
+import { Crypto } from '@elastic/node-crypto';
+import { i18n } from '@kbn/i18n';
+import Hapi from 'hapi';
+import { KibanaRequest } from '../../../../../../../src/core/server';
 import { CONTENT_TYPE_CSV, CSV_JOB_TYPE } from '../../../../common/constants';
-import { cryptoFactory } from '../../../lib';
+import { cryptoFactory, LevelLogger } from '../../../lib';
 import { ESQueueWorkerExecuteFn, RunTaskFnFactory } from '../../../types';
 import { ScheduledTaskParamsCSV } from '../types';
 import { createGenerateCsv } from './generate_csv';
-import { getRequest } from './lib/get_request';
+
+const getRequest = async (headers: string | undefined, crypto: Crypto, logger: LevelLogger) => {
+  const decryptHeaders = async () => {
+    try {
+      if (typeof headers !== 'string') {
+        throw new Error(
+          i18n.translate(
+            'xpack.reporting.exportTypes.csv.executeJob.missingJobHeadersErrorMessage',
+            {
+              defaultMessage: 'Job headers are missing',
+            }
+          )
+        );
+      }
+      return await crypto.decrypt(headers);
+    } catch (err) {
+      logger.error(err);
+      throw new Error(
+          i18n.translate(
+            'xpack.reporting.exportTypes.csv.executeJob.failedToDecryptReportJobDataErrorMessage',
+            {
+              defaultMessage: 'Failed to decrypt report job data. Please ensure that {encryptionKey} is set and re-generate this report. {err}',
+              values: { encryptionKey: 'xpack.reporting.encryptionKey', err: err.toString() },
+            }
+          )
+        ); // prettier-ignore
+    }
+  };
+
+  return KibanaRequest.from({
+    headers: await decryptHeaders(),
+    // This is used by the spaces SavedObjectClientWrapper to determine the existing space.
+    // We use the basePath from the saved job, which we'll have post spaces being implemented;
+    // or we use the server base path, which uses the default space
+    path: '/',
+    route: { settings: {} },
+    url: { href: '/' },
+    raw: { req: { url: '/' } },
+  } as Hapi.Request);
+};
 
 export const runTaskFnFactory: RunTaskFnFactory<ESQueueWorkerExecuteFn<
   ScheduledTaskParamsCSV

x-pack/plugins/reporting/server/export_types/csv/server/lib/get_request.ts

@@ -10,9 +10,6 @@ import Hapi from 'hapi';
 import { KibanaRequest } from '../../../../../../../../src/core/server';
 import { LevelLogger } from '../../../../lib';
 
-/*
- * FIXME: remove this function. CSV From Saved Object export is only
- * synchronous - only needs to deal with a real request object */
 export const getRequest = async (
   headers: string | undefined,
   crypto: Crypto,

x-pack/plugins/reporting/server/export_types/csv/types.d.ts

@@ -48,7 +48,6 @@ export interface ScheduledTaskParamsCSV extends ScheduledTaskParams<JobParamsDis
   conflictedTypesFields: any;
 }
 
-// FIXME should be provided by serverside data access plugin
 export interface SearchRequest {
   index: string;
   body:

x-pack/plugins/reporting/server/export_types/csv_from_savedobject/server/lib/get_csv_job.ts

@@ -126,7 +126,7 @@ export const getGenerateCsvParams = async (
       docvalue_fields: docValueFields,
       query: esQuery.buildEsQuery(
         indexPatternSavedObject as IIndexPattern,
-        (searchSourceQuery as unknown) as Query, // FIXME use the types from data plugin
+        (searchSourceQuery as unknown) as Query,
         (combinedFilter as unknown) as Filter,
         esQueryConfig
       ),