Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[style] slightly increase header line-height #6656

Merged
merged 1 commit into from
Mar 25, 2016
Merged

[style] slightly increase header line-height #6656

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/ui/public/styles/variables/bootstrap-mods.less
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,7 +46,7 @@
//** By default, this inherits from the `<body>`.
@headings-font-family: @font-family-base;
@headings-font-weight: 400;
@headings-line-height: 1.1;
@headings-line-height: 1.3;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there a reason why we have to set this explicitly instead of just letting the browser do its thing with line-height: normal;? This particular height might work with open sans, but I haven't tested it on every font in the font family on every OS in every browser.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe it's because bootstrap uses the line-height for certain calculations (like how tall this or that should be) but I'm not sure. It's bs (bootstrap).

//** By default, this inherits from the `<body>`.
@headings-color: inherit;

Expand Down