[style] slightly increase header line-height #6656
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
On the index pattern page we use overflow:hidden; to use css elipses on the title of index patterns. This works great, but because of the line-height of 1.1 low hanging letters get cut off (the bottom of the g in logstash for instance). Increasing the line-height slightly has no real effect on layout because the letters naturally overflow the current line-height, but in scenarios with overflow: hidden it prevents the letters from getting cutoff.
| @@ -46,7 +46,7 @@ | |||
| //** By default, this inherits from the `<body>`. | |||
| @headings-font-family: @font-family-base; | |||
| @headings-font-weight: 400; | |||
| @headings-line-height: 1.1; | |||
| @headings-line-height: 1.3; | |||
There was a problem hiding this comment.
Is there a reason why we have to set this explicitly instead of just letting the browser do its thing with line-height: normal;? This particular height might work with open sans, but I haven't tested it on every font in the font family on every OS in every browser.
There was a problem hiding this comment.
I believe it's because bootstrap uses the line-height for certain calculations (like how tall this or that should be) but I'm not sure. It's bs (bootstrap).
|
Left one suggestion, but otherwise LGTM. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #6637
On the index pattern page we use overflow:hidden; to use css elipses on the title of index patterns. This works great, but because of the line-height of 1.1 low hanging letters get cut off (the bottom of the g in logstash for instance). Increasing the line-height slightly has no real effect on layout because the letters naturally overflow the current line-height, but in scenarios with overflow: hidden it prevents the letters from getting cutoff.