Fixes Recently Viewed links allowing them to close the nav when clicked #66280
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
myasonik
added
release_note:fix
v8.0.0
REASSIGN from Team:Core UI
|
Pinging @elastic/kibana-core-ui (Team:Core UI) |
5 tasks
ryankeairns
approved these changes
May 12, 2020
💚 Build SucceededHistory
To update your PR or re-run it, just comment with: |
pgayvallet
approved these changes
May 13, 2020
This was referenced May 13, 2020
Merged
myasonik
pushed a commit
to myasonik/kibana
that referenced
this pull request
May 13, 2020
myasonik
pushed a commit
that referenced
this pull request
May 13, 2020
myasonik
pushed a commit
that referenced
this pull request
May 13, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Recently Viewed links didn't close the nav when clicked. Now they do (matching all other links).
Updated other CollapsibleNav tests to also consider Recently Viewed links as well.
Checklist