fix test failures

elastic · May 12, 2020 · d5d564c · d5d564c
1 parent 040ad2d
commit d5d564c
Show file tree

Hide file tree

Showing 3 changed files with 17 additions and 17 deletions.
diff --git a/src/core/public/chrome/ui/header/__snapshots__/collapsible_nav.test.tsx.snap b/src/core/public/chrome/ui/header/__snapshots__/collapsible_nav.test.tsx.snap
diff --git a/src/core/public/chrome/ui/header/collapsible_nav.test.tsx b/src/core/public/chrome/ui/header/collapsible_nav.test.tsx
@@ -67,14 +67,14 @@ function mockProps() {
   };
 }
 
-function expectNavLinksCount(component: ReactWrapper, count: number) {
+function expectShownNavLinksCount(component: ReactWrapper, count: number) {
   expect(
-    component.find('.euiAccordion-isOpen a[data-test-subj="collapsibleNavAppLink"]').length
+    component.find('.euiAccordion-isOpen a[data-test-subj^="collapsibleNavAppLink"]').length
   ).toEqual(count);
 }
 
 function expectNavIsClosed(component: ReactWrapper) {
-  expectNavLinksCount(component, 0);
+  expectShownNavLinksCount(component, 0);
 }
 
 function clickGroup(component: ReactWrapper, group: string) {
@@ -137,14 +137,14 @@ describe('CollapsibleNav', () => {
         recentNavLinks={recentNavLinks}
       />
     );
-    expectNavLinksCount(component, 3);
+    expectShownNavLinksCount(component, 3);
     clickGroup(component, 'kibana');
     clickGroup(component, 'recentlyViewed');
-    expectNavLinksCount(component, 1);
+    expectShownNavLinksCount(component, 1);
     component.setProps({ isOpen: false });
     expectNavIsClosed(component);
     component.setProps({ isOpen: true });
-    expectNavLinksCount(component, 1);
+    expectShownNavLinksCount(component, 1);
   });
 
   it('closes the nav after clicking a link', () => {

diff --git a/src/core/public/chrome/ui/header/collapsible_nav.tsx b/src/core/public/chrome/ui/header/collapsible_nav.tsx
@@ -155,7 +155,7 @@ export function CollapsibleNav({
               // TODO #64541
               // Can remove icon from recent links completely
               listItems={recentNavLinks.map(({ iconType, onClick = () => {}, ...link }) => ({
-                'data-test-subj': 'collapsibleNavAppLink',
+                'data-test-subj': 'collapsibleNavAppLink--recent',
                 onClick: (e: React.MouseEvent<HTMLButtonElement, MouseEvent>) => {
                   onIsOpenUpdate(false);
                   onClick(e);