Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changes to add custom labeling to docs #6557

Closed
wants to merge 1 commit into from
Closed

Changes to add custom labeling to docs #6557

wants to merge 1 commit into from

Conversation

palecur
Copy link

@palecur palecur commented Mar 17, 2016

No description provided.

@tbragin
Copy link
Contributor

tbragin commented Mar 18, 2016

LGTM

@tbragin tbragin mentioned this pull request Mar 18, 2016
3 tasks
@rashidkpc
Copy link
Contributor

@palecur shouldn't this be submitted against master and backported?

@palecur
Copy link
Author

palecur commented Mar 21, 2016

Possibly -- since it was a 4.5 issue and 4.5 has already been locked away
from master, I was unsure. In any event, I'll cherry-pick it into master.

On Fri, Mar 18, 2016 at 2:23 PM, Rashid Khan [email protected]
wrote:

@palecur https://github.com/palecur shouldn't this be submitted against
master and backported?


You are receiving this because you were mentioned.
Reply to this email directly or view it on GitHub
#6557 (comment)

@palecur
Copy link
Author

palecur commented Mar 22, 2016

Changes added in commit 7ec9b6a for 4.5, 1f2d966 for master.

@palecur palecur closed this Mar 22, 2016
cee-chen pushed a commit that referenced this pull request Feb 9, 2023
## Summary

`[email protected]` ⏩ `[email protected]`

___

## [`74.1.0`](https://github.com/elastic/eui/releases/tag/v74.1.0)

- Added new `EuiSkeletonText`, `EuiSkeletonTitle`, `EuiSkeletonCircle`,
and `EuiSkeletonRectangle` components
([#6502](elastic/eui#6502))
- Updated `EuiSuperSelect` screen reader instructions to be more
specific ([#6549](elastic/eui#6549))
- Added `error` and updated `alert` glyphs to `EuiIcon`
([#6550](elastic/eui#6550))
- All `EuiSkeleton` components now accept an `isLoading` flag and
`children`, which automatically handles conditionally rendering loading
skeletons vs. loaded content (`children`)
([#6562](elastic/eui#6562))
- All `EuiSkeleton` components now accept a `contentAriaLabel` prop,
which more meaningfully describes the loaded content to screen readers
([#6562](elastic/eui#6562))
- Updated `EuiPopover` screen reader instructions for mobile and click
behaviors ([#6567](elastic/eui#6567))

**Bug fixes**

- Fixed `EuiCard` to ensure `onClick` method only runs once when `title`
contains a React node
([#6551](elastic/eui#6551))

**Deprecations**

- Deprecated `EuiLoadingContent` - use `EuiSkeletonText` instead
([#6557](elastic/eui#6557))

---------

Co-authored-by: Kibana Machine <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants