Paginated selectable list directive #6550
Conversation
|
I removed the list header from the However, I think that this is something that should be retained. It really helps to be able to sort by name either ascending or descending. In addition, it removes it everywhere. It is something that should probably be added to the |
| if ($scope.userMakeUrl) { | ||
| return $scope.userMakeUrl(hit); | ||
| } | ||
| return '#'; |
There was a problem hiding this comment.
This is a required parameter, just call the function and let it throw an error if its undefined.
- switch from maps to objects - use lodash's get/set/has - use configPrefix instead of id, if set - also adds an unset config method
…le list directives and updating the styling, making makeUrl and onSelect functions mutually exclusive
|
@rashidkpc ready for review. |
| @@ -45,7 +53,15 @@ | |||
| .list-group { | |||
| margin-bottom: 0; | |||
|
|
|||
| .list-group-item { | |||
| .list-group-item .list-group-item-menu:hover { | |||
There was a problem hiding this comment.
Is this list-group-item-menu class still in use?
There was a problem hiding this comment.
I see list-group-menu-item in use, but I don't see a style of it it (note the menu->item item->menu swap in the name). In any case it looks like everywhere it is used list-group-item is already a class on the element. Seems like it could go right?
There was a problem hiding this comment.
Yes, that can go.
…table_list_directive
short url: ensure absolute path isn't persisted
…aved-object-finder
|
Just finished up the last of the changes. @rashidkpc back to you. |
Kibana 5 design
also fixes issue with recursive removal of properties
[npm] update babel
Write process pid file earlier
Implement plugin config prefix
This was a leftover artifact from the large design feature branch effort, and it shouldn't have been pushed to master.
…re row to be clickable
|
Same pull, but against master: #6630 |
## Summary `[email protected]` ⏩ `[email protected]` ___ ## [`74.1.0`](https://github.com/elastic/eui/releases/tag/v74.1.0) - Added new `EuiSkeletonText`, `EuiSkeletonTitle`, `EuiSkeletonCircle`, and `EuiSkeletonRectangle` components ([#6502](elastic/eui#6502)) - Updated `EuiSuperSelect` screen reader instructions to be more specific ([#6549](elastic/eui#6549)) - Added `error` and updated `alert` glyphs to `EuiIcon` ([#6550](elastic/eui#6550)) - All `EuiSkeleton` components now accept an `isLoading` flag and `children`, which automatically handles conditionally rendering loading skeletons vs. loaded content (`children`) ([#6562](elastic/eui#6562)) - All `EuiSkeleton` components now accept a `contentAriaLabel` prop, which more meaningfully describes the loaded content to screen readers ([#6562](elastic/eui#6562)) - Updated `EuiPopover` screen reader instructions for mobile and click behaviors ([#6567](elastic/eui#6567)) **Bug fixes** - Fixed `EuiCard` to ensure `onClick` method only runs once when `title` contains a React node ([#6551](elastic/eui#6551)) **Deprecations** - Deprecated `EuiLoadingContent` - use `EuiSkeletonText` instead ([#6557](elastic/eui#6557)) --------- Co-authored-by: Kibana Machine <[email protected]>
Adds a paginated selectable list to the visualize interface.