Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Maps] convert EMS file source to TS #65373

Merged
merged 8 commits into from
May 6, 2020
Merged

Conversation

nreese
Copy link
Contributor

@nreese nreese commented May 5, 2020

PR converts EmsFileSource to typescript

@nreese nreese added chore [Deprecated-Use Team:Presentation]Team:Geo Former Team Label for Geo Team. Now use Team:Presentation v8.0.0 v7.9.0 labels May 5, 2020
@nreese nreese requested a review from thomasneirynck May 5, 2020 21:21
@nreese nreese requested review from a team as code owners May 5, 2020 21:21
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-gis (Team:Geo)

@thomasneirynck thomasneirynck added the release_note:skip Skip the PR/issue when compiling release notes label May 6, 2020
@nreese
Copy link
Contributor Author

nreese commented May 6, 2020

@elasticmachine merge upstream

@elasticmachine
Copy link
Contributor

user doesn't have permission to update head repository

@nreese
Copy link
Contributor Author

nreese commented May 6, 2020

@elasticmachine merge upstream

@elasticmachine
Copy link
Contributor

user doesn't have permission to update head repository

Copy link
Contributor

@elizabetdev elizabetdev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I reviewed the code and just a few SCSS files were moved. LGTM! 🎉

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@nreese nreese merged commit 2eaa074 into elastic:master May 6, 2020
nreese added a commit to nreese/kibana that referenced this pull request May 6, 2020
* [Maps] convert EMS file source to TS

* ts more ems_file_source

* ts lint cleanup

* more ts clean up

* clean up some ts-ignores

* review feedback
nreese added a commit that referenced this pull request May 6, 2020
* [Maps] convert EMS file source to TS

* ts more ems_file_source

* ts lint cleanup

* more ts clean up

* clean up some ts-ignores

* review feedback
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore [Deprecated-Use Team:Presentation]Team:Geo Former Team Label for Geo Team. Now use Team:Presentation release_note:skip Skip the PR/issue when compiling release notes v7.9.0 v8.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants