Skip to content

Commit

Permalink
[Maps] convert EMS file source to TS (#65373)
Browse files Browse the repository at this point in the history
* [Maps] convert EMS file source to TS

* ts more ems_file_source

* ts lint cleanup

* more ts clean up

* clean up some ts-ignores

* review feedback
  • Loading branch information
nreese authored May 6, 2020
1 parent 552bac5 commit 2eaa074
Show file tree
Hide file tree
Showing 24 changed files with 447 additions and 349 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@ export type EMSTMSSourceDescriptor = AbstractSourceDescriptor & {

export type EMSFileSourceDescriptor = AbstractSourceDescriptor & {
// id: EMS file id

id: string;
tooltipProperties: string[];
};

Expand Down
2 changes: 1 addition & 1 deletion x-pack/plugins/maps/public/components/_index.scss
Original file line number Diff line number Diff line change
@@ -1,3 +1,3 @@
@import 'metric_editors';
@import './geometry_filter';
@import 'tooltip_selector';
@import 'tooltip_selector/tooltip_selector';
229 changes: 0 additions & 229 deletions x-pack/plugins/maps/public/components/tooltip_selector.js

This file was deleted.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Original file line number Diff line number Diff line change
Expand Up @@ -18,15 +18,17 @@ const defaultProps = {
},
{
name: 'prop2',
label: 'prop2-label',
type: 'string',
},
{
name: '@timestamp',
label: '@timestamp-label',
type: 'date',
},
],
selectedFields: [],
onSelect: () => {},
onAdd: () => {},
};

test('Should render', () => {
Expand All @@ -39,7 +41,10 @@ test('Should remove selected fields from selectable', () => {
const component = shallow(
<AddTooltipFieldPopover
{...defaultProps}
selectedFields={[{ name: 'prop2' }, { name: 'prop1' }]}
selectedFields={[
{ name: 'prop2', label: 'prop2-label', type: 'string' },
{ name: 'prop1', label: 'prop1-label', type: 'string' },
]}
/>
);

Expand Down
Loading

0 comments on commit 2eaa074

Please sign in to comment.