[Logs UI] [Alerting] Alerts management page enhancements #64654
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Kerry350
added
Feature:Alerting
Feature:Logs UI
|
Pinging @elastic/logs-metrics-ui (Team:logs-metrics-ui) |
|
@elasticmachine merge upstream |
afgomez
approved these changes
May 4, 2020
| import { FormattedMessage } from '@kbn/i18n/react'; | ||
| import { | ||
| ForLastExpression, | ||
| // eslint-disable-next-line @kbn/eslint/no-restricted-paths | ||
| } from '../../../../../../triggers_actions_ui/public/common'; | ||
| // eslint-disable-next-line @kbn/eslint/no-restricted-paths | ||
| import { IErrorObject } from '../../../../../../triggers_actions_ui/public/types'; | ||
| import { useSource } from '../../../../containers/source'; | ||
| // eslint-disable-next-line @kbn/eslint/no-restricted-paths |
There was a problem hiding this comment.
Do you know why this path might be restricted? Maybe it's a bug and it shouldn't
There was a problem hiding this comment.
Yeah, I need to follow this up with the Alerting team. There's a few types we're (logs and metrics) using that aren't exported from public or server, and so aren't really supposed to be used. Once they're bumped up to being part of the public or server contract, I'll remove the lint overrides. I'll handle in a followup 👍
|
@elasticmachine merge upstream |
|
@afgomez Thanks for the review 👍 |
💚 Build SucceededHistory
To update your PR or re-run it, just comment with: |
Kerry350
added a commit
to Kerry350/kibana
that referenced
this pull request
May 4, 2020
* Ensure adding / editing log alerts works from the alerts management page
gmmorris
added a commit
to gmmorris/kibana
that referenced
this pull request
May 4, 2020
…ana into alerting/np-tests-migration * 'alerting/np-tests-migration' of github.com:gmmorris/kibana: [APM] Agent remote config: validation for Java agent configs (elastic#63956) [APM] Fix duplicate index patterns (elastic#64883) Drilldowns (elastic#61219) [Alerting] fix labels and links in PagerDuty action ui and docs (elastic#64032) [Event Log] Ensure sorting tests are less flaky (elastic#64781) update endpoint to restrict removing with datasources (elastic#64978) [Logs UI] [Alerting] Alerts management page enhancements (elastic#64654) Adjust kibana app owning files (elastic#65064) Migrate tutorial resources (elastic#64298) [Logs UI] Tweak copy in log alerts dialog (elastic#64645) [Logs UI] [Alerting] Documentation (elastic#64886) [Logs UI] Add dataset filter to ML module setup screen (elastic#64470) [TSVB] Fixing memory leak (elastic#64918) Bump backport to 5.4.1 (elastic#65041)
Kerry350
added a commit
that referenced
this pull request
May 4, 2020
…5070) * Ensure adding / editing log alerts works from the alerts management page Co-authored-by: Elastic Machine <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR:
fetchis an injected dependency, which also kills off severallegacy_singletonuses.Testing
mount, instead ofsetup, to reduce bundle sizes which breaks editing on the alerts management page. If someone starts reviewing this before this is sorted with Ops you can simply move the linethis.registerLogsAlertType(pluginsSetup);frommounttosetupAlerting requires SSL, with a local setup this can be enabled like so:
yarn es snapshot --sslyarn start --sslssl.verification_mode: noneinside of the Filebeat config.Things to check: