Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[APM] Agent remote config: validation for Java agent configs #63956

Merged
merged 18 commits into from
May 4, 2020
Merged

[APM] Agent remote config: validation for Java agent configs #63956

merged 18 commits into from
May 4, 2020

Conversation

cauemarcondes
Copy link
Contributor

closes #62782

@cauemarcondes cauemarcondes added release_note:skip Skip the PR/issue when compiling release notes v7.8.0 apm:Agent Configuration labels Apr 20, 2020
@cauemarcondes cauemarcondes requested a review from a team as a code owner April 20, 2020 12:08
@cauemarcondes
Copy link
Contributor Author

@elasticmachine merge upstream

@cauemarcondes cauemarcondes added release_note:enhancement and removed release_note:skip Skip the PR/issue when compiling release notes labels Apr 20, 2020
@cauemarcondes
Copy link
Contributor Author

@elasticmachine merge upstream

@cauemarcondes cauemarcondes requested review from dgieselaar and a team April 23, 2020 09:38
@cauemarcondes
Copy link
Contributor Author

@elasticmachine merge upstream

@cauemarcondes cauemarcondes requested a review from a team April 29, 2020 09:20
@cauemarcondes cauemarcondes requested a review from sorenlouv April 30, 2020 11:49
@cauemarcondes
Copy link
Contributor Author

@elasticmachine merge upstream

sorenlouv
sorenlouv approved these changes Apr 30, 2020
View reviewed changes
Copy link
Member

@sorenlouv sorenlouv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for doing the last nits. lgtm 👍

x-pack/plugins/apm/common/agent_configuration/runtime_types/bytes_rt.ts Outdated Show resolved Hide resolved
@kibanamachine
Copy link
Contributor

💚 Build Succeeded

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@cauemarcondes cauemarcondes merged commit f8349f6 into elastic:master May 4, 2020
@cauemarcondes cauemarcondes deleted the agent-config-validations branch May 4, 2020 14:22
@cauemarcondes cauemarcondes mentioned this pull request May 4, 2020
Merged
cauemarcondes added a commit to cauemarcondes/kibana that referenced this pull request May 4, 2020
@cauemarcondes @elasticmachine @sorenlouv
[APM] Agent remote config: validation for Java agent configs (elastic…
b3310a0 
…#63956)

* validating java settings

* adding min max support to duration

* Agent config cleanup

* refactoring

* refactoring

* refactoring

* fixing i18n

* validating min and max bytes

* refactoring

* refactoring

* refactoring

* accept number and string on amountAndUnitToString

Co-authored-by: Elastic Machine <[email protected]>
Co-authored-by: Søren Louv-Jansen <[email protected]>
gmmorris added a commit to gmmorris/kibana that referenced this pull request May 4, 2020
@gmmorris
Merge branch 'alerting/np-tests-migration' of github.com:gmmorris/kib…
85a6679 
…ana into alerting/np-tests-migration

* 'alerting/np-tests-migration' of github.com:gmmorris/kibana:
  [APM] Agent remote config: validation for Java agent configs (elastic#63956)
  [APM] Fix duplicate index patterns (elastic#64883)
  Drilldowns (elastic#61219)
  [Alerting] fix labels and links in PagerDuty action ui and docs (elastic#64032)
  [Event Log] Ensure sorting tests are less flaky (elastic#64781)
  update endpoint to restrict removing with datasources (elastic#64978)
  [Logs UI] [Alerting] Alerts management page enhancements (elastic#64654)
  Adjust kibana app owning files (elastic#65064)
  Migrate tutorial resources (elastic#64298)
  [Logs UI] Tweak copy in log alerts dialog (elastic#64645)
  [Logs UI] [Alerting] Documentation (elastic#64886)
  [Logs UI] Add dataset filter to ML module setup screen (elastic#64470)
  [TSVB] Fixing memory leak (elastic#64918)
  Bump backport to 5.4.1 (elastic#65041)
cauemarcondes added a commit that referenced this pull request May 4, 2020
@cauemarcondes @elasticmachine @sorenlouv
[APM] Agent remote config: validation for Java agent configs (#63956) (…
6ca7b59 
…#65086)

* validating java settings

* adding min max support to duration

* Agent config cleanup

* refactoring

* refactoring

* refactoring

* fixing i18n

* validating min and max bytes

* refactoring

* refactoring

* refactoring

* accept number and string on amountAndUnitToString

Co-authored-by: Elastic Machine <[email protected]>
Co-authored-by: Søren Louv-Jansen <[email protected]>

Co-authored-by: Elastic Machine <[email protected]>
Co-authored-by: Søren Louv-Jansen <[email protected]>
@sorenlouv
Copy link
Member

Works as expected

stress_monitor_cpu_duration_threshold

profiling_inferred_spans_sampling_interval

@sorenlouv sorenlouv added the apm:test-plan-done Pull request that was successfully tested during the test plan label May 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sorenlouv sorenlouv sorenlouv approved these changes

@dgieselaar dgieselaar Awaiting requested review from dgieselaar

Assignees
No one assigned
Labels
apm:Agent Configuration apm:test-plan-7.8.0 apm:test-plan-done Pull request that was successfully tested during the test plan release_note:enhancement v7.8.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[APM] Agent remote config: validation for Java agent configs
5 participants
@cauemarcondes @kibanamachine @sorenlouv @dgieselaar @elasticmachine