Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Ingest][Endpoint] Add Ingest rest api response types for use in Endpoint #63373

Conversation

paul-tavares
Copy link
Contributor

@paul-tavares paul-tavares commented Apr 13, 2020

Summary

Adds a few REST Response types to Ingest for the APIs currently being used from Endpoint.

Fixes #60677

Ingest additions:

  • GetDatasourcesResponse
  • GetOneDatasourceResponse
  • UpdateDatasourceResponse

Endpoint Refactoring:

  • Used new response types in definition of Policy related types

@paul-tavares paul-tavares added v8.0.0 release_note:skip Skip the PR/issue when compiling release notes Team:Endpoint Management Feature:Endpoint Elastic Endpoint feature v7.8.0 Team:Fleet Team label for Observability Data Collection Fleet team labels Apr 13, 2020
@paul-tavares paul-tavares requested a review from a team as a code owner April 13, 2020 16:26
@paul-tavares paul-tavares requested a review from a team April 13, 2020 16:26
@paul-tavares paul-tavares self-assigned this Apr 13, 2020
@elasticmachine
Copy link
Contributor

Pinging @elastic/endpoint-management (Team:Endpoint Management)

@elasticmachine
Copy link
Contributor

Pinging @elastic/endpoint-app-team (Feature:Endpoint)

@elasticmachine
Copy link
Contributor

Pinging @elastic/ingest-management (Team:Ingest Management)

Copy link
Contributor

@jfsiii jfsiii left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn't run this but the Ingest Manager types look correct to me

…-add-rest-api-response-types

# Conflicts:
#	x-pack/plugins/endpoint/public/applications/endpoint/store/policy_list/middleware.ts
…-add-rest-api-response-types

# Conflicts:
#	x-pack/plugins/ingest_manager/common/types/rest_spec/datasource.ts
@kibanamachine
Copy link
Contributor

💚 Build Succeeded

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@paul-tavares paul-tavares merged commit a4464c2 into elastic:master Apr 14, 2020
@paul-tavares paul-tavares deleted the task/ingest-60677-add-rest-api-response-types branch April 14, 2020 17:36
paul-tavares added a commit to paul-tavares/kibana that referenced this pull request Apr 14, 2020
…oint (elastic#63373)

* Added REST Response types to datasouces
* Adjust Types in Endpoint to reference those from Ingest
* Remove un-used endpoint type
paul-tavares added a commit that referenced this pull request Apr 14, 2020
…oint (#63373) (#63497)

* Added REST Response types to datasouces
* Adjust Types in Endpoint to reference those from Ingest
* Remove un-used endpoint type
gmmorris added a commit to gmmorris/kibana that referenced this pull request Apr 15, 2020
* master: (29 commits)
  Add test:jest_integration npm script (elastic#62938)
  [data.search.aggs] Remove service getters from agg types (AggConfig part) (elastic#62548)
  [Discover] Fix broken setting of bucketInterval (elastic#62939)
  Disable adding conditions when in alert management context. (elastic#63514)
  [Alerting] fixes to allow pre-configured actions to be executed (elastic#63432)
  adding useMemo (elastic#63504)
  [Maps] fix double fetch when filter pill is added (elastic#63024)
  [Lens] Fix missing formatting bug in "break down by" (elastic#63288)
  [SIEM] [Cases] Removed double pasted line (elastic#63507)
  [Reporting] Improve functional test steps (elastic#63259)
  [SIEM][CASE] Tests for server's configuration API (elastic#63099)
  [SIEM] [Cases] Case container unit tests (elastic#63376)
  [ML] Improving parsing of large uploaded files (elastic#62970)
  [ML] Listing global calendars on the job management page (elastic#63124)
  [Ingest][Endpoint] Add Ingest rest api response types for use in Endpoint (elastic#63373)
  Add help text to form fields (elastic#63165)
  [ML] Converts utils Mocha tests to Jest (elastic#63132)
  [Metrics UI] Refactor With* containers to hooks (elastic#59503)
  [NP] Migrate logstash server side code to NP (elastic#63135)
  Clicking cancel in saved query save modal doesn't close it (elastic#62774)
  ...
wayneseymour pushed a commit that referenced this pull request Apr 15, 2020
…oint (#63373)

* Added REST Response types to datasouces
* Adjust Types in Endpoint to reference those from Ingest
* Remove un-used endpoint type
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature:Endpoint Elastic Endpoint feature release_note:skip Skip the PR/issue when compiling release notes Team:Fleet Team label for Observability Data Collection Fleet team v7.8.0 v8.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Ingest] Add Types to the REST API response
5 participants