Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Ingest] Add Types to the REST API response #60677

Closed
5 tasks done
paul-tavares opened this issue Mar 19, 2020 · 1 comment · Fixed by #63373
Closed
5 tasks done

[Ingest] Add Types to the REST API response #60677

paul-tavares opened this issue Mar 19, 2020 · 1 comment · Fixed by #63373
Assignees
@paul-tavares
Labels
Feature:EPM Fleet team's Elastic Package Manager (aka Integrations) project Feature:Fleet Fleet team's agent central management project Team:Fleet Team label for Observability Data Collection Fleet team

Comments

@paul-tavares
Copy link
Contributor

paul-tavares commented Mar 19, 2020 •
edited
Loading

Add API response types to the rest_spec so that other plugins can use them when interacting with API endpoints.

Background

A few APIs are missing response Types in x-pack/plugins/ingest_manager/common/types/rest_spec - example: datasources has no response type for getting a list or a single datasource.

TODO

  • datasources:
    • Add GetDatasourcesResponse
    • add GetDatasourceResponse
    • Add UpdateDatasourceResponse (should mirror CreateDatasourceResponse)
    • Expose these from the root of ingest_manager/common
@paul-tavares paul-tavares added Feature:EPM Fleet team's Elastic Package Manager (aka Integrations) project Feature:Fleet Fleet team's agent central management project labels Mar 19, 2020
@paul-tavares paul-tavares self-assigned this Mar 19, 2020
@elasticmachine
Copy link
Contributor

Pinging @elastic/ingest-management (Feature:EPM)

@jen-huang jen-huang added the Team:Fleet Team label for Observability Data Collection Fleet team label Mar 26, 2020
@paul-tavares paul-tavares mentioned this issue Apr 13, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@paul-tavares paul-tavares

Labels
Feature:EPM Fleet team's Elastic Package Manager (aka Integrations) project Feature:Fleet Fleet team's agent central management project Team:Fleet Team label for Observability Data Collection Fleet team
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[Ingest][Endpoint] Add Ingest rest api response types for use in Endpoint paul-tavares/kibana
3 participants
@jen-huang @elasticmachine @paul-tavares