Index pattern management UI -> TypeScript (scripted_fields_table) #63247
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexwizp
added
Feature:Index Management
|
Pinging @elastic/kibana-app-arch (Team:AppArch) |
16 tasks
mattkime
reviewed
Apr 10, 2020
.../sections/index_patterns/edit_index_pattern/scripted_fields_table/components/table/table.tsx
Show resolved
Hide resolved
mattkime
reviewed
Apr 10, 2020
| name: i18n.translate('kbn.management.editIndexPattern.scripted.table.editHeader', { | ||
| defaultMessage: 'Edit', | ||
| }), | ||
| description: i18n.translate( | ||
| 'kbn.management.editIndexPattern.scripted.table.editDescription', | ||
| { defaultMessage: 'Edit this field' } | ||
| ), | ||
| icon: 'pencil', | ||
| // icon: 'pencil', |
There was a problem hiding this comment.
Looks like these need to be reenabled.
There was a problem hiding this comment.
oh.... thank you, forgot about it
|
@elasticmachine merge upstream |
💚 Build SucceededHistory
To update your PR or re-run it, just comment with: |
mattkime
approved these changes
Apr 13, 2020
mattkime
pushed a commit
to mattkime/kibana
that referenced
this pull request
Apr 13, 2020
…astic#63247) * Index pattern management UI -> TypeScript (scripted_fields_table)
alexwizp
added a commit
that referenced
this pull request
Apr 13, 2020
…3247) (#63371) * Index pattern management UI -> TypeScript (scripted_fields_table) Co-authored-by: Alexey Antonov <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #51322
Summary
Part of #51322 (Index pattern management UI -> TypeScript and New Platform Ready)
Checklist
Delete any items that are not applicable to this PR.
For maintainers