fix PR comments

elastic · Apr 13, 2020 · c09e9dc · c09e9dc
1 parent 5f264c9
commit c09e9dc
Show file tree

Hide file tree

Showing 4 changed files with 10 additions and 8 deletions.
diff --git a/...index_patterns/edit_index_pattern/scripted_fields_table/components/header/header.test.tsx b/...index_patterns/edit_index_pattern/scripted_fields_table/components/header/header.test.tsx
@@ -20,7 +20,7 @@
 import React from 'react';
 import { shallow } from 'enzyme';
 
-import { Header } from '../header';
+import { Header } from './header';
 
 describe('Header', () => {
   test('should render normally', () => {

diff --git a/...it_index_pattern/scripted_fields_table/components/table/__snapshots__/table.test.tsx.snap b/...it_index_pattern/scripted_fields_table/components/table/__snapshots__/table.test.tsx.snap
diff --git a/...ctions/index_patterns/edit_index_pattern/scripted_fields_table/components/table/table.tsx b/...ctions/index_patterns/edit_index_pattern/scripted_fields_table/components/table/table.tsx
@@ -98,27 +98,27 @@ export class Table extends PureComponent<TableProps> {
         name: '',
         actions: [
           {
-            type: 'button',
+            type: 'icon',
             name: i18n.translate('kbn.management.editIndexPattern.scripted.table.editHeader', {
               defaultMessage: 'Edit',
             }),
             description: i18n.translate(
               'kbn.management.editIndexPattern.scripted.table.editDescription',
               { defaultMessage: 'Edit this field' }
             ),
-            //  icon: 'pencil',
+            icon: 'pencil',
             onClick: editField,
           },
           {
-            type: 'button',
+            type: 'icon',
             name: i18n.translate('kbn.management.editIndexPattern.scripted.table.deleteHeader', {
               defaultMessage: 'Delete',
             }),
             description: i18n.translate(
               'kbn.management.editIndexPattern.scripted.table.deleteDescription',
               { defaultMessage: 'Delete this field' }
             ),
-            //  icon: 'trash',
+            icon: 'trash',
             color: 'danger',
             onClick: deleteField,
           },

diff --git a/...ections/index_patterns/edit_index_pattern/scripted_fields_table/scripted_fields_table.tsx b/...ections/index_patterns/edit_index_pattern/scripted_fields_table/scripted_fields_table.tsx
@@ -39,7 +39,7 @@ interface ScriptedFieldsTableProps {
     redirectToRoute: Function;
     getRouteHref: Function;
   };
-  onRemoveField?: Function;
+  onRemoveField?: () => void;
 }
 
 interface ScriptedFieldsTableState {