Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[7.7][Discover] Fix flaky suites in _field_visualize #62823

Merged
merged 1 commit into from
Apr 8, 2020

Conversation

sulemanof
Copy link
Contributor

@sulemanof sulemanof commented Apr 7, 2020

Summary

Resolves #61714

This is almost the same as #62418,
but a css selector was changed in clickFieldListItemVisualize :

 const field = await testSubjects.find(`field-${fieldName}`);

because of the discover sidebar was moved to react in 7.x and selectors changed a bit,
so the backport was not suitable : #62547

Checklist

Delete any items that are not applicable to this PR.

For maintainers

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@sulemanof sulemanof requested review from dmlemeshko and nreese April 8, 2020 07:34
@sulemanof sulemanof marked this pull request as ready for review April 8, 2020 07:34
@sulemanof sulemanof added release_note:skip Skip the PR/issue when compiling release notes test-failure-flaky test_ui_functional v7.7.0 labels Apr 8, 2020
Copy link
Contributor

@nreese nreese left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm
code review

Copy link
Member

@dmlemeshko dmlemeshko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code LGTM, tests are passing locally on the latest Firefox and Chrome (MacOS 10.14.6)

@sulemanof sulemanof merged commit cee064b into elastic:7.7 Apr 8, 2020
@sulemanof sulemanof deleted the test/fix_flaky_discover branch April 8, 2020 21:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants