-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Discover] Fix flaky FT in field visualize #62418
Conversation
@elasticmachine merge upstream |
Pinging @elastic/kibana-app (Team:KibanaApp) |
@@ -17,7 +17,6 @@ export default function({ getService, getPageObjects }) { | |||
|
|||
it('should link geo_shape fields to Maps application', async () => { | |||
await PageObjects.discover.selectIndexPattern('geo_shapes*'); | |||
await PageObjects.discover.clickFieldListItem('geometry'); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should this call be replaced with calls to PageObjects.discover.findFieldByName
like in the discover tests?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actually, that's not really necessary (even in discover tests), findFieldByName
only types the field name in the search bar, to make a field to be in top of sidebar.
This was done in first attempt to fix flaky tests, assuming that failing was caused by a field was too low and goes out of visible screen.
Since that time findFieldByName
stayed in tests, don't see a problem with that. @dmlemeshko what are your thoughts?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If these tests are not flaky and do not require pre-search (flaky-test-runner showed 42 times passed), I think we don't need it..
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
maps changes lgtm
code review
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested with FTR, 42 passed 🎉
@elasticmachine merge upstream |
💚 Build SucceededHistory
To update your PR or re-run it, just comment with: |
* Unskip * Set only suite * Add field search * Use alternative flaky fix * Remove extra actions Co-authored-by: Elastic Machine <[email protected]>
* Unskip * Set only suite * Add field search * Use alternative flaky fix * Remove extra actions Co-authored-by: Elastic Machine <[email protected]>
* Unskip * Set only suite * Add field search * Use alternative flaky fix * Remove extra actions Co-authored-by: Elastic Machine <[email protected]> Co-authored-by: Elastic Machine <[email protected]>
…into event-log/query-support * 'event-log/query-support' of github.com:gmmorris/kibana: (41 commits) [jenkins] refer to sizes in most pipeline code (elastic#62082) skip flaky suite (elastic#60470) [Discover] Fix flaky FT in field visualize (elastic#62418) [ML] Data Frame Analytics: Fix feature importance (elastic#61761) [Reporting] Use a shim for server config (elastic#62086) [Reporting] Fix reporting for non-default spaces (elastic#62226) Fix bug that coerced empty scaled float value to 0 (elastic#62251) [SIEM] [Detection Engine] Remove has manage api keys requireme… (elastic#62446) [Maps] Safely handle empty string and invalid strings from EuiColorPicker (elastic#62507) Reporting/bug more blacklisted headers (elastic#62389) [SIEM] Prevent undefined behavior in our ML popover (elastic#62498) [SIEM] [Detection Engine] remove all unknowns from all rules t… (elastic#62327) base changes for active/current node styling (elastic#62007) [kbn/ui-shared-deps] expand and split (elastic#62364) [ML] DF Analytics - ensure destination index pattern created (elastic#62450) Mark rule run as failure if there was an error (elastic#62383) Add docs for metric explorer alerts (elastic#62314) skip flaky suite (elastic#62281) [SIEM][Detection Engine] Fixes export of single rule and the icons fixes flakiness (elastic#62406) ...
Summary
Fixes #61714
The fix is based on making sure the selected field is in expanded state.
So the
clickFieldListItemVisualize
checks if the field is not collapsed before clicking theVisualize
button and click if it is.Seems a failure was caused when field was collapsed and the "visualize" couldn't be clicked. A field could be collapsed by an extra click somewhere else on the page, including the selected field.
The
findFieldByName
was added for search for a field in the sidebar.Checklist
Delete any items that are not applicable to this PR.
For maintainers