Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Discover] Fix flaky FT in field visualize #62418

Merged
merged 8 commits into from
Apr 4, 2020

Conversation

sulemanof
Copy link
Contributor

@sulemanof sulemanof commented Apr 3, 2020

Summary

Fixes #61714

The fix is based on making sure the selected field is in expanded state.
So the clickFieldListItemVisualize checks if the field is not collapsed before clicking the Visualize button and click if it is.

Seems a failure was caused when field was collapsed and the "visualize" couldn't be clicked. A field could be collapsed by an extra click somewhere else on the page, including the selected field.

The findFieldByName was added for search for a field in the sidebar.

Checklist

Delete any items that are not applicable to this PR.

For maintainers

@sulemanof
Copy link
Contributor Author

@elasticmachine merge upstream

@sulemanof sulemanof requested review from dmlemeshko and kertal April 3, 2020 15:25
@sulemanof sulemanof added release_note:skip Skip the PR/issue when compiling release notes Team:Visualizations Visualization editors, elastic-charts and infrastructure test_ui_functional v7.7.0 v7.8 v8.0.0 labels Apr 3, 2020
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-app (Team:KibanaApp)

@sulemanof sulemanof marked this pull request as ready for review April 3, 2020 15:26
@sulemanof sulemanof requested a review from a team as a code owner April 3, 2020 15:26
@@ -17,7 +17,6 @@ export default function({ getService, getPageObjects }) {

it('should link geo_shape fields to Maps application', async () => {
await PageObjects.discover.selectIndexPattern('geo_shapes*');
await PageObjects.discover.clickFieldListItem('geometry');
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this call be replaced with calls to PageObjects.discover.findFieldByName like in the discover tests?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually, that's not really necessary (even in discover tests), findFieldByName only types the field name in the search bar, to make a field to be in top of sidebar.
This was done in first attempt to fix flaky tests, assuming that failing was caused by a field was too low and goes out of visible screen.
Since that time findFieldByName stayed in tests, don't see a problem with that. @dmlemeshko what are your thoughts?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If these tests are not flaky and do not require pre-search (flaky-test-runner showed 42 times passed), I think we don't need it..

Copy link
Contributor

@nreese nreese left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maps changes lgtm
code review

Copy link
Member

@dmlemeshko dmlemeshko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested with FTR, 42 passed 🎉

@dmlemeshko
Copy link
Member

@elasticmachine merge upstream

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@sulemanof sulemanof merged commit 5696f62 into elastic:master Apr 4, 2020
@sulemanof sulemanof deleted the test/flaky_field_discover branch April 4, 2020 14:05
sulemanof added a commit to sulemanof/kibana that referenced this pull request Apr 4, 2020
* Unskip

* Set only suite

* Add field search

* Use alternative flaky fix

* Remove extra actions

Co-authored-by: Elastic Machine <[email protected]>
sulemanof added a commit to sulemanof/kibana that referenced this pull request Apr 4, 2020
* Unskip

* Set only suite

* Add field search

* Use alternative flaky fix

* Remove extra actions

Co-authored-by: Elastic Machine <[email protected]>
@sulemanof sulemanof removed the v7.7.0 label Apr 4, 2020
sulemanof added a commit that referenced this pull request Apr 4, 2020
* Unskip

* Set only suite

* Add field search

* Use alternative flaky fix

* Remove extra actions

Co-authored-by: Elastic Machine <[email protected]>

Co-authored-by: Elastic Machine <[email protected]>
@kertal kertal added v7.8.0 and removed v7.8 labels Apr 6, 2020
gmmorris added a commit to gmmorris/kibana that referenced this pull request Apr 6, 2020
…into event-log/query-support

* 'event-log/query-support' of github.com:gmmorris/kibana: (41 commits)
  [jenkins] refer to sizes in most pipeline code (elastic#62082)
  skip flaky suite (elastic#60470)
  [Discover] Fix flaky FT in field visualize (elastic#62418)
  [ML] Data Frame Analytics: Fix feature importance (elastic#61761)
  [Reporting] Use a shim for server config (elastic#62086)
  [Reporting] Fix reporting for non-default spaces (elastic#62226)
  Fix bug that coerced empty scaled float value to 0 (elastic#62251)
  [SIEM] [Detection Engine] Remove has manage api keys requireme… (elastic#62446)
  [Maps] Safely handle empty string and invalid strings from EuiColorPicker (elastic#62507)
  Reporting/bug more blacklisted headers (elastic#62389)
  [SIEM] Prevent undefined behavior in our ML popover (elastic#62498)
  [SIEM] [Detection Engine] remove all unknowns from all rules t… (elastic#62327)
  base changes for active/current node styling (elastic#62007)
  [kbn/ui-shared-deps] expand and split (elastic#62364)
  [ML] DF Analytics - ensure destination index pattern created (elastic#62450)
  Mark rule run as failure if there was an error (elastic#62383)
  Add docs for metric explorer alerts (elastic#62314)
  skip flaky suite (elastic#62281)
  [SIEM][Detection Engine] Fixes export of single rule and the icons
  fixes flakiness (elastic#62406)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release_note:skip Skip the PR/issue when compiling release notes Team:Visualizations Visualization editors, elastic-charts and infrastructure test_ui_functional v7.8.0 v8.0.0
Projects
None yet
6 participants