[Watcher] Preserve the watch active status after updates #61999
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jloleysens
added
v7.0.0
Feature:Watcher
v8.0.0
Team:Kibana Management
|
Pinging @elastic/es-ui (Team:Elasticsearch UI) |
cjcenizal
suggested changes
Apr 1, 2020
x-pack/plugins/watcher/public/application/models/watch/threshold_watch.js
Outdated
Show resolved
Hide resolved
| @@ -21,23 +20,11 @@ const bodySchema = schema.object( | |||
| { | |||
| type: schema.string(), | |||
| isNew: schema.boolean(), | |||
| isActive: schema.boolean({ defaultValue: true }), | |||
There was a problem hiding this comment.
I'm not sure a default value makes sense here. I think it would make the code clearer if we required the client to define active status, even for defaults. WDYT?
There was a problem hiding this comment.
I was using this as a guide https://www.elastic.co/guide/en/elasticsearch/reference/current/watcher-api-put-watch.html#watcher-api-put-watch-query-params. I don't feel too strongly about it either way, but if we consider that our endpoint is already a bit different we can require the active flag 👍
There was a problem hiding this comment.
Hmm I see. My instinct is to optimize the API for our UI's use cases and not place emphasis on mirroring the ES API. So is the default value useful to the client? Just some thoughts, I think you should make the final call.
- Make the isActive flag required on the save watch endpoint - Move the isActive state to base_watch and serialize from there.
|
@elasticmachine merge upstream |
|
@elasticmachine merge upstream |
cjcenizal
approved these changes
Apr 9, 2020
💚 Build SucceededHistory
To update your PR or re-run it, just comment with: |
jloleysens
added a commit
to jloleysens/kibana
that referenced
this pull request
Apr 10, 2020
* Preserve the watch active status after updates * Use route validation params to set isActive * Fix Jest test * Implement PR feedback - Make the isActive flag required on the save watch endpoint - Move the isActive state to base_watch and serialize from there. * Fix Jest tests Co-authored-by: Elastic Machine <[email protected]>
jloleysens
added a commit
to jloleysens/kibana
that referenced
this pull request
Apr 10, 2020
* Preserve the watch active status after updates * Use route validation params to set isActive * Fix Jest test * Implement PR feedback - Make the isActive flag required on the save watch endpoint - Move the isActive state to base_watch and serialize from there. * Fix Jest tests Co-authored-by: Elastic Machine <[email protected]>
jloleysens
added a commit
that referenced
this pull request
Apr 10, 2020
…3232) * Preserve the watch active status after updates * Use route validation params to set isActive * Fix Jest test * Implement PR feedback - Make the isActive flag required on the save watch endpoint - Move the isActive state to base_watch and serialize from there. * Fix Jest tests Co-authored-by: Elastic Machine <[email protected]> Co-authored-by: Elastic Machine <[email protected]>
jloleysens
added a commit
that referenced
this pull request
Apr 10, 2020
…3231) * Preserve the watch active status after updates * Use route validation params to set isActive * Fix Jest test * Implement PR feedback - Make the isActive flag required on the save watch endpoint - Move the isActive state to base_watch and serialize from there. * Fix Jest tests Co-authored-by: Elastic Machine <[email protected]> Co-authored-by: Elastic Machine <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fix #61783
Checklist
For maintainers