Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Endpoint] Update host field accordion #61878

Merged
merged 4 commits into from
Apr 2, 2020
Merged

[Endpoint] Update host field accordion #61878

merged 4 commits into from
Apr 2, 2020

Conversation

dplumlee
Copy link
Contributor

@dplumlee dplumlee commented Mar 30, 2020 •
edited
Loading

Summary

Adds fields to display current host info for alerts to its respective accordion in the alert details flyout. Also adds a version of the host esarchive to the alerts folder for use in tests that utilize both data sets.

Screen Shot 2020-04-02 at 2 25 17 AM

Checklist

Delete any items that are not applicable to this PR.

For maintainers

@dplumlee dplumlee force-pushed the update-host-fields branch from 1767484 to d9bc562 Compare March 30, 2020 18:44
@dplumlee dplumlee added Feature:Endpoint Elastic Endpoint feature release_note:skip Skip the PR/issue when compiling release notes Team:Endpoint Response Endpoint Response Team v7.8.0 v8.0.0 labels Apr 2, 2020
@elasticmachine
Copy link
Contributor

Pinging @elastic/endpoint-app-team (Feature:Endpoint)

@elasticmachine
Copy link
Contributor

Pinging @elastic/endpoint-response (Team:Endpoint Response)

@dplumlee dplumlee marked this pull request as ready for review April 2, 2020 06:29
@dplumlee dplumlee requested a review from a team as a code owner April 2, 2020 06:29
@dplumlee dplumlee force-pushed the update-host-fields branch from e0f98f0 to 1f78123 Compare April 2, 2020 06:31
@kibanamachine
Copy link
Contributor

💚 Build Succeeded

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@dplumlee dplumlee merged commit 6d8bdf6 into elastic:master Apr 2, 2020
@dplumlee dplumlee deleted the update-host-fields branch April 2, 2020 18:59
gmmorris added a commit to gmmorris/kibana that referenced this pull request Apr 3, 2020
@gmmorris
Merge branch 'master' into event-log/query-support
a492453 
* master:
  [Drilldowns] Dashboard state fixes for drilldowns (elastic#61457)
  allow null for filterQuery (elastic#62310)
  [ML] call job validation endpoint with complete payload (elastic#62331)
  removing configuration from agents (elastic#62290)
  Allow Enterprise license for service map (elastic#62371)
  docs: updates to apm agent config (elastic#61893)
  [Ingest] Fix package info request returning 500 (elastic#61712)
  move crypto to server utils (elastic#62344)
  Start indexing documents by default (elastic#62159)
  [Endpoint] Update host field accordion (elastic#61878)
  Add more definitions about Ingest Management (elastic#62049)
@kibanamachine
Copy link
Contributor

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create backports run node scripts/backport --pr 61878 or prevent reminders by adding the backport:skip label.

@kibanamachine kibanamachine added the backport missing Added to PRs automatically when the are determined to be missing a backport. label Apr 6, 2020
@dplumlee dplumlee mentioned this pull request Apr 6, 2020
Closed
@kibanamachine
Copy link
Contributor

Looks like this PR has a backport PR but it still hasn't been merged. Please merge it ASAP to keep the branches relatively in sync.

3 similar comments
@kibanamachine
Copy link
Contributor

Looks like this PR has a backport PR but it still hasn't been merged. Please merge it ASAP to keep the branches relatively in sync.

@kibanamachine
Copy link
Contributor

Looks like this PR has a backport PR but it still hasn't been merged. Please merge it ASAP to keep the branches relatively in sync.

@kibanamachine
Copy link
Contributor

Looks like this PR has a backport PR but it still hasn't been merged. Please merge it ASAP to keep the branches relatively in sync.

@dplumlee dplumlee mentioned this pull request Apr 13, 2020
Merged
@kibanamachine kibanamachine removed the backport missing Added to PRs automatically when the are determined to be missing a backport. label Apr 13, 2020
dplumlee added a commit that referenced this pull request Apr 13, 2020
@dplumlee
[7.x] [Endpoint] Update host field accordion (#61878) (#63410)
9987c9e
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@peluja1012 peluja1012 peluja1012 approved these changes

@oatkiller oatkiller oatkiller approved these changes

Assignees
No one assigned
Labels
Feature:Endpoint Elastic Endpoint feature release_note:skip Skip the PR/issue when compiling release notes Team:Endpoint Response Endpoint Response Team v7.8.0 v8.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@dplumlee @elasticmachine @kibanamachine @oatkiller @peluja1012