Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Ingest] Fix package info request returning 500 #61712

Merged
merged 3 commits into from
Apr 2, 2020

Conversation

jen-huang
Copy link
Contributor

Summary

Resolves #61631 where a package info request was sent without a proper package key string, resulting in a 500 error response.

I also noticed that the Installed packages tab was loading indefinitely because no installed packages were detected so fixed that as well. (As we always install the system package by default, this state wouldn't come up normally, but currently installed packages are not found properly due to #61679.)

@jen-huang jen-huang added bug Fixes for quality problems that affect the customer experience release_note:skip Skip the PR/issue when compiling release notes Feature:EPM Fleet team's Elastic Package Manager (aka Integrations) project v7.8.0 Team:Fleet Team label for Observability Data Collection Fleet team labels Mar 27, 2020
@jen-huang jen-huang requested a review from a team March 27, 2020 23:58
@jen-huang jen-huang self-assigned this Mar 27, 2020
@elasticmachine
Copy link
Contributor

Pinging @elastic/ingest-management (Feature:EPM)

@jfsiii
Copy link
Contributor

jfsiii commented Apr 2, 2020

@elasticmachine merge upstream

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@jfsiii jfsiii merged commit 2ae566e into elastic:master Apr 2, 2020
gmmorris added a commit to gmmorris/kibana that referenced this pull request Apr 3, 2020
* master:
  [Drilldowns] Dashboard state fixes for drilldowns (elastic#61457)
  allow null for filterQuery (elastic#62310)
  [ML] call job validation endpoint with complete payload (elastic#62331)
  removing configuration from agents (elastic#62290)
  Allow Enterprise license for service map (elastic#62371)
  docs: updates to apm agent config (elastic#61893)
  [Ingest] Fix package info request returning 500 (elastic#61712)
  move crypto to server utils (elastic#62344)
  Start indexing documents by default (elastic#62159)
  [Endpoint] Update host field accordion (elastic#61878)
  Add more definitions about Ingest Management (elastic#62049)
@kibanamachine
Copy link
Contributor

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create backports run node scripts/backport --pr 61712 or prevent reminders by adding the backport:skip label.

@kibanamachine kibanamachine added the backport missing Added to PRs automatically when the are determined to be missing a backport. label Apr 6, 2020
@jen-huang jen-huang deleted the ingest/fix/500-pkginfo branch April 7, 2020 18:21
jen-huang added a commit to jen-huang/kibana that referenced this pull request Apr 7, 2020
* Fix 500 package info request error

* Fix installed packages page not loading

Co-authored-by: Elastic Machine <[email protected]>
jen-huang added a commit that referenced this pull request Apr 7, 2020
* Fix 500 package info request error

* Fix installed packages page not loading

Co-authored-by: Elastic Machine <[email protected]>

Co-authored-by: Elastic Machine <[email protected]>
@kibanamachine kibanamachine removed the backport missing Added to PRs automatically when the are determined to be missing a backport. label Apr 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Fixes for quality problems that affect the customer experience Feature:EPM Fleet team's Elastic Package Manager (aka Integrations) project release_note:skip Skip the PR/issue when compiling release notes Team:Fleet Team label for Observability Data Collection Fleet team v7.8.0 v8.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[EPM] Bad requests when clicking "create data source"
5 participants