Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Maps] clean-up unsaved state check #61705

Merged
merged 9 commits into from
Mar 30, 2020
Merged

[Maps] clean-up unsaved state check #61705

merged 9 commits into from
Mar 30, 2020

Conversation

nreese
Copy link
Contributor

@nreese nreese commented Mar 27, 2020 •
edited
Loading

trying #61535 again.

#61705 (comment)

I have located the cause of the failing test. I am not sure how the tests passed at all in the initial PR. The changes displayed a leave warning on a new map with no changes because JSON.parse(JSON.stringify()) to a layer list that had not had this operation. This was causing the full_screen_mode functional test to fail. I updated the logic to only JSON.parse(JSON.stringify()) layerListConfigOnly when comparing the layerList against savedLayerList

@nreese nreese requested a review from a team as a code owner March 27, 2020 21:41
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-gis (Team:Geo)

@nreese
Copy link
Contributor Author

nreese commented Mar 30, 2020

@elasticmachine merge upstream

@nreese
Copy link
Contributor Author

nreese commented Mar 30, 2020 •
edited
Loading

I have located the cause of the failing test. I am not sure how the tests passed at all in the initial PR. The changes displayed a leave warning on a new map with no changes because JSON.parse(JSON.stringify()) to a layer list that had not had this operation. This was causing the full_screen_mode functional test was fail. I updated the logic to only JSON.parse(JSON.stringify()) layerListConfigOnly when comparing the layerList against savedLayerList

@nreese nreese requested a review from thomasneirynck March 30, 2020 14:44
thomasneirynck
thomasneirynck approved these changes Mar 30, 2020
View reviewed changes
Copy link
Contributor

@thomasneirynck thomasneirynck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

eep, thx for picking up again

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@nreese nreese merged commit 0070bdc into elastic:master Mar 30, 2020
@nreese nreese mentioned this pull request Mar 30, 2020
Merged
nreese added a commit to nreese/kibana that referenced this pull request Mar 30, 2020
@nreese @elasticmachine
[Maps] clean-up unsaved state check (elastic#61705)
162b733 
* [Maps] clean-up unsaved state check (elastic#61535)

* close layer panel in functional test

* skip vector styling test

* skip saved object management test

* skip all of group 7 tests

* turn back on group 7, skip full screen

* turn on all tests except full screen

* unskip all tests and resolve root problem

Co-authored-by: Elastic Machine <[email protected]>
nreese added a commit to nreese/kibana that referenced this pull request Mar 30, 2020
@nreese @elasticmachine
[Maps] clean-up unsaved state check (elastic#61705)
423cb13 
* [Maps] clean-up unsaved state check (elastic#61535)

* close layer panel in functional test

* skip vector styling test

* skip saved object management test

* skip all of group 7 tests

* turn back on group 7, skip full screen

* turn on all tests except full screen

* unskip all tests and resolve root problem

Co-authored-by: Elastic Machine <[email protected]>
@nreese nreese mentioned this pull request Mar 30, 2020
Merged
nreese added a commit that referenced this pull request Mar 30, 2020
@nreese @elasticmachine
[Maps] clean-up unsaved state check (#61705) (#61859)
62f6cc5 
* [Maps] clean-up unsaved state check (#61535)

* close layer panel in functional test

* skip vector styling test

* skip saved object management test

* skip all of group 7 tests

* turn back on group 7, skip full screen

* turn on all tests except full screen

* unskip all tests and resolve root problem

Co-authored-by: Elastic Machine <[email protected]>

Co-authored-by: Elastic Machine <[email protected]>
nreese added a commit that referenced this pull request Mar 30, 2020
@nreese @elasticmachine
[Maps] clean-up unsaved state check (#61705) (#61858)
fab0b8f 
* [Maps] clean-up unsaved state check (#61535)

* close layer panel in functional test

* skip vector styling test

* skip saved object management test

* skip all of group 7 tests

* turn back on group 7, skip full screen

* turn on all tests except full screen

* unskip all tests and resolve root problem

Co-authored-by: Elastic Machine <[email protected]>

Co-authored-by: Elastic Machine <[email protected]>
@spalger spalger mentioned this pull request Mar 31, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thomasneirynck thomasneirynck thomasneirynck approved these changes

Assignees
No one assigned
Labels
[Deprecated-Use Team:Presentation]Team:Geo Former Team Label for Geo Team. Now use Team:Presentation release_note:fix v7.7.0 v7.8.0 v8.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@nreese @elasticmachine @kibanamachine @thomasneirynck