[Maps] clean-up unsaved state check #61535
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nreese
added
release_note:fix
[Deprecated-Use Team:Presentation]Team:Geo
|
Pinging @elastic/kibana-gis (Team:Geo) |
💚 Build SucceededTo update your PR or re-run it, just comment with: |
kindsun
approved these changes
Mar 27, 2020
nreese
added a commit
to nreese/kibana
that referenced
this pull request
Mar 27, 2020
nreese
added a commit
to nreese/kibana
that referenced
this pull request
Mar 27, 2020
nreese
added a commit
that referenced
this pull request
Mar 27, 2020
spalger
added a commit
that referenced
this pull request
Mar 27, 2020
|
Reverted as it seems this started causing an alert dialog to be open on master, breaking the functional tests that follow it. It's unclear, but it seems the that there might be an unexpected relationship between this change and #61386 Reverted the 7.x backport as well, @nreese is working on resubmitting this. |
nreese
added a commit
to nreese/kibana
that referenced
this pull request
Mar 27, 2020
nreese
added a commit
that referenced
this pull request
Mar 30, 2020
* [Maps] clean-up unsaved state check (#61535) * close layer panel in functional test * skip vector styling test * skip saved object management test * skip all of group 7 tests * turn back on group 7, skip full screen * turn on all tests except full screen * unskip all tests and resolve root problem Co-authored-by: Elastic Machine <[email protected]>
nreese
added a commit
to nreese/kibana
that referenced
this pull request
Mar 30, 2020
* [Maps] clean-up unsaved state check (elastic#61535) * close layer panel in functional test * skip vector styling test * skip saved object management test * skip all of group 7 tests * turn back on group 7, skip full screen * turn on all tests except full screen * unskip all tests and resolve root problem Co-authored-by: Elastic Machine <[email protected]>
nreese
added a commit
to nreese/kibana
that referenced
this pull request
Mar 30, 2020
* [Maps] clean-up unsaved state check (elastic#61535) * close layer panel in functional test * skip vector styling test * skip saved object management test * skip all of group 7 tests * turn back on group 7, skip full screen * turn on all tests except full screen * unskip all tests and resolve root problem Co-authored-by: Elastic Machine <[email protected]>
nreese
added a commit
that referenced
this pull request
Mar 30, 2020
* [Maps] clean-up unsaved state check (#61535) * close layer panel in functional test * skip vector styling test * skip saved object management test * skip all of group 7 tests * turn back on group 7, skip full screen * turn on all tests except full screen * unskip all tests and resolve root problem Co-authored-by: Elastic Machine <[email protected]> Co-authored-by: Elastic Machine <[email protected]>
nreese
added a commit
that referenced
this pull request
Mar 30, 2020
* [Maps] clean-up unsaved state check (#61535) * close layer panel in functional test * skip vector styling test * skip saved object management test * skip all of group 7 tests * turn back on group 7, skip full screen * turn on all tests except full screen * unskip all tests and resolve root problem Co-authored-by: Elastic Machine <[email protected]> Co-authored-by: Elastic Machine <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is a bug in unsaved state check in the Map application. Follow the steps below to view the bug.
fill colorto use by value styling for any field.Mapsin the top nav to go to the maps list.The problem is cause by changes of behavior from categorical styling refactors. Those changes exposed an existing bug in unsaved state check.
Categorical styling changed
DynamicColorFormonChange handler to set bothcustomColorRampandcolorproperties. Yet, eithercustomColorRamporcoloris provided when the handler is called so the state contained one of them set to undefined.This behavior change exposed an existing bug in the unsaved state check. The unsaved state check compared the current state to state that had been stringified and re-parsed. The problem is that JSON.stringify removes object keys with undefined values so when the stringified and re-parsed version were compared to the current state, they looked different even though they were the same.
This PR resolves both problems. It avoids setting undefined when
customColorRamporcoloris not provided . The PR also sends the current state through the JSON.stringify and JSON.parse ringer so the comparison is comparing the same things.