-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Canvas] Switch to using EUI SuperDatePicker in time filter element #59249
Conversation
}; | ||
|
||
TimeFilter.propTypes = { | ||
filter: PropTypes.string.isRequired, | ||
commit: PropTypes.func.isRequired, // Canvas filter | ||
compact: PropTypes.bool, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
EuiSuperDatePicker
is only available in a "compact" view, and there is no "expanded" option, so it makes sense to remove compact
as an argument from the timeFilterControl
function. By deprecating the compact
argument, should this go into 8.0.0 only due to this breaking change?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm leaving the compact
arg on the function def for timefilterControl
so existing workpads using the compact
arg won't start breaking.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe double check with @KOTungseth but I think we can change the release note to not be breaking since this will degrade gracefully
Pinging @elastic/kibana-canvas (Team:Canvas) |
e8b2369
to
dc53795
Compare
...anvas/canvas_plugin_src/renderers/time_filter/components/pretty_duration/lib/quick_ranges.ts
Show resolved
Hide resolved
3b26f4f
to
ca9f4a8
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM from design side
New timepicker is slick! Looks good to go + @crob611 comment about element image being wrong |
…filter/super-date-picker
This reverts commit e3b8bd7.
Looks like this PR has a backport PR but it still hasn't been merged. Please merge it ASAP to keep the branches relatively in sync. |
2 similar comments
Looks like this PR has a backport PR but it still hasn't been merged. Please merge it ASAP to keep the branches relatively in sync. |
Looks like this PR has a backport PR but it still hasn't been merged. Please merge it ASAP to keep the branches relatively in sync. |
💔 Build FailedTest FailuresKibana Pipeline / kibana-oss-agent / Chrome UI Functional Tests.test/functional/apps/discover/_discover_histogram·js.discover app discover histogram should visualize monthly data with different day intervalsStandard Out
Stack Trace
Kibana Pipeline / kibana-oss-agent / Chrome UI Functional Tests.test/functional/apps/visualize/_area_chart·js.visualize app area charts axis scaling does not scale top hit aggStandard Out
Stack Trace
Kibana Pipeline / kibana-oss-agent / Chrome UI Functional Tests.test/functional/apps/visualize/_area_chart·js.visualize app area charts axis scaling does not scale top hit aggStandard Out
Stack Trace
History
To update your PR or re-run it, just comment with: |
Summary
Related to #35308.
Closes #35305.
Closes #35307.
Closes #39008.
Closes #41055.
Closes #48239.
Closes #52672.
This replaces all of our custom time picker components in Canvas with the EUI SuperDatePicker component. The quick time ranges can be configured in the Kibana advanced settings.
Changes:
TimeFilter
componenttimefilter
renderer sub-components and their storiesremoved(I'm leaving the argument for now to prevent existing workpads from breaking)compact
argument fromtimefilterControl
functionChecklist
Delete any items that are not applicable to this PR.
For maintainers