Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add dynamic property to type definition #58852

Merged
merged 1 commit into from
Feb 28, 2020
Merged

add dynamic property to type definition #58852

merged 1 commit into from
Feb 28, 2020

Conversation

pgayvallet
Copy link
Contributor

Summary

Fix #58783

Add the dynamic property to SavedObjectsTypeMappingDefinition. It was already used if present, just not declared in the type definition.

Checklist

@pgayvallet pgayvallet added Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc Feature:New Platform v8.0.0 release_note:skip Skip the PR/issue when compiling release notes v7.7.0 labels Feb 28, 2020
@pgayvallet pgayvallet requested a review from a team as a code owner February 28, 2020 09:37
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-platform (Team:Platform)

rudolf
rudolf approved these changes Feb 28, 2020
View reviewed changes
Copy link
Contributor

@rudolf rudolf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Es accepts dynamic: true as well, but I can't think of a good use case for that, so I think we can rather wait till someone requests it.

@pgayvallet
Copy link
Contributor Author

Es accepts dynamic: true as well, but I can't think of a good use case for that, so I think we can rather wait till someone requests it.

Yea, it was josh's suggestion to forbid this value, as this is something we probably don't want to allow.

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@pgayvallet pgayvallet merged commit 2b9dc43 into elastic:master Feb 28, 2020
pgayvallet added a commit to pgayvallet/kibana that referenced this pull request Feb 28, 2020
@pgayvallet
add dynamic property to type definition (elastic#58852)
fd53965
@pgayvallet pgayvallet mentioned this pull request Feb 28, 2020
Merged
pgayvallet added a commit that referenced this pull request Feb 28, 2020
@pgayvallet
add dynamic property to type definition (#58852) (#58886)
30fca56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rudolf rudolf rudolf approved these changes

Assignees
No one assigned
Labels
Feature:New Platform release_note:skip Skip the PR/issue when compiling release notes Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc v7.7.0 v8.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

SavedObjectsTypeMappingDefinition should support the dynamic option
4 participants
@pgayvallet @elasticmachine @kibanamachine @rudolf