Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SavedObjectsTypeMappingDefinition should support the dynamic option #58783

Closed
joshdover opened this issue Feb 27, 2020 · 2 comments · Fixed by #58852
Closed

SavedObjectsTypeMappingDefinition should support the dynamic option #58783

joshdover opened this issue Feb 27, 2020 · 2 comments · Fixed by #58852
Assignees
Labels
Feature:New Platform Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc

Comments

@joshdover
Copy link
Contributor

We should allow the new saved objects mappings API added in (#57430) to utilize the dynamic option in order to have fields that are not indexed by Elasticsearch.

This should probably only be allowed to be false | 'strict' so we don't introduce unexpected index fields.

@joshdover joshdover added Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc Feature:New Platform labels Feb 27, 2020
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-platform (Team:Platform)

@pgayvallet pgayvallet self-assigned this Feb 28, 2020
@pgayvallet
Copy link
Contributor

Example of type using it: x-pack/legacy/plugins/canvas/server/mappings.ts

export const mappings = {
[CANVAS_TYPE]: {
dynamic: false,
properties: {
name: {
type: 'text',
fields: {
keyword: {
type: 'keyword',
},
},
},
'@timestamp': { type: 'date' },
'@created': { type: 'date' },
},
},

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature:New Platform Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants