[Dashboard] Show empty screen with error message if no permissions #58584
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
majagrubic
added
v8.0.0
v7.7.0
Feature:Dashboard
|
Pinging @elastic/kibana-app (Team:KibanaApp) |
majagrubic
changed the title
majagrubic
changed the title
myasonik
approved these changes
Feb 26, 2020
| !getShouldShowEditHelp() && | ||
| !getShouldShowViewHelp() && | ||
| dashboardConfig.getHideWriteControls(); | ||
| const getIsEmptyInReadonlyModeOrUserHasNoPermissions = () => { |
There was a problem hiding this comment.
This method name is getting long enough that it's difficult to read...
Would changing it to something like shouldShowErrorMessage() be an accurate alternative?
There was a problem hiding this comment.
Hm, it's not an error state though, it's a valid state, somewhat edge-casey, but still valid.
There was a problem hiding this comment.
Maybe shouldShowUnauthorizedEmptyState?
Also, not really critical to make this change if you like longer function names 🤷♂
|
@elasticmachine merge upstream |
💚 Build SucceededHistory
To update your PR or re-run it, just comment with: |
majagrubic
pushed a commit
that referenced
this pull request
Feb 28, 2020
…58584) (#58761) * Show empty screen with error message if no permissions * Renaming function Co-authored-by: Elastic Machine <[email protected]> Co-authored-by: Elastic Machine <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fix for: #55118.
If the user has only permissions to create the dashboard but not the visualizations, the new empty panel is confusing. This PR hides the panel if user doesn't have permissions and shows an existing empty screen:
Checklist
Delete any items that are not applicable to this PR.
- [ ] Any text added follows EUI's writing guidelines, uses sentence case text and includes i18n support- [ ] Documentation was added for features that require explanation or tutorials- [ ] Unit or functional tests were updated or added to match the most common scenarios- [ ] This was checked for keyboard-only and screenreader accessibilityFor maintainers