Show empty screen with error message if no permissions

elastic · Feb 26, 2020 · f20a936 · f20a936
1 parent 10bf90f
commit f20a936
Show file tree

Hide file tree

Showing 3 changed files with 23 additions and 8 deletions.
diff --git a/src/legacy/core_plugins/kibana/public/dashboard/np_ready/application.ts b/src/legacy/core_plugins/kibana/public/dashboard/np_ready/application.ts
@@ -57,6 +57,10 @@ export interface RenderDeps {
   savedDashboards: SavedObjectLoader;
   dashboardConfig: KibanaLegacyStart['dashboardConfig'];
   dashboardCapabilities: any;
+  embeddableCapabilities: {
+    visualizeCapabilities: any;
+    mapsCapabilities: any;
+  };
   uiSettings: IUiSettingsClient;
   chrome: ChromeStart;
   addBasePath: (path: string) => string;

diff --git a/src/legacy/core_plugins/kibana/public/dashboard/np_ready/dashboard_app_controller.tsx b/src/legacy/core_plugins/kibana/public/dashboard/np_ready/dashboard_app_controller.tsx
@@ -108,6 +108,7 @@ export class DashboardAppController {
     embeddable,
     share,
     dashboardCapabilities,
+    embeddableCapabilities: { visualizeCapabilities, mapsCapabilities },
     data: { query: queryService },
     core: {
       notifications,
@@ -134,7 +135,6 @@ export class DashboardAppController {
     } = syncQuery(queryService, kbnUrlStateStorage);
 
     let lastReloadRequestTime = 0;
-
     const dash = ($scope.dash = $route.current.locals.dash);
     if (dash.id) {
       chrome.docTitle.change(dash.title);
@@ -171,11 +171,18 @@ export class DashboardAppController {
       dashboardStateManager.getIsViewMode() &&
       !dashboardConfig.getHideWriteControls();
 
-    const getIsEmptyInReadonlyMode = () =>
-      !dashboardStateManager.getPanels().length &&
-      !getShouldShowEditHelp() &&
-      !getShouldShowViewHelp() &&
-      dashboardConfig.getHideWriteControls();
+    const getIsEmptyInReadonlyModeOrUserHasNoPermissions = () => {
+      const readonlyMode =
+        !dashboardStateManager.getPanels().length &&
+        !getShouldShowEditHelp() &&
+        !getShouldShowViewHelp() &&
+        dashboardConfig.getHideWriteControls();
+      const userHasNoPermissions =
+        !dashboardStateManager.getPanels().length &&
+        !visualizeCapabilities.save &&
+        !mapsCapabilities.save;
+      return readonlyMode || userHasNoPermissions;
+    };
 
     const addVisualization = () => {
       navActions[TopNavIds.VISUALIZE]();
@@ -241,7 +248,7 @@ export class DashboardAppController {
       }
       const shouldShowEditHelp = getShouldShowEditHelp();
       const shouldShowViewHelp = getShouldShowViewHelp();
-      const isEmptyInReadonlyMode = getIsEmptyInReadonlyMode();
+      const isEmptyInReadonlyMode = getIsEmptyInReadonlyModeOrUserHasNoPermissions();
       return {
         id: dashboardStateManager.savedDashboard.id || '',
         filters: queryFilter.getFilters(),
@@ -298,7 +305,7 @@ export class DashboardAppController {
           dashboardContainer.renderEmpty = () => {
             const shouldShowEditHelp = getShouldShowEditHelp();
             const shouldShowViewHelp = getShouldShowViewHelp();
-            const isEmptyInReadOnlyMode = getIsEmptyInReadonlyMode();
+            const isEmptyInReadOnlyMode = getIsEmptyInReadonlyModeOrUserHasNoPermissions();
             const isEmptyState = shouldShowEditHelp || shouldShowViewHelp || isEmptyInReadOnlyMode;
             return isEmptyState ? (
               <DashboardEmptyScreen

diff --git a/src/legacy/core_plugins/kibana/public/dashboard/plugin.ts b/src/legacy/core_plugins/kibana/public/dashboard/plugin.ts
@@ -145,6 +145,10 @@ export class DashboardPlugin implements Plugin {
           savedQueryService: dataStart.query.savedQueries,
           embeddable,
           dashboardCapabilities: coreStart.application.capabilities.dashboard,
+          embeddableCapabilities: {
+            visualizeCapabilities: coreStart.application.capabilities.visualize,
+            mapsCapabilities: coreStart.application.capabilities.maps,
+          },
           localStorage: new Storage(localStorage),
         };
         const { renderApp } = await import('./np_ready/application');