Add <FormCreateDrilldown> component #58335
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
streamich
added
Feature:Drilldowns
|
Pinging @elastic/kibana-app-arch (Team:AppArch) |
💚 Build SucceededHistory
To update your PR or re-run it, just comment with: |
mattkime
approved these changes
Feb 25, 2020
streamich
added a commit
that referenced
this pull request
Feb 26, 2020
* refactor: 💡 use .story for Storybook and standartize dir struct * feat: 🎸 add <FlyoutFrame> component * feat: 🎸 add <FlyoutCreateDrilldown> component * refactor: 💡 improve FlyoutCreateDrilldownAction * test: 💍 add <FlyoutFrame> tests * docs: ✏️ add @todo for <DrilldownHelloBar> * feat: 🎸 make name editable in <FormCreateDrilldown> * test: 💍 add <FormCreateDrilldown> name field tests * chore: 🤖 change drilldown translation keys
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Partially addresses #55302
Some progress on implementing
<FormCreateDrilldown>component. You can see the component in Storybook.Checklist
Delete any items that are not applicable to this PR.
For maintainers