Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

<FormCreateDrilldown> component #55302

Closed
10 of 11 tasks
streamich opened this issue Jan 20, 2020 · 1 comment
Closed
10 of 11 tasks

<FormCreateDrilldown> component #55302

streamich opened this issue Jan 20, 2020 · 1 comment
Assignees
@Dosant
Labels
Feature:Drilldowns Embeddable panel Drilldowns Feature:Embedding Embedding content via iFrame

Comments

@streamich
Copy link
Contributor

streamich commented Jan 20, 2020 •
edited
Loading

Create presentational React component in x-pack/plugins/drilldowns/public/components/form_create_drilldown for creating new drilldowns for a panel.

  • Form to create new drilldown <FormCreateDrilldown>:
    • Create <DrilldownHelloBar> component.
      • Remember in localStorage if user clicked onHideClick.
      • Do not show component if user once clicked onHideClick.
    • Should collect name for the drilldown.
    • Use <ActionPicker> component.
    • Render Save and Close/Cancel buttons.
    • "Create drilldown" button is disabled until form is filled in.
  • Error handling
    • Should not be able to create drilldown with already existing name.
    • Should not be able to create drilldown with missing: (1) name; (2) destination; (3) destination configuration.

image

image

Parent issue: #55291
@streamich streamich added Feature:Drilldowns Embeddable panel Drilldowns Feature:Embedding Embedding content via iFrame Team:AppArch labels Jan 20, 2020
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-app-arch (Team:AppArch)

This was referenced Jan 20, 2020
Closed
Closed
Closed
Closed
Closed
Closed
@streamich streamich added the 5sp label Jan 20, 2020
@streamich streamich self-assigned this Feb 24, 2020
@streamich streamich mentioned this issue Feb 24, 2020
Merged
2 tasks
@streamich streamich mentioned this issue Mar 6, 2020
Closed
9 tasks
@streamich streamich assigned Dosant and unassigned streamich Mar 11, 2020
@Dosant Dosant closed this as completed Mar 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Dosant Dosant

Labels
Feature:Drilldowns Embeddable panel Drilldowns Feature:Embedding Embedding content via iFrame
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@Dosant @streamich @elasticmachine