-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Maps] allow simultaneous opening of multiple tooltips #57226
Conversation
Pinging @elastic/kibana-gis (Team:Geo) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested locally on Chromium, it works great 👍
I never imagined this being so useful in the context of how we do both tooltips and pop up windows when clicking, so you can wander and explore over the map, and then you can focus by clicking when you see something interesting and repeat.
@elasticmachine merge upstream |
@elasticmachine merge upstream |
💛 Build succeeded, but was flaky
Test FailuresKibana Pipeline / kibana-xpack-agent / Chrome X-Pack UI Functional Tests.x-pack/test/functional/apps/rollup_job/tsvb·js.rollup app tsvb integration create rollup tsvbStandard Out
Stack Trace
History
To update your PR or re-run it, just comment with: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sweet!!!
* split TooltipPopover from TooltipContent * display multiple tooltips * hack to fix spacing * hover tooltip * fix jest tests for new props * update snapshots * simplify jest tests * avoid opening up multiple tooltips in same location * remove duplicated code Co-authored-by: Elastic Machine <[email protected]>
* split TooltipPopover from TooltipContent * display multiple tooltips * hack to fix spacing * hover tooltip * fix jest tests for new props * update snapshots * simplify jest tests * avoid opening up multiple tooltips in same location * remove duplicated code Co-authored-by: Elastic Machine <[email protected]> Co-authored-by: Elastic Machine <[email protected]>
* master: (22 commits) skip flaky suite (elastic#50018) skip settings tests (elastic#57608) skip failing suite (elastic#44631) [SIEM] [Case] Initial UI (elastic#57283) handle viewing sample dashboards on default dist (elastic#57510) Fix detection of "system requests" in plugins (elastic#57149) [ML] New Platform server shim: update job service schema (elastic#57614) skip flaky suite (elastic#44631) [APM] Update monospace font family variable (elastic#57555) skip flaky test (elastic#57377) Skip save query tests (elastic#57589) [Maps] allow simultaneous opening of multiple tooltips (elastic#57226) [Uptime] Fix/host connected components (elastic#56969) [logs][metrics][docs] Update screenshots for 7.6 (elastic#57254) [ML] New Platform server shim: update job service routes to use new platform router (elastic#57403) [Maps] Fix document source top hits split by scripted field (elastic#57481) Use log4j pattern syntax (elastic#57433) [ML] Categorization field example endpoint tests (elastic#57471) [Lens] Filter out pinned filters from saved object of Lens (elastic#57197) Lens client side shim cleanup (elastic#56976) ...
…149254) Fixes #148819 When [multiple tooltips](#57226) first merged in 7.7.0, TooltipFeature only had `id` and `layerId` property so the original equality check `_.isEqual(features, tooltipState.features)` prevented tooltips from opening that shows identical features. Later releases added new properties to TooltipFeature that broke this deep equals check. This PR resolves the issue by mapping features to just `{id, layerId}` before equality check to ensure those are the only properties that determine equality. Co-authored-by: kibanamachine <[email protected]>
fixes #56645
This PR allows users to open multiple tooltips at a time. This will allow users to compare values across features.