Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Maps] Do not allow opening multiple tooltips for single feature #148819

Closed
syedrafice opened this issue Jan 12, 2023 · 2 comments · Fixed by #149254
Closed

[Maps] Do not allow opening multiple tooltips for single feature #148819

syedrafice opened this issue Jan 12, 2023 · 2 comments · Fixed by #149254
Assignees
@nreese
Labels
bug Fixes for quality problems that affect the customer experience Feature:Maps impact:medium Addressing this issue will have a medium level of impact on the quality/strength of our product. Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas

Comments

@syedrafice
Copy link

Kibana version:
Tested 8.5.3
Elasticsearch version:
Tested 8.5.3
Server OS version:
ESS
Browser version:
Chrome 108.0.5359.124
Browser OS version:

Original install method (e.g. download page, yum, from source, etc.):
ESS
Describe the bug:

When you use the "Create Index" layer type and add a new shape and click on it, tooltip errors appear but stay on the page

Steps to reproduce:

  1. Open Kibana Maps
  2. Use the Create Index layer type
  3. Add a shape
  4. Click on the shape multiple times

Expected behavior:

Screenshots (if relevant):
See attached
Errors in browser console (if relevant):

Provide logs and/or server output (if relevant):

Any additional context:
image
@syedrafice syedrafice added the bug Fixes for quality problems that affect the customer experience label Jan 12, 2023
@botelastic botelastic bot added the needs-team Issues missing a team label label Jan 12, 2023
@dej611 dej611 added Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas Feature:Maps labels Jan 12, 2023
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-presentation (Team:Presentation)

@botelastic botelastic bot removed the needs-team Issues missing a team label label Jan 12, 2023
@nreese nreese changed the title Kibana Maps "Create Index" layer Tooltip Persistence [Maps] Do not allow opening multiple tooltips for single feature Jan 17, 2023
@nreese nreese added the impact:medium Addressing this issue will have a medium level of impact on the quality/strength of our product. label Jan 17, 2023
@nreese
Copy link
Contributor

nreese commented Jan 17, 2023

@syedrafice Thanks for opening. I have renamed issue to "Do not allow opening multiple tooltips for single feature". The problem is not tied to features created from drawing on map, but instead a general problem that allows opening a tooltip multiple times for the same feature, which does not make sense.

@nreese nreese mentioned this issue Jan 19, 2023
Merged
@nreese nreese self-assigned this Jan 19, 2023
nreese added a commit that referenced this issue Jan 23, 2023
@nreese @kibanamachine
[Maps] fix Do not allow opening multiple tooltips for single feature (#…
050cf79 
…149254)

Fixes #148819

When [multiple tooltips](#57226)
first merged in 7.7.0, TooltipFeature only had `id` and `layerId`
property so the original equality check `_.isEqual(features,
tooltipState.features)` prevented tooltips from opening that shows
identical features. Later releases added new properties to
TooltipFeature that broke this deep equals check.

This PR resolves the issue by mapping features to just `{id, layerId}`
before equality check to ensure those are the only properties that
determine equality.

Co-authored-by: kibanamachine <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@nreese nreese

Labels
bug Fixes for quality problems that affect the customer experience Feature:Maps impact:medium Addressing this issue will have a medium level of impact on the quality/strength of our product. Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[Maps] fix Do not allow opening multiple tooltips for single feature nreese/kibana
4 participants
@nreese @dej611 @elasticmachine @syedrafice